Re: Re: Re: QPA plugin like functionality in frameworks?

2015-06-25 Thread Martin Gräßlin
On Wednesday 24 June 2015 23:20:21 Aleix Pol wrote: On Wed, Jun 24, 2015 at 9:51 AM, Martin Gräßlin mgraess...@kde.org wrote: On Tuesday 23 June 2015 19:35:48 Aleix Pol wrote: On Tue, Jun 23, 2015 at 9:42 AM, Martin Gräßlin mgraess...@kde.org wrote: Hi framework-developers and packagers,

Re: Review Request 124165: Make KArchive preserve permissions from the files inside the archive

2015-06-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124165/#review81738 --- Preserving the executable flag sounds like a good idea

Re: Review Request 124155: Add KStatusNotifierItem::action(const QString ) to retrieve an action by name

2015-06-25 Thread Alexander Potashev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124155/#review81741 --- Nothing criminal I could see here. Side note: I guess action

Re: Review Request 124165: Make KArchive preserve executable permissions from the files inside the archive

2015-06-25 Thread Romário Rios
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124165/ --- (Updated June 25, 2015, 12:44 p.m.) Review request for KDE Frameworks.

Re: Review Request 124155: Add KStatusNotifierItem::action(const QString ) to retrieve an action by name

2015-06-25 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124155/#review81740 --- Any comments? - Martin Klapetek On June 23, 2015, 2:04

Re: Review Request 124165: Make KArchive preserve executable permissions from the files inside the archive

2015-06-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124165/#review81749 --- At this point I wonder if three if()s wouldn't be a lot less