Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

2015-06-30 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124133/#review81885 --- ping applications maintainers: please also consider whether

Re: Review Request 124128: KDirWatch: Only establish a connection to FAM if requested

2015-06-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124128/#review81881 --- src/lib/io/kdirwatch.cpp (line 176)

Re: Review Request 124212: kwindowsystem: Change source file layout

2015-06-30 Thread Kai Uwe Broulik
On Juni 30, 2015, 8:30 vorm., Kai Uwe Broulik wrote: Doesn't build on OSX: [ 24%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/osx/kkeyserver_mac.cpp.o [ 27%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/KF5WindowSystem_automoc.cpp.o In file

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

2015-06-30 Thread Martin Gräßlin
On June 20, 2015, 9:10 p.m., Martin Klapetek wrote: +1 for adding all that info -1 for putting it into its own tab; previously it was visible right away, now an additional click is needed. Maybe it could be stacked all under the application name? I mean it's just 2 more lines to add

Re: Review Request 124212: kwindowsystem: Change source file layout

2015-06-30 Thread Martin Gräßlin
On June 30, 2015, 10:30 a.m., Kai Uwe Broulik wrote: Doesn't build on OSX: [ 24%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/osx/kkeyserver_mac.cpp.o [ 27%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/KF5WindowSystem_automoc.cpp.o In file

Re: Review Request 124212: kwindowsystem: Change source file layout

2015-06-30 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124212/#review81880 --- Doesn't build on OSX: [ 24%] Building CXX object

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

2015-06-30 Thread Albert Astals Cid
On jun. 30, 2015, 8:41 a.m., Martin Gräßlin wrote: ping applications maintainers: please also consider whether version should be first tab or whether about should stay first tab. If we are going to do this, About should be the first tab, after all i'm getting to that dialog by doing Help

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

2015-06-30 Thread Lamarque Souza
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124133/#review81893 --- src/kaboutapplicationdialog.cpp (line 155)

Re: Review Request 124213: Add standard shortcut for new tab action

2015-06-30 Thread David Faure
On June 30, 2015, 12:07 p.m., Kai Uwe Broulik wrote: src/gui/kstandardshortcut.h, line 372 https://git.reviewboard.kde.org/r/124213/diff/1/?file=381769#file381769line372 Isn't Ctrl+Tab usually next tab? Aleix Pol Gonzalez wrote: Here, Konsole uses shift+arrow to change tab.

Re: Review Request 124117: KPlotting: fix missing tickmarks when x0 0.

2015-06-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124117/ --- (Updated June 30, 2015, 12:45 p.m.) Status -- This change has been

Re: Review Request 124121: KPlotWidget: add setAutoDeletePlotObjects, fix memory leak in replacePlotObject

2015-06-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124121/ --- (Updated June 30, 2015, 12:45 p.m.) Status -- This change has been

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

2015-06-30 Thread Lamarque Souza
On June 20, 2015, 7:10 p.m., Martin Klapetek wrote: +1 for adding all that info -1 for putting it into its own tab; previously it was visible right away, now an additional click is needed. Maybe it could be stacked all under the application name? I mean it's just 2 more lines to add

Re: Review Request 124213: Add standard shortcut for new tab action

2015-06-30 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124213/#review81896 --- +1 for Ctrl+T but not sure about Ctrl+Shift+N, never seen

Re: Review Request 124213: Add standard shortcut for new tab action

2015-06-30 Thread Aleix Pol Gonzalez
On June 30, 2015, 2:07 p.m., Kai Uwe Broulik wrote: src/gui/kstandardshortcut.h, line 372 https://git.reviewboard.kde.org/r/124213/diff/1/?file=381769#file381769line372 Isn't Ctrl+Tab usually next tab? Here, Konsole uses shift+arrow to change tab. Also it doesn't use Ctrl+T. -

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

2015-06-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124133/#review81891 --- +1 to move the version into a separate tab. +1 to keeping

Re: Review Request 123831: Coding Style for main.cpp

2015-06-30 Thread Guy Maurel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123831/ --- (Updated June 30, 2015, 1 p.m.) Status -- This change has been

Re: Review Request 123830: Coding Style for main.cpp

2015-06-30 Thread Guy Maurel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123830/ --- (Updated June 30, 2015, 1 p.m.) Status -- This change has been

Re: Review Request 124212: kwindowsystem: Change source file layout

2015-06-30 Thread Kai Uwe Broulik
On Juni 30, 2015, 8:30 vorm., Kai Uwe Broulik wrote: Doesn't build on OSX: [ 24%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/osx/kkeyserver_mac.cpp.o [ 27%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/KF5WindowSystem_automoc.cpp.o In file

Re: Review Request 124212: kwindowsystem: Change source file layout

2015-06-30 Thread Martin Gräßlin
On June 30, 2015, 10:30 a.m., Kai Uwe Broulik wrote: Doesn't build on OSX: [ 24%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/osx/kkeyserver_mac.cpp.o [ 27%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/KF5WindowSystem_automoc.cpp.o In file

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

2015-06-30 Thread Martin Gräßlin
On June 30, 2015, 10:41 a.m., Martin Gräßlin wrote: ping applications maintainers: please also consider whether version should be first tab or whether about should stay first tab. Albert Astals Cid wrote: If we are going to do this, About should be the first tab, after all i'm

Review Request 124213: Add standard shortcut for new tab action

2015-06-30 Thread Simon Persson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124213/ --- Review request for KDE Frameworks. Repository: kconfig Description

Re: Review Request 124212: kwindowsystem: Change source file layout

2015-06-30 Thread Martin Gräßlin
On Juni 30, 2015, 4:59 nachm., Aleix Pol Gonzalez wrote: In general, I like it. Maybe now that we're putting the files in separate directories, we can drop the _mac postfixes? I like the idea, but that won't be possible for all cases. E.g. with kkeyserver_foo it's still needed as

Re: Review Request 124128: KDirWatch: Only establish a connection to FAM if requested

2015-06-30 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124128/ --- (Updated June 30, 2015, 2:50 p.m.) Review request for KDE Frameworks and

Re: Review Request 124212: kwindowsystem: Change source file layout

2015-06-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124212/#review81902 --- In general, I like it. Maybe now that we're putting the

Re: Review Request 124212: kwindowsystem: Change source file layout

2015-06-30 Thread Aleix Pol Gonzalez
On June 30, 2015, 4:59 p.m., Aleix Pol Gonzalez wrote: In general, I like it. Maybe now that we're putting the files in separate directories, we can drop the _mac postfixes? Martin Gräßlin wrote: I like the idea, but that won't be possible for all cases. E.g. with

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

2015-06-30 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124133/ --- (Updated Juni 30, 2015, 4:11 nachm.) Review request for KDE Frameworks.

Re: QPA plugin like functionality in frameworks?

2015-06-30 Thread Albert Astals Cid
El Dijous, 25 de juny de 2015, a les 08:46:07, Martin Gräßlin va escriure: On Wednesday 24 June 2015 23:20:21 Aleix Pol wrote: On Wed, Jun 24, 2015 at 9:51 AM, Martin Gräßlin mgraess...@kde.org wrote: On Tuesday 23 June 2015 19:35:48 Aleix Pol wrote: On Tue, Jun 23, 2015 at 9:42 AM,

Review Request 124212: kwindowsystem: Change source file layout

2015-06-30 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124212/ --- Review request for KDE Frameworks. Repository: kwindowsystem

Re: Review Request 124213: Add standard shortcut for new tab action

2015-06-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124213/#review81894 --- Makes sense. Maybe it would make sense to reconsider the