ksycoca improvements (Re: assert in kservicetypefactory.cpp)

2015-08-22 Thread David Faure
On Wednesday 19 August 2015 09:08:35 Boudewijn Rempt wrote: A windows or osx application for the masses must: * not have any pre or post install procedures * not start any process except the application itself * avoid ipc as much as possible * find all resources and plugins relative to itself

Review Request 124876: KSycoca: check timestamps and run kbuildsycoca if needed. No kded needed anymore.

2015-08-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124876/ --- Review request for KDE Frameworks, Boudewijn Rempt and Vishesh Handa.

Re: Jenkins-kde-ci: kio master stable-kf5-qt5 ยป Linux, gcc - Build # 65 - Unstable!

2015-08-22 Thread Volker Krause
On Friday 21 August 2015 22:34:21 David Faure wrote: On Friday 21 August 2015 08:46:28 no-re...@kde.org wrote: TestSuite.kiofilewidgets-kfileplacesmodeltest Nooo :-( The QSet ordering problem is still there, even with qputenv(QT_HASH_SEED, 0); Does 0 instead of 0 help here?

Review Request 124878: Cache a KEmoticons instance here, not a KEmoticonsTheme.

2015-08-22 Thread Volker Krause
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124878/ --- Review request for KDE Frameworks. Repository: kemoticons Description

Review Request 124884: Fix KSwitchLangaugeDialog

2015-08-22 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124884/ --- Review request for KDE Frameworks. Repository: kxmlgui Description

Re: Review Request 124879: Optimization readEntryGui

2015-08-22 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124879/#review84189 --- While you're at it move formatError down to the only place it

Re: Review Request 124879: Optimization readEntryGui

2015-08-22 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124879/ --- (Updated Aug. 22, 2015, 5:11 p.m.) Status -- This change has been

Re: Review Request 124879: Optimization readEntryGui

2015-08-22 Thread Kevin Funk
On Aug. 22, 2015, 5:05 p.m., Albert Astals Cid wrote: While you're at it move formatError down to the only place it is used? Done - Kevin --- This is an automatically generated e-mail. To reply, visit:

Review Request 124879: Optimization readEntryGui

2015-08-22 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124879/ --- Review request for KDE Frameworks and Matthew Dawson. Repository:

Re: Review Request 124879: Optimization readEntryGui

2015-08-22 Thread Volker Krause
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124879/#review84187 --- Looks good to me. - Volker Krause On Aug. 22, 2015, 3:06

Re: Review Request 124879: Optimization readEntryGui

2015-08-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124879/#review84188 --- Ship it! nice use for a lambda :) - David Faure On Aug.