Review Request 124963: New widget: KNewPasswordWidget

2015-08-28 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124963/ --- Review request for KDE Frameworks and Christoph Feck. Repository:

Re: Review Request 124698: KPasswordDialog: allow the user to show the password

2015-08-28 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124698/ --- (Updated Aug. 28, 2015, 7:54 a.m.) Status -- This change has been

Re: Review Request 124876: KSycoca: check timestamps and run kbuildsycoca if needed. No kded needed anymore.

2015-08-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124876/ --- (Updated Aug. 28, 2015, 9:41 a.m.) Status -- This change has been

Re: Review Request 124963: New widget: KNewPasswordWidget

2015-08-28 Thread Lamarque Souza
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124963/#review84525 --- src/knewpasswordwidget.h (line 179)

Re: Review Request 124963: New widget: KNewPasswordWidget

2015-08-28 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124963/ --- (Updated Ago. 28, 2015, 1:56 p.m.) Review request for KDE Frameworks and

Re: Review Request 124963: New widget: KNewPasswordWidget

2015-08-28 Thread Elvis Angelaccio
On Ago. 28, 2015, 11:30 a.m., Lamarque Souza wrote: src/knewpasswordwidget.cpp, line 92 https://git.reviewboard.kde.org/r/124963/diff/1/?file=399453#file399453line92 Is there any documentation explaining this calculation? I don't know, sorry. The whole strength calculator code is

Re: Review Request 124963: New widget: KNewPasswordWidget

2015-08-28 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124963/ --- (Updated Ago. 28, 2015, 3:52 p.m.) Review request for KDE Frameworks and

Re: Review Request 124963: New widget: KNewPasswordWidget

2015-08-28 Thread Lamarque Souza
On Aug. 28, 2015, 11:30 a.m., Lamarque Souza wrote: src/knewpasswordwidget.cpp, line 92 https://git.reviewboard.kde.org/r/124963/diff/1/?file=399453#file399453line92 Is there any documentation explaining this calculation? Elvis Angelaccio wrote: I don't know, sorry. The

Re: Review Request 124846: i18n: Fix untranslatable string

2015-08-28 Thread Alexander Potashev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124846/ --- (Updated Aug. 28, 2015, 8:50 p.m.) Status -- This change has been