KTabWidget vs QTabWidget

2015-09-18 Thread Jeremy Whiting
Hey all, In looking into fixing the remaining issues in Okular's frameworks branch I realized that in part of the effort to port it away from KDELibs4Support it got some functionality removed. It was ported from KTabWidget to QTabWidget but QTabWidget doesn't seem to support drag and drop the way

Re: Review Request 125274: KBuildSycoca: remove writing of the ksycoca5stamp file.

2015-09-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125274/ --- (Updated Sept. 18, 2015, 8:08 a.m.) Status -- This change has been

Re: Building KF in version 5.14 on OSX fails for framework kdesignerplugin

2015-09-18 Thread Marko Käning
Dear Kurt, On 16 Sep 2015, at 15:20 , Kurt Hindenburg wrote: > Git commit 6cbf534c3cd2c5bdda819e092c9778c27e814161 by Kurt Hindenburg. thanks for your commit! Looking forward to release 5.15 then, David. :) Greets, Marko

Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.

2015-09-18 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/#review85643 --- Ship it! Ship It! - Albert Astals Cid On set. 16, 2015,

Re: Review Request 125261: Add mimeTypes() to KPluginMetaData

2015-09-18 Thread Sebastian Kügler
> On Sept. 16, 2015, 9:44 p.m., Sebastian Kügler wrote: > > autotests/kpluginmetadatatest.cpp, line 110 > > > > > > Should be a list, so enclosed with [ ]. > > > > In the header docs, you also say

Re: Review Request 125259: Support multiple X servers in the NETWM classes

2015-09-18 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125259/#review85619 --- src/platforms/xcb/netwm_p.h (line 31)

Re: Review Request 125278: KSycoca: add a q pointer to remove more singleton usage

2015-09-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125278/ --- (Updated Sept. 18, 2015, 12:21 p.m.) Status -- This change has been

Re: Review Request 125259: Support multiple X servers in the NETWM classes

2015-09-18 Thread Martin Gräßlin
> On Sept. 18, 2015, 2:21 p.m., Thomas Lübking wrote: > > src/platforms/xcb/netwm_p.h, line 31 > > > > > > errrhemmm ... the idea was actually to keep things more in sync and not > > have to match variable,

Re: Review Request 125272: KSycoca: rebuild sycoca in-process in most unittests as well.

2015-09-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125272/ --- (Updated Sept. 18, 2015, 7:17 a.m.) Status -- This change has been

Re: Review Request 125259: Support multiple X servers in the NETWM classes

2015-09-18 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125259/ --- (Updated Sept. 18, 2015, 10:19 a.m.) Review request for KDE Frameworks.

Review Request 125300: Fix lock in KProtocolManager

2015-09-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125300/ --- Review request for KDE Frameworks. Bugs: 350890

Re: Review Request 125300: Fix lock in KProtocolManager

2015-09-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125300/#review85628 --- Recursive mutexes are more costly and a symptom of bad