Re: Review Request 125497: KSycoca: store mtime for every source dir, to detect changes.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125497/#review86358 --- Ship it! Works totally fine, thanks for fixing this.. :) -

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 107 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/107/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 04 Oct 2015 09:26:05 + Build duration: 7 min 6 sec CHANGE SET Revision

Reviews needed for KF 5.15

I am currently blocked for releasing KF 5.15 because I think these bugfixes should be in, and they need review: https://git.reviewboard.kde.org/r/125497/ ("KSycoca: spot dirs from the future, and `touch` them to avoid constant ksycoca rebuilds") https://git.reviewboard.kde.org/r/125504/

Re: Review Request 125504: KServiceTypeProfile: remove unnecessary factory creation, to fix a deadlock

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125504/ --- (Updated Oct. 4, 2015, 9:40 a.m.) Review request for KDE Frameworks and

Re: Review Request 125517: KShell::splitArgs: only ASCII space is a separator, not unicode space U+3000

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125517/ --- (Updated Oct. 4, 2015, 12:59 p.m.) Status -- This change has been

Re: Reviews needed for KF 5.15

On Sun, Oct 4, 2015 at 3:11 PM, David Faure wrote: > https://git.reviewboard.kde.org/r/125497/ > ("KSycoca: spot dirs from the future, and `touch` them to avoid constant > ksycoca rebuilds") I will need bit of help from our packagers to package it.. Once this is packaged I can

Re: Review Request 125517: KShell::splitArgs: only ASCII space is a separator, not unicode space U+3000

> On Oct. 4, 2015, 11:25 a.m., David Faure wrote: > > Albert, in review 122300 (commit b746dcf93239e93eafeedfaeff53e1ac387f5ca1 > > in kcoreaddons), you mentionned that commit was a workaround, I think this > > is the real fix for it? Actually, it seems so. I can remove the "hack" from that

Re: Review Request 125517: KShell::splitArgs: only ASCII space is a separator, not unicode space U+3000

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125517/ --- (Updated Oct. 4, 2015, 11:28 a.m.) Review request for KDE Frameworks and

Re: Review Request 125517: KShell::splitArgs: only ASCII space is a separator, not unicode space U+3000

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125517/#review86325 --- Albert, in review 122300 (commit

Re: Review Request 125514: Add a web shortcut manager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125514/#review86327 --- Seems useful to have, I've seen such actions in multiple

Re: Review Request 125497: KSycoca: spot dirs from the future, and `touch` them to avoid constant ksycoca rebuilds.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125497/#review86331 --- Ship it! Ship It! - Albert Astals Cid On oct. 4, 2015,

Re: Review Request 125497: KSycoca: spot dirs from the future, and `touch` them to avoid constant ksycoca rebuilds.

> On Oct. 4, 2015, 6:01 p.m., Albert Astals Cid wrote: > > Ship It! Actually this patch doesn't fix teh issue. (See bug report) - Bhushan --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 125517: KShell::splitArgs: only ASCII space is a separator, not unicode space U+3000

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125517/#review86333 --- Ship it! Ship It! - Albert Astals Cid On oct. 4, 2015,

Re: Review Request 125497: KSycoca: spot dirs from the future, and `touch` them to avoid constant ksycoca rebuilds.

> On Oct. 4, 2015, 10:30 a.m., Albert Astals Cid wrote: > > Can we have a test for this? Or is it hard to re-create the conditions > > artificially? I don't understand your question. This RR includes an autotest. - David --- This is

Re: Review Request 125511: Add missing documentation for argument to LAUNCHER_EXEC_NEW

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125511/#review86317 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 3, 2015,

Re: Review Request 125497: KSycoca: spot dirs from the future, and `touch` them to avoid constant ksycoca rebuilds.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125497/#review86322 --- Can we have a test for this? Or is it hard to re-create the

Review Request 125517: KShell::splitArgs: only ASCII space is a separator, not unicode space U+3000

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125517/ --- Review request for KDE Frameworks and Albert Astals Cid. Repository:

Review Request 125515: Preserve relative link targets when copying symlinks.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125515/ --- Review request for KDE Frameworks. Bugs: 352927

Re: Review Request 125504: KServiceTypeProfile: remove unnecessary factory creation, to fix a deadlock

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125504/#review86320 --- Ship it! if the tests still pass, I'd say go for it. I'll

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 108 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/108/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 04 Oct 2015 09:38:49 + Build duration: 4 min 54 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 108 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/108/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 04 Oct 2015 09:38:49 + Build duration: 4 min 54 sec CHANGE SET No changes JUNIT RESULTS Name:

Re: Review Request 125504: KServiceTypeProfile: remove unnecessary factory creation, to fix a deadlock

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125504/ --- (Updated Oct. 4, 2015, 10:04 a.m.) Status -- This change has been

Re: Review Request 125497: KSycoca: spot dirs from the future, and `touch` them to avoid constant ksycoca rebuilds.

> On oct. 4, 2015, 10:30 a.m., Albert Astals Cid wrote: > > Can we have a test for this? Or is it hard to re-create the conditions > > artificially? > > David Faure wrote: > I don't understand your question. This RR includes an autotest. you're right, sorry i didn't pay enough attention.

Re: Review Request 125514: Add a web shortcut manager

> On oct. 4, 2015, 11:52 matin, David Faure wrote: > > Seems useful to have, I've seen such actions in multiple places, including > > KHTML and KWebkit (and I know you're coming from kdepim with this). > > > > I'm wondering if the naming couldn't be improved though. This has very > > little

Re: Review Request 125514: Add a web shortcut manager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125514/ --- (Updated oct. 4, 2015, 2:04 après-midi) Review request for KDE

Re: Review Request 125515: Preserve relative link targets when copying symlinks.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125515/#review86340 --- Looks good! The only thing that I'm not sure about is whether

Re: Review Request 125334: Small improvements in ColumnProxyModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125334/ --- (Updated Oct. 4, 2015, 4:27 p.m.) Status -- This change has been

Re: Review Request 125334: Small improvements in ColumnProxyModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125334/#review86337 --- +1

Re: Review Request 125334: Small improvements in ColumnProxyModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125334/#review86338 --- Ship it! Ship It! - David Edmundson On Sept. 21, 2015,

Re: Review Request 125515: Preserve relative link targets when copying symlinks.

> On Oct. 4, 2015, 5:45 p.m., Frank Reininghaus wrote: > > Looks good! The only thing that I'm not sure about is whether 1000 bytes > > are guaranteed to be enough. Some quick Googling tells me that path lengths > > of 4096 are possible. Maybe we could allocate a temporary large array on > >

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

> On Okt. 3, 2015, 8:08 vorm., David Faure wrote: > > I just realized another problem with this approach: since the latest > > libkonq release installs konqpopupmenuplugin.desktop already, this patch > > will make the next KIO release conflict with that last libkonq release > > (which by

Re: Review Request 125515: Preserve relative link targets when copying symlinks.

> On Oct. 4, 2015, 5:45 p.m., Frank Reininghaus wrote: > > Looks good! The only thing that I'm not sure about is whether 1000 bytes > > are guaranteed to be enough. Some quick Googling tells me that path lengths > > of 4096 are possible. Maybe we could allocate a temporary large array on > >

Re: Review Request 125515: Preserve relative link targets when copying symlinks.

> On Oct. 4, 2015, 5:45 p.m., Frank Reininghaus wrote: > > Looks good! The only thing that I'm not sure about is whether 1000 bytes > > are guaranteed to be enough. Some quick Googling tells me that path lengths > > of 4096 are possible. Maybe we could allocate a temporary large array on > >

Review Request 125521: Added KDropWidgetDecorator copied from DropWidget in kile sources. Relicensed from GPL 2+ to LGPL 2+ with author's permission.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125521/ --- Review request for KDE Frameworks and Christoph Feck. Repository:

Re: Review Request 125521: Added KDropWidgetDecorator copied from DropWidget in kile sources. Relicensed from GPL 2+ to LGPL 2+ with author's permission.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125521/ --- (Updated Oct. 4, 2015, 1:43 p.m.) Review request for KDE Frameworks and

Re: Review Request 125325: New widget KCollapsibleGroupBox

> On Oct. 3, 2015, 9:54 p.m., David Faure wrote: > > Thanks > On Oct. 3, 2015, 9:54 p.m., David Faure wrote: > > tests/kcollapsiblegroupboxtest.cpp, line 35 > > > > > > just curious: why? We don't know which

Re: Review Request 125515: Preserve relative link targets when copying symlinks.

> On Oct. 4, 2015, 5:45 p.m., Frank Reininghaus wrote: > > Looks good! The only thing that I'm not sure about is whether 1000 bytes > > are guaranteed to be enough. Some quick Googling tells me that path lengths > > of 4096 are possible. Maybe we could allocate a temporary large array on > >

Re: Review Request 125521: Added KDropWidgetDecorator copied from DropWidget in kile sources. Relicensed from GPL 2+ to LGPL 2+ with author's permission.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125521/#review86352 --- src/kdropwidgetdecorator.h (line 37)

Re: Review Request 125497: KSycoca: store mtime for every source dir, to detect changes.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125497/ --- (Updated Oct. 4, 2015, 6:42 p.m.) Review request for KDE Frameworks,

Re: KTabWidget vs QTabWidget

Thanks, First patch here: https://git.reviewboard.kde.org/r/125521/. After that I'll try using it in Kile and Okular, see how that goes. On Thu, Sep 24, 2015 at 11:47 PM, Michel Ludwig wrote: > > On 09/25/2015 01:57 AM, Jeremy Whiting wrote: >> >> Michel, >> >> Would

Re: Review Request 125325: New widget KCollapsibleGroupBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125325/ --- (Updated Oct. 4, 2015, 8:37 p.m.) Review request for KDE Frameworks and

Re: Review Request 125497: KSycoca: store mtime for every source dir, to detect changes.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125497/#review86355 --- Ship it! Ship It! - Albert Astals Cid On oct. 4, 2015,