Re: Version numbering at download location

2015-10-05 Thread Marko Käning
On 05 Oct 2015, at 10:08 , David Faure wrote: > On Monday 05 October 2015 09:34:04 Marko Käning wrote: >> The issue is that the version regexp match should preferably >> happen on a single web page. With this setup the full version numbers are >> spread over two dir >> levels…

Re: Building KF in version 5.14 on OSX fails for framework kdesignerplugin

2015-10-05 Thread Marko Käning
Hi David, now that I learnt, that we can have bug-fix releases in already released KF5 versions, I’d suggest a 5.14.1 for the kdesignerplugin, which contains Kurt’s fix: On 18 Sep 2015, at 20:42 , Marko Käning wrote: > Dear Kurt, > > On 16 Sep 2015, at 15:20 , Kurt

Re: Review Request 125514: Add a web shortcut manager

2015-10-05 Thread Laurent Montel
> On oct. 5, 2015, 2:01 après-midi, Eike Hein wrote: > > Comparing this to the implementation in Konversation/Konsole/Okular might > > be interesting. I looked code and it's similar. Do you have more info about it ? (missing feature from this widget etc ?) - Laurent

Re: Building KF in version 5.14 on OSX fails for framework kdesignerplugin

2015-10-05 Thread Marko Käning
Well, I know, I could simply make my Portfile use a patch file… On 05 Oct 2015, at 21:18 , Marko Käning wrote: > I’d suggest a 5.14.1 for the kdesignerplugin, which contains Kurt’s fix: … or simply wait a a tiny bit longer… Perhaps that’s less hassle then you trying to do

Re: Review Request 125106: Minor optimizations

2015-10-05 Thread Sergio Martins
> On Sept. 8, 2015, 4:46 p.m., Milian Wolff wrote: > > src/kconf_update/kconf_update.cpp, line 250 > > > > > > QLatin1String > > Albert Astals Cid wrote: > Seems like a bug in clazy, sometimes it knows that

Re: Review Request 125497: KSycoca: store mtime for every source dir, to detect changes.

2015-10-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125497/ --- (Updated Oct. 5, 2015, 7:24 a.m.) Status -- This change has been

Re: Version numbering at download location

2015-10-05 Thread David Faure
On Monday 05 October 2015 08:23:36 Marko Käning wrote: > Hi David, > > I was surprised to find that up to version 5.3.0 you were still using the > trailing zero > for the folder name below > > http://download.kde.org/stable/frameworks/ > > but from 5.4 on you started to omit it. The

Re: Version numbering at download location

2015-10-05 Thread Marko Käning
Hi David, On 05 Oct 2015, at 09:27 , David Faure wrote: > Yes, this fix allows to have hotfix releases of single frameworks. Look at > KService 5.14.1, 5.14.2 and 5.14.3. > They are in the 5.14 subdir, where they belong. ok, I wasn’t aware of that. > x.y.z where z is > 0 is

Version numbering at download location

2015-10-05 Thread Marko Käning
Hi David, I was surprised to find that up to version 5.3.0 you were still using the trailing zero for the folder name below http://download.kde.org/stable/frameworks/ but from 5.4 on you started to omit it. The archives in those folders but still have that trailing zero... Does this

Re: Version numbering at download location

2015-10-05 Thread David Faure
On Monday 05 October 2015 09:34:04 Marko Käning wrote: > The issue is that the version regexp match should preferably > happen on a single web page. With this setup the full version numbers are > spread over two dir > levels… :-( I'm not sure I understand which web page this is about. I can do

Review Request 125525: Perform deep copy of QByteArray get_stringlist_reply

2015-10-05 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125525/ --- Review request for KDE Frameworks, kwin and Albert Astals Cid.

Re: Review Request 125525: Perform deep copy of QByteArray get_stringlist_reply

2015-10-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125525/#review86363 --- Ship it! Ship It! - David Faure On Oct. 5, 2015, 8:15

Re: Review Request 125525: Perform deep copy of QByteArray get_stringlist_reply

2015-10-05 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125525/ --- (Updated Oct. 5, 2015, 8:39 a.m.) Status -- This change has been

Review Request 125535: Minor optimizations

2015-10-05 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125535/ --- Review request for KDE Frameworks. Repository: karchive Description

Re: Review Request 125535: Minor optimizations

2015-10-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125535/#review86399 --- src/k7zip.cpp (line 2567)

Review Request 125536: Remove unused variable warnings

2015-10-05 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125536/ --- Review request for KDE Frameworks. Repository: karchive Description

Review Request 125537: Use largest timestamp in subdirectory as resource directory timestamp.

2015-10-05 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125537/ --- Review request for KDE Frameworks, Albert Astals Cid and David Faure.

Re: Review Request 125106: Minor optimizations

2015-10-05 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125106/ --- (Updated Oct. 5, 2015, 1:16 p.m.) Status -- This change has been

Re: Review Request 125261: Add mimeTypes() to KPluginMetaData

2015-10-05 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125261/ --- (Updated Oct. 5, 2015, 11:36 a.m.) Status -- This change has been

Review Request 125527: Add mimeTypes() to KPluginMetaData

2015-10-05 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125527/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: Review Request 124872: Default to Breeze colors

2015-10-05 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124872/ --- (Updated Oct. 5, 2015, 2 p.m.) Status -- This change has been

Re: Review Request 125514: Add a web shortcut manager

2015-10-05 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125514/#review86373 --- Comparing this to the implementation in

Review Request 125531: Mark KProcess::pid() as depreciated

2015-10-05 Thread Kurt Hindenburg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125531/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Review Request 125532: KTextEdit: fix loading Sonnet default settings, add context menu to switch spell-checking language

2015-10-05 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125532/ --- Review request for KDE Frameworks and Laurent Montel. Repository: