Re: Review Request 123719: kbuildsycoca: parse all the mimeapps.list files mentionned in the new spec.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123719/#review86694 --- ping? - David Faure On Sept. 19, 2015, 9:44 p.m., David

Re: Review Request 125595: Alllow kxmlgui framework to be used without any installed files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125595/ --- (Updated Oct. 12, 2015, 6:52 a.m.) Status -- This change has been

X11 on Windows

Hi frameworks and windows devs, from the release announcement of the latest frameworks release I learned that there were multiple changes to disable finding X11 on Windows (e.g. [1]). I think such changes are wrong and I have spoken against such changes (they are wrong, CMake supports

Re: Review Request 125595: Alllow kxmlgui framework to be used without any installed files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125595/#review86690 --- Ship it! Ship It! - David Faure On Oct. 11, 2015, 10:01

Re: X11 on Windows

On 12 October 2015 at 08:33, Martin Graesslin wrote: > Hi frameworks and windows devs, > > from the release announcement of the latest frameworks release I learned that > there were multiple changes to disable finding X11 on Windows (e.g. [1]). I > think such changes are wrong

Review Request 125598: Allow KConfig to use resources as fallback config files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125598/ --- Review request for KDE Frameworks and David Faure. Repository: kconfig

Re: Review Request 125514: Add a web shortcut manager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125514/#review86691 --- Ship it! autotests/kurifiltersearchprovideractionstest.cpp

Re: X11 on Windows

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 12.10.2015 um 10:01 schrieb Jaroslaw Staniek: > On 12 October 2015 at 08:33, Martin Graesslin > wrote: >> Hi frameworks and windows devs, >> >> from the release announcement of the latest frameworks release I >> learned that

Review Request 125603: Add function to query standards xml file location

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125603/ --- Review request for KDE Frameworks and David Faure. Repository: kxmlgui

Re: Review Request 125603: Add function to query standards xml file location

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125603/ --- (Updated Oct. 12, 2015, 11:04 a.m.) Review request for KDE Frameworks

Re: Review Request 125603: Add function to query standards xml file location

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125603/ --- (Updated Oct. 12, 2015, 11:03 a.m.) Review request for KDE Frameworks

Re: Review Request 125603: Add function to query standards xml file location

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125603/ --- (Updated Oct. 12, 2015, 11:15 a.m.) Status -- This change has been

Re: Review Request 125603: Add function to query standards xml file location

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125603/ --- (Updated Oct. 12, 2015, 11:07 a.m.) Review request for KDE Frameworks

Re: Review Request 125603: Add function to query standards xml file location

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125603/ --- (Updated Oct. 12, 2015, 11:08 a.m.) Review request for KDE Frameworks

Re: Review Request 125603: Add function to query standards xml file location

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125603/#review86702 --- I would say static, since it doesn't need an instance. -

Re: X11 on Windows

On Monday, October 12, 2015 10:01:42 AM CEST Jaroslaw Staniek wrote: > On 12 October 2015 at 08:33, Martin Graesslin wrote: > > Hi frameworks and windows devs, > > > > from the release announcement of the latest frameworks release I learned > > that there were multiple

Re: Review Request 125603: Add function to query standards xml file location

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125603/#review86704 --- Ship it! src/kxmlguiclient.cpp (line 216)

Re: Review Request 123719: kbuildsycoca: parse all the mimeapps.list files mentionned in the new spec.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123719/ --- (Updated Oct. 12, 2015, 3:40 p.m.) Status -- This change has been

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 97 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/97/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 12 Oct 2015 15:40:48 + Build duration: 2 min 19 sec CHANGE SET Revision

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 93 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/93/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 12 Oct 2015 15:40:48 + Build duration: 2 min 1 sec CHANGE SET Revision

Re: Review Request 124963: New widget: KNewPasswordWidget

> On Oct. 11, 2015, 9:16 p.m., David Faure wrote: > > src/knewpasswordwidget.cpp, line 146 > > > > > > (This method is really a candidate for being unittested directly; just > > a thought) This is not a public

Re: Review Request 124963: New widget: KNewPasswordWidget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124963/ --- (Updated Oct. 12, 2015, 4:13 p.m.) Review request for KDE Frameworks and

Re: Review Request 124963: New widget: KNewPasswordWidget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124963/#review86728 --- src/knewpasswordwidget.cpp (line 291)

Re: Review Request 125532: KTextEdit: fix loading Sonnet default settings, add context menu to switch spell-checking language

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125532/ --- (Updated Oct. 12, 2015, 12:32 p.m.) Status -- This change has been

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 131 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/131/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 12 Oct 2015 10:35:17 + Build duration: 12 min CHANGE SET Revision c7ed3b31a80b856c23740f8065dadecdf3e6ef69 by

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 131 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/131/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 12 Oct 2015 10:35:17 + Build duration: 12 min CHANGE SET Revision c7ed3b31a80b856c23740f8065dadecdf3e6ef69 by

Re: Review Request 125598: Allow KConfig to use resources as fallback config files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125598/ --- (Updated Oct. 12, 2015, 12:55 p.m.) Review request for KDE Frameworks

Re: Review Request 125514: Add a web shortcut manager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125514/ --- (Updated oct. 12, 2015, 11:36 matin) Status -- This change has been

Re: Review Request 125514: Add a web shortcut manager

> On oct. 12, 2015, 7:02 matin, David Faure wrote: > > autotests/kurifiltersearchprovideractionstest.cpp, line 51 > > > > > > Well, KIO itself installs a large number of search providers, so this > > unittest

Re: Review Request 123719: kbuildsycoca: parse all the mimeapps.list files mentionned in the new spec.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123719/#review86723 --- Ship it! Ship It! - Albert Astals Cid On set. 19, 2015,

Re: Review Request 124963: New widget: KNewPasswordWidget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124963/ --- (Updated Oct. 12, 2015, 5:01 p.m.) Review request for KDE Frameworks and

Review Request 125612: Make doctools optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125612/ --- Review request for KDE Frameworks and kdewin. Repository: kservice

Review Request 125611: Make SharedMimeInfo an optional requirement

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125611/ --- Review request for KDE Frameworks, David Faure and Kåre Särs.

Review Request 125614: Enable normal rpath handling on Mac

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125614/ --- Review request for KDE Software on Mac OS X, KDE Frameworks and Alex

phonon dep in knotifications

Hi, I would like to make this dependency optional. Would that be ok? Is not that much work, but if it is not wanted, don't want to waste my time. E.g. on Win/Mac its a real hassle to build and most applications don't need it anyway but might depend on knotifications. Greetings Christoph --

Re: Review Request 125611: Make SharedMimeInfo an optional requirement

> On Oct. 12, 2015, 7:48 p.m., David Faure wrote: > > I think you should install the xml file even if s-m-i isn't found. > > > > Otherwise, if someone installs kcoreaddons before s-m-i, he'll be missing > > the file. Ok, I will install the xml but skip the call to the then not known update

Re: Review Request 125612: Make doctools optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125612/ --- (Updated Oct. 12, 2015, 8:10 p.m.) Review request for KDE Frameworks,

Re: Review Request 124963: New widget: KNewPasswordWidget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124963/ --- (Updated Oct. 12, 2015, 8:22 p.m.) Review request for KDE Frameworks and

Re: phonon dep in knotifications

On 2015-10-12, Christoph Cullmann wrote: > Hi, > > I would like to make this dependency optional. > Would that be ok? Is not that much work, but if it is not wanted, don't want > to waste my time. > E.g. on Win/Mac its a real hassle to build and most applications don't need

Re: Review Request 125611: Make SharedMimeInfo an optional requirement

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125611/#review86741 --- I think you should install the xml file even if s-m-i isn't

Re: Review Request 124963: New widget: KNewPasswordWidget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124963/#review86742 --- Ship it! I have suggestions on how to improve the unit test,

Re: Review Request 125611: Make SharedMimeInfo an optional requirement

> On Oct. 12, 2015, 7:48 p.m., David Faure wrote: > > I think you should install the xml file even if s-m-i isn't found. > > > > Otherwise, if someone installs kcoreaddons before s-m-i, he'll be missing > > the file. > > Christoph Cullmann wrote: > Ok, I will install the xml but skip the

Re: Review Request 125611: Make SharedMimeInfo an optional requirement

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125611/ --- (Updated Oct. 12, 2015, 8:01 p.m.) Status -- This change has been

Review Request 125615: Make phonon dependency optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125615/ --- Review request for KDE Frameworks and Sune Vuorela. Repository:

Re: phonon dep in knotifications

> On 2015-10-12, Christoph Cullmann wrote: >> Hi, >> >> I would like to make this dependency optional. >> Would that be ok? Is not that much work, but if it is not wanted, don't want >> to >> waste my time. >> E.g. on Win/Mac its a real hassle to build and most applications

Re: Review Request 125614: Enable normal rpath handling on Mac

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125614/#review86752 --- There is an issue with Qt 5.5.0's configure script,

Re: Review Request 125614: Enable normal rpath handling on Mac

> On Oct. 12, 2015, 8:48 p.m., René J.V. Bertin wrote: > > There is an issue with Qt 5.5.0's configure script, currently. From what I > > understand, the `-rpath` configure option works as intended, and gives > > relocatable framework bundles that are intended to be embedded in dependent > >

Re: Review Request 125615: Make phonon dependency optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125615/#review86754 --- Ship it! who wants audio notifications anyways? +1 from my

Re: Review Request 125612: Make doctools optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125612/#review86755 --- Ship it! +1 from my side, seems like a nobrainer to me. -

Re: Review Request 125615: Make phonon dependency optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125615/ --- (Updated Oct. 12, 2015, 9:01 p.m.) Status -- This change has been

Re: Review Request 125598: Allow KConfig to use resources as fallback config files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125598/#review86756 --- in principle, I'm cool with that change, but why do you need

Re: Review Request 125598: Allow KConfig to use resources as fallback config files

> On Oct. 12, 2015, 9:02 p.m., Milian Wolff wrote: > > in principle, I'm cool with that change, but why do you need to ship a > > default file anyways? > > > > KConfig is always used in the form > > > > ...read("value", default) > > > > so the defaults are hardcoded there already. Why

Re: Review Request 125612: Make doctools optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125612/ --- (Updated Oct. 12, 2015, 9:07 p.m.) Status -- This change has been

Re: Review Request 125614: Enable normal rpath handling on Mac

> On Oct. 12, 2015, 8:48 p.m., René J.V. Bertin wrote: > > There is an issue with Qt 5.5.0's configure script, currently. From what I > > understand, the `-rpath` configure option works as intended, and gives > > relocatable framework bundles that are intended to be embedded in dependent > >

Review Request 125616: Make doctools + wallet optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125616/ --- Review request for KDE Frameworks and David Faure. Repository: kio

Re: Review Request 125616: Make doctools + wallet optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125616/#review86763 --- People should known what they are missing when building

Re: Review Request 125616: Make doctools + wallet optional

> On Oct. 12, 2015, 10:01 p.m., Albert Astals Cid wrote: > > People should known what they are missing when building without the > > dependencies, please specify so at the summary Yes, that is true, will update the patch tomorrow. - Christoph

Re: Review Request 125615: Make phonon dependency optional

> On Oct. 12, 2015, 10 p.m., Albert Astals Cid wrote: > > CMakeLists.txt, line 65 > > > > > > This should be part of the summary not here were people won't see it You are right, will fix that tomorrow. Will do

Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 51 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/51/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 12 Oct 2015 23:31:05 + Build duration: 49 sec CHANGE SET Revision

Re: Review Request 125615: Make phonon dependency optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125615/#review86762 --- CMakeLists.txt (line 65)

Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 50 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/50/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 12 Oct 2015 22:25:30 + Build duration: 50 sec CHANGE SET Revision

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 98 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/98/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 12 Oct 2015 21:07:39 + Build duration: 2 min 1 sec CHANGE SET Revision

Re: Review Request 125614: Enable normal rpath handling on Mac

> On Oct. 12, 2015, 10:48 p.m., René J.V. Bertin wrote: > > There is an issue with Qt 5.5.0's configure script, currently. From what I > > understand, the `-rpath` configure option works as intended, and gives > > relocatable framework bundles that are intended to be embedded in dependent > >

Re: Review Request 125262: Parse ServiceType files when reading .desktop files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125262/ --- (Updated Oct. 12, 2015, 10:25 p.m.) Status -- This change has been

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 94 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/94/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 12 Oct 2015 21:07:34 + Build duration: 2 min 8 sec CHANGE SET Revision

Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 52 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/52/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 12 Oct 2015 23:36:15 + Build duration: 46 sec CHANGE SET Revision

Re: Review Request 125614: Enable normal rpath handling on Mac

> On Oct. 12, 2015, 8:48 p.m., René J.V. Bertin wrote: > > There is an issue with Qt 5.5.0's configure script, currently. From what I > > understand, the `-rpath` configure option works as intended, and gives > > relocatable framework bundles that are intended to be embedded in dependent > >

Re: Version numbering at download location

Hi David, On 10 Oct 2015, at 15:37 , David Faure wrote: > OK, so we're not talking about the organization of the FTP directories, but > about HTML pages. > That's quite different (a single HTML page could point to multiple FTP > directories, for instance). yep. > Does

Re: Review Request 125614: Enable normal rpath handling on Mac

> On Oct. 12, 2015, 10:48 p.m., René J.V. Bertin wrote: > > There is an issue with Qt 5.5.0's configure script, currently. From what I > > understand, the `-rpath` configure option works as intended, and gives > > relocatable framework bundles that are intended to be embedded in dependent > >

Re: Review Request 125615: Make phonon dependency optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125615/#review86771 --- As a maintainer, I would be much much more happy if it

Re: Review Request 124963: New widget: KNewPasswordWidget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124963/#review86774 --- Ship it! autotests/knewpasswordwidgettest.cpp (line 143)

Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 53 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/53/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 12 Oct 2015 23:43:20 + Build duration: 2 min 23 sec CHANGE SET Revision

Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 53 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/53/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 12 Oct 2015 23:43:20 + Build duration: 2 min 23 sec CHANGE SET Revision

Re: Review Request 125615: Make phonon dependency optional

> On Oct. 13, 2015, 2:26 a.m., Martin Klapetek wrote: > > As a maintainer, I would be much much more happy if it actually had a check > > for win/mac rather than making audio notifications optional always. Also > > speaking as someone who deals with knotifications bug reports. > > Martin

Re: Review Request 125598: Allow KConfig to use resources as fallback config files

> On Oct. 13, 2015, 5:26 a.m., David Faure wrote: > > Is the file test.ini missing from this commit? test.ini is already there, used by an other test. - Christoph --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 125598: Allow KConfig to use resources as fallback config files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125598/#review86775 --- Is the file test.ini missing from this commit?

Re: Review Request 125615: Make phonon dependency optional

> On Oct. 13, 2015, 4:26 a.m., Martin Klapetek wrote: > > As a maintainer, I would be much much more happy if it actually had a check > > for win/mac rather than making audio notifications optional always. Also > > speaking as someone who deals with knotifications bug reports. ...and I'm sure

Re: Review Request 125615: Make phonon dependency optional

> On Oct. 13, 2015, 2:26 a.m., Martin Klapetek wrote: > > As a maintainer, I would be much much more happy if it actually had a check > > for win/mac rather than making audio notifications optional always. Also > > speaking as someone who deals with knotifications bug reports. > > Martin

Re: Review Request 125598: Allow KConfig to use resources as fallback config files

> On Oct. 13, 2015, 5:26 a.m., David Faure wrote: > > autotests/fallbackconfigresourcestest.cpp, line 3 > > > > > > This copyright line doesn't seem to be fully correct, unless I wrote > > this code during my