Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 97 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/97/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 18 Oct 2015 21:06:28 + Build duration: 2 min 4 sec CHANGE SET Revision

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 97 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/97/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 18 Oct 2015 21:06:28 + Build duration: 2 min 4 sec CHANGE SET Revision

Review Request 125695: Make KAboutData::translators/setTranslators simple

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125695/ --- Review request for KDE Frameworks, Chusslove Illich and Michael Pyne.

Re: Review Request 125164: Fix misbehavior when canceling a job

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125164/#review87040 --- bump? - Aleix Pol Gonzalez On Sept. 11, 2015, 3:24 p.m.,

Re: Review Request 125658: Do not treat the context menu button as modifier

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125658/#review87034 --- Ship it! Makes sense to me. - Aleix Pol Gonzalez On Oct.

Re: Review Request 125681: Correctly set the printSetting's parent

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125681/ --- (Updated Oct. 18, 2015, 8:58 p.m.) Review request for KDE Frameworks and

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 101 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/101/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 18 Oct 2015 21:06:28 + Build duration: 1 min 39 sec CHANGE SET Revision

Re: Policy for Dependencies

On Sunday, 18 October 2015 14:45:43 BST David Faure wrote: > On Wednesday 14 October 2015 00:33:17 Christoph Cullmann wrote: > > Lets see what David thinks about all that. > > First: thanks everyone for waiting for my input, I appreciate that (I'm just > one more voice though, no dictatorship

Re: Review Request 125673: Remove KNotifications dep from KParts

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125673/#review86997 --- Ship it! I'm no big fan of notifications myself (I certainly

Re: Review Request 125673: Remove KNotifications dep from KParts

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125673/ --- (Updated Oct. 18, 2015, 8:46 a.m.) Status -- This change has been

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 95 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/95/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 18 Oct 2015 09:44:27 + Build duration: 1 min 51 sec CHANGE SET Revision

Re: Review Request 125679: Fix setTranslator example code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125679/ --- (Updated Oct. 18, 2015, 8:42 a.m.) Status -- This change has been

Re: Policy for Dependencies

Hi, I have now all my patches in frameworks to build some KWrite/Kate application bundle that doesn't instantly crash (and windows builds seem to be nicer, too, without that many problems to locate assets). My last patch missing makes still stuff optional:

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 99 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/99/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 18 Oct 2015 09:44:27 + Build duration: 3 min 53 sec CHANGE SET Revision

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

> On oct. 18, 2015, 6:50 a.m., Thomas Eschenbacher wrote: > > This should work, but IMHO it does not go far enough. I can see many more > > calls to QCoreApplication::translate(...) with user defined content in this > > file (kaboutdata.cpp), which is also affected, as for example credits, >

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125682/#review87000 --- Two more things: * I think this should only be done if

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125682/#review86995 --- This should work, but IMHO it does not go far enough. I can

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125682/#review86998 --- src/kmainwindow.cpp (line 209)

Re: Review Request 125615: Make phonon dependency optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125615/ --- (Updated Oct. 18, 2015, 8:50 a.m.) Status -- This change has been

Re: Review Request 125616: Make doctools + wallet optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125616/#review87004 --- src/kpasswdserver/CMakeLists.txt (line 9)

Re: Review Request 125640: Remove special handling when service is already registered

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125640/#review87013 --- Ship it! Ship It! - David Faure On Oct. 14, 2015, 8:04

Re: Review Request 125621: Missing color initialization in KNewPasswordWidget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125621/#review87015 --- Ship it! Ship It! - David Faure On Oct. 13, 2015, 1:47

Re: Review Request 125616: Make doctools + wallet optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125616/ --- (Updated Oct. 18, 2015, 12:30 p.m.) Status -- This change has been

Re: Review Request 125616: Make doctools + wallet optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125616/ --- (Updated Oct. 18, 2015, 12:30 p.m.) Review request for KDE Frameworks,

Re: Policy for Dependencies

On Wednesday 14 October 2015 00:33:17 Christoph Cullmann wrote: > > Lets see what David thinks about all that. First: thanks everyone for waiting for my input, I appreciate that (I'm just one more voice though, no dictatorship here). The various global switches that have been suggested had

Re: Review Request 125621: Missing color initialization in KNewPasswordWidget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125621/ --- (Updated Oct. 18, 2015, 12:55 p.m.) Status -- This change has been

Re: Review Request 125616: Make doctools + wallet optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125616/ --- (Updated Oct. 18, 2015, 10:43 a.m.) Review request for KDE Frameworks,

Re: Review Request 125616: Make doctools + wallet optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125616/#review87014 --- Ship it! src/kpasswdserver/kpasswdserver.cpp (line 814)

Re: Review Request 125619: Refactor KNewPasswordDialog class

> On Oct. 13, 2015, 1:33 p.m., Aleix Pol Gonzalez wrote: > > File Attachment: knewpassworddialog4.png - knewpassworddialog4.png > > > > > > Shouldn't it have a red background when empty as well? > > Elvis Angelaccio wrote: > I'm

Review Request 125688: Make KNotifications dep in KIO (kpac) optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125688/ --- Review request for KDE Frameworks and David Faure. Repository: kio

Re: Review Request 125616: Make doctools + wallet optional

> On Oct. 18, 2015, 9:49 a.m., David Faure wrote: > > src/kpasswdserver/CMakeLists.txt, line 9 > > > > > > I think it would make more sense to have ifdef HAVE_KWALLET in > > kpasswdserver.cpp, because

Re: Review Request 123376: Fix handling of mod-shift-number shortcuts.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123376/ --- (Updated Okt. 18, 2015, 2:02 nachm.) Status -- This change has been

Re: Review Request 125658: Do not treat the context menu button as modifier

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125658/ --- (Updated Okt. 18, 2015, 2:45 nachm.) Review request for KDE Frameworks,

Re: Review Request 125688: Make KNotifications dep in KIO (kpac) optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125688/#review87025 --- Ship it! Well, I think the notification that your access to

Review Request 125691: KOpenWithDialog: Fix creating desktop file with empty mimetype

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125691/ --- Review request for KDE Frameworks. Repository: kio Description ---

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 96 - Still unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/96/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 18 Oct 2015 18:08:48 + Build duration: 1 min 58 sec CHANGE SET Revision

Re: Review Request 125688: Make KNotifications dep in KIO (kpac) optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125688/ --- (Updated Oct. 18, 2015, 4:59 p.m.) Status -- This change has been

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 100 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/100/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 18 Oct 2015 18:08:48 + Build duration: 4 min 29 sec CHANGE SET Revision

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 100 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/100/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 18 Oct 2015 18:08:48 + Build duration: 4 min 29 sec CHANGE SET Revision