Re: Review Request 126047: Don't add extra KDE SNI actions in our systemtray qpt plugin

2015-11-13 Thread David Edmundson
> On Nov. 13, 2015, 6:59 a.m., Martin Gräßlin wrote: > > shouldn't we just delete the code? Qt nowadays does SNI and if not we have > > the xembed-sni-proxy. Thoughts on that? Maybe bound to the Qt version which > > introduced the SNI support? Could do. I've not tried Qt's version of SNI

Re: Review Request 126054: Missed doctool usage.

2015-11-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126054/#review88330 --- Ship it! Ship It! - Aleix Pol Gonzalez On nov. 13, 2015,

Re: KGlobalAccel on ~Linux?

2015-11-13 Thread Martin Graesslin
On Friday, November 13, 2015 5:24:51 PM CET René J.V. Bertin wrote: > Hi, > > KDE4's kglobalaccel works just fine on Mac OS X; is there a reason why the > KF5 wouldn't? because nobody ported it to Qt's new native event filter. I would love to see this enabled again for the non Linux platforms.

Re: KGlobalAccel on ~Linux?

2015-11-13 Thread Martin Graesslin
On Friday, November 13, 2015 5:54:01 PM CET René J. V. Bertin wrote: > Martin Graesslin wrote: > > because nobody ported it to Qt's new native event filter. I would love to > > see this enabled again for the non Linux platforms. > > Hmm, I see. That's something I should look into then, if I find

KGlobalAccel on ~Linux?

2015-11-13 Thread René J . V . Bertin
Hi, KDE4's kglobalaccel works just fine on Mac OS X; is there a reason why the KF5 wouldn't? R. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

kxmlgui: klanguageoverridesrc format

2015-11-13 Thread René J . V . Bertin
Hi, KXmlGui currently uses QSettings in NativeFormat to write klanguageoverridesrc . On OS X, that means it will become a binary XML file called klanguageoverridesrc.plist, which I personally find undesirable. I think that the effect is even larger on MS Windows. On Linux, NativeFormat and

Re: KGlobalAccel on ~Linux?

2015-11-13 Thread René J . V . Bertin
Martin Graesslin wrote: > Well it could also mean that kglobalaccel5 directly crashes because it doesn't > have a backend and we just don't see the backtrace due to missing drkonqi. Running under a debugger should show if it crashes, before kcrash gets a chance to call drkonqi, no? Drkonqi is

Re: Review Request 126054: Missed doctool usage.

2015-11-13 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126054/ --- (Updated Nov. 13, 2015, 4:54 p.m.) Status -- This change has been

Re: KGlobalAccel on ~Linux?

2015-11-13 Thread René J . V . Bertin
Martin Graesslin wrote: > because nobody ported it to Qt's new native event filter. I would love to see > this enabled again for the non Linux platforms. Hmm, I see. That's something I should look into then, if I find its functionality is indeed lacking. I know kglobalaccel4 works and gets

Review Request 126056: Use KDE_INSTALL_FULL_ICONDIR to install the icons

2015-11-13 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126056/ --- Review request for KDE Frameworks and Uri Herrera. Repository:

Re: Review Request 126057: Use KDE_INSTALL_FULL_ICONDIR to install the icons

2015-11-13 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126057/#review88340 --- Ship it! KDEInstallDirs will take care of keeping

Re: Review Request 126058: Add .reviewboardrc

2015-11-13 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126058/#review88338 --- Ship it! Ship It! - Alex Merry On Nov. 13, 2015, 6:08

Re: kxmlgui: klanguageoverridesrc format

2015-11-13 Thread David Faure
On Friday 13 November 2015 18:18:21 René J. V. Bertin wrote: > Hi, > > KXmlGui currently uses QSettings in NativeFormat to write > klanguageoverridesrc . > On OS X, that means it will become a binary XML file called > klanguageoverridesrc.plist, which I personally find undesirable. I think

Re: KGlobalAccel on ~Linux?

2015-11-13 Thread David Faure
On Friday 13 November 2015 22:04:35 René J. V. Bertin wrote: > I can imagine that the session dbus doesn't look in /opt/local by default on > Linux (guess I'll have to look into that) Right. Add /opt/local/share to XDG_DATA_DIRS before starting the DBus daemon, otherwise the dbus service cannot

Re: kxmlgui: klanguageoverridesrc format

2015-11-13 Thread René J . V . Bertin
On Friday November 13 2015 22:10:07 David Faure wrote: > Kévin wrote this code in ed10e3fd484570, the main point was to switch from > KConfig to QSettings > for this particular setting. NativeFormat is clearly just an accident there, > feel free to change it. I hope that meant OK to commit -

Re: Review Request 126056: Use KDE_INSTALL_FULL_ICONDIR to install the icons

2015-11-13 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126056/#review88339 --- Ship it! This could do with more work than just this - a

Prunning KDeclarative dependencies

2015-11-13 Thread Aleix Pol
Hi, I've been thinking about looking into pushing Purpose as a framework. One of its dependencies is KDeclarative, which means all of the things. In this case KDeclarative is used for the i18n() integration. I think this is especially bad because it raises the Qt Quick adoption barrier quite a bit

Re: Review Request 126047: Don't add extra KDE SNI actions in our systemtray qpt plugin

2015-11-13 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126047/#review88327 --- Ship it! Ship It! - Martin Gräßlin On Nov. 12, 2015, 8:24