Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

2015-12-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123229/#review89297 --- OK, at least it makes more sense to me now. We register at

Re: Review Request 126295: Fix wrong button in KUrlNavigator issue caused by 9dbe36f734b5b839b2a6a934fad29d639e954498

2015-12-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126295/#review89295 --- src/filewidgets/fix-url-navigator.patch (line 1)

Re: Moving KWayland to frameworks

2015-12-10 Thread Martin Graesslin
On Thursday, December 10, 2015 1:07:42 PM CET Boudhayan Gupta wrote: > On 10 December 2015 at 12:32, Martin Graesslin wrote: > > yes, that's the annoying one which is lots of work and lots of possible > > regressions. I'm not sure whether I'm willing to do that work which I >

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-10 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126308/#review89321 --- 1. What tells you that this is a dialog buttonbox pushbutton?

Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-10 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126308/ --- Review request for KDE Software on Mac OS X, KDE Frameworks and Qt KDE.

Review Request 126309: backtrace and demangle for OS X, FreeBSD and Solaris/OpenIndiana

2015-12-10 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126309/ --- Review request for KDE Software on Mac OS X and KDE Frameworks.

Re: Review Request 126039: When configfile is loaded from resource, do not issue file not found error

2015-12-10 Thread Andrew McCann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126039/ --- (Updated Dec. 10, 2015, 8:32 p.m.) Status -- This change has been

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-10 Thread René J . V . Bertin
> On Dec. 10, 2015, 11:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogButtonBoxPrivate::createButton() seems to

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-10 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126308/ --- (Updated Dec. 10, 2015, 11:54 p.m.) Review request for KDE Software on

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-10 Thread Thomas Lübking
> On Dec. 10, 2015, 10:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogButtonBoxPrivate::createButton() seems to

Re: Icons missing

2015-12-10 Thread Jaroslaw Staniek
On 6 December 2015 at 13:56, Thorsten Zachmann wrote: > Hello all, > > I use a separate user for running calligra. I use ssh -X to login from my > normal desktop user to my kde running user. However when I start any > kde application I have no icons. With strace I can see it

Re: Moving KWayland to frameworks

2015-12-10 Thread Kevin Ottens
On Thursday 10 December 2015 12:43:29 Martin Graesslin wrote: > On Thursday, December 10, 2015 12:24:06 PM CET Kevin Ottens wrote: > > > As I just said: I consider this as a useless exercise and a waste of my > > > time (and of anybody else who would do that). > > > > Note that it's a waste of

Re: Icons missing on ssh -X, or: no real system default for icon theme

2015-12-10 Thread Jaroslaw Staniek
On 10 December 2015 at 16:38, Friedrich W. H. Kossebau wrote: > Am Sonntag, 6. Dezember 2015, 23:39:13 schrieb Albert Astals Cid: > > El Sunday 06 December 2015, a les 13:56:19, Thorsten Zachmann va > escriure: > > > Hello all, > > > > > > I use a separate user for running

Review Request 126304: (re)enable building with -DQTC_QT5_ENABLE_KDE

2015-12-10 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126304/ --- Review request for KDE Frameworks, Qt KDE and Yichao Yu. Repository:

Re: RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

2015-12-10 Thread Mark Gaiser
On Thu, Dec 10, 2015 at 10:20 AM, Martin Graesslin wrote: > On Thursday, December 10, 2015 9:54:15 AM CET Mark Gaiser wrote: > > On Thu, Dec 10, 2015 at 8:07 AM, Martin Graesslin > > > > wrote: > > > On Wednesday, December 9, 2015 4:03:24 PM CET Aleix Pol

Re: RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

2015-12-10 Thread Kai Uwe Broulik
Hi,Mark, I think you completely misunderstood what move to kde/workspace means. This is not a repository, nobody wants to move that stuff into plasma-workspace. It just has semantic relevance, ie. no frameworks

Re: RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

2015-12-10 Thread Martin Graesslin
On Thursday, December 10, 2015 2:39:36 PM CET Mark Gaiser wrote: > > That is why I don't get your point. It just doesn't make sense to me and > > it > > sounds being based on wrong assumptions. > > Yes, it will. Here is the proof (taking archlinux as example since it is > very much like upstream

Re: Review Request 126246: Add test for dynamically changing file definitions

2015-12-10 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126246/#review89314 --- +1 I don't know this package, but the change "looks ok" to

Re: Review Request 126246: Add test for dynamically changing file definitions

2015-12-10 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126246/#review89312 --- ping? - Marco Martin On Dec. 4, 2015, 6:23 p.m., Marco

Re: Icons missing on ssh -X, or: no real system default for icon theme

2015-12-10 Thread Friedrich W. H. Kossebau
Am Sonntag, 6. Dezember 2015, 23:39:13 schrieb Albert Astals Cid: > El Sunday 06 December 2015, a les 13:56:19, Thorsten Zachmann va escriure: > > Hello all, > > > > I use a separate user for running calligra. I use ssh -X to login from my > > normal desktop user to my kde running user. However