Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 14, 2015, 7:53 a.m., Martin Gräßlin wrote: > > src/gui/CMakeLists.txt, line 2 > > > > > > this introduces a QtWidgets dependency and thus changes the integration > > level of the framework. I highly

Re: Review Request 126295: Fix wrong button in KUrlNavigator issue caused by 9dbe36f734b5b839b2a6a934fad29d639e954498

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126295/ --- (Updated Dec. 14, 2015, 11:31 a.m.) Status -- This change has been

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 14, 2015, 12:23 p.m., Martin Gräßlin wrote: > > src/gui/CMakeLists.txt, line 2 > > > > > > this introduces a QtWidgets dependency and thus changes the integration > > level of the framework. I highly

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On Dec. 14, 2015, 7:56 a.m., Martin Gräßlin wrote: > > src/platformtheme/kdeplatformtheme.cpp, line 45 > > > > > > this looks like a not needed debug statement, same in dtor and > > loadSettings and

Re: Review Request 126312: Add xcb variant for static KStartupInfo::sendFoo methods

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126312/ --- (Updated Dec. 14, 2015, 9:55 a.m.) Status -- This change has been

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,NoX11,gcc - Build # 51 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/51/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 14 Dec 2015 10:03:21 + Build duration: 1 min 28 sec CHANGE SET Revision

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 46 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/46/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 14 Dec 2015 09:55:46 + Build duration: 1 min 3 sec CHANGE SET

Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126320/#review89458 --- Ship it! src/plasma/scripting/scriptengine.cpp (line 89)

Re: Review Request 126339: remove kdewin dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126339/ --- (Updated Dez. 14, 2015, 10:37 vorm.) Review request for KDE Frameworks

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 14, 2015, 12:23 p.m., Martin Gräßlin wrote: > > src/gui/CMakeLists.txt, line 2 > > > > > > this introduces a QtWidgets dependency and thus changes the integration > > level of the framework. I highly

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,NoX11,gcc - Build # 50 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/50/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 14 Dec 2015 09:55:46 + Build duration: 1 min 6 sec CHANGE SET Revision

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,NoX11,gcc - Build # 51 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/51/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 14 Dec 2015 10:03:21 + Build duration: 1 min 28 sec CHANGE SET Revision

Review Request 126343: KPluginMetaData: Add fields used by KAboutData and introduce conversion function

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126343/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126320/#review89452 --- Ship it! Ship It! - Marco Martin On Dec. 11, 2015, 6:48

Re: Review Request 126329: kio: Do not use QStringLiteral with multi strings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126329/ --- (Updated Dec. 14, 2015, 9:43 a.m.) Status -- This change has been

Re: Review Request 126339: remove kdewin dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126339/#review89464 --- Ship it! Looks good to me - Alex Richardson On Dec. 14,

Re: kdeinit freezes on Wayland in OOM protection

On Friday, November 27, 2015 1:05:26 PM CET Michael Pyne wrote: > On Thu, November 26, 2015 13:16:04 Martin Graesslin wrote: > > we are facing a problem during the startup of Plasma on Wayland. If OOM > > protection is enabled for kdeinit and we already have a running X server, > > kdeinit freezes

Re: RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

On Monday, December 14, 2015 2:40:16 PM CET Mark Gaiser wrote: > On Mon, Dec 14, 2015 at 1:37 PM, Marco Martin wrote: > > On Thursday 10 December 2015, Mark Gaiser wrote: > > > It's not just a barrier in my head. It's a waste of resources if one > > > package that doesn't need

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126324/ --- (Updated Dec. 14, 2015, 5:04 p.m.) Review request for KDE Software on

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

> On Gru 14, 2015, 8:10 po południu, Sergio Martins wrote: > > src/klocalizedstring.cpp, line 389 > > > > > > this will break the build with MSVC, it doesn't support QStringLiteral > > with multi-line literals.

Re: kdeinit freezes on Wayland in OOM protection

Am 2015-12-15 03:20, schrieb Michael Pyne: On Mon, December 14, 2015 16:07:38 Martin Graesslin wrote: On Friday, November 27, 2015 1:05:26 PM CET Michael Pyne wrote: > On Thu, November 26, 2015 13:16:04 Martin Graesslin wrote: > > we are facing a problem during the startup of Plasma on Wayland.

Re: Review Request 126343: KPluginMetaData: Add fields used by KAboutData and introduce conversion function

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126343/#review89472 --- Looks good to me, though I wouldn't mind another reviewer.

Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126320/ --- (Updated Dec. 14, 2015, 2:05 p.m.) Status -- This change has been

Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

> On Dec. 14, 2015, 11:36 a.m., Alex Richardson wrote: > > src/plasma/scripting/scriptengine.cpp, line 67 > > > > > > This should probably also be changed to QStringList? Yes. - Martin

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On Dec. 14, 2015, 7:56 a.m., Martin Gräßlin wrote: > > src/platformtheme/kdeplatformtheme.cpp, line 45 > > > > > > this looks like a not needed debug statement, same in dtor and > > loadSettings and

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 14, 2015, 12:47 p.m., Marco Martin wrote: > > src/gui/CMakeLists.txt, line 22 > > > > > > we really can't add a dependency to QWidgets here. > > depending on qwidgets will make many potential

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 14, 2015, 5:17 p.m., Marco Martin wrote: > > src/gui/CMakeLists.txt, line 22 > > > > > > we really can't add a dependency to QWidgets here. > > depending on qwidgets will make many potential

Re: Review Request 126343: KPluginMetaData: Add fields used by KAboutData and introduce conversion function

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126343/#review89480 --- Just a few nitpicks. Rest looks good to me.

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 14, 2015, 5:17 p.m., Marco Martin wrote: > > src/gui/CMakeLists.txt, line 22 > > > > > > we really can't add a dependency to QWidgets here. > > depending on qwidgets will make many potential

Re: RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

On Mon, Dec 14, 2015 at 1:37 PM, Marco Martin wrote: > On Thursday 10 December 2015, Mark Gaiser wrote: > > It's not just a barrier in my head. It's a waste of resources if one > > package that doesn't need a dozen dependencies, pulls it in because > someone > > decided it

Review Request 126348: Make it possible to provide the metadata in json

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126348/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage

Re: Purpose as a KDE Framework

On Mon, Dec 7, 2015 at 12:49 PM, Marco Martin wrote: > On Thursday 03 December 2015, Aleix Pol wrote: >> > but i don't think scripted plugins can be added as an aftertought as the >> > structure of the framework may be influenced by that (yeah, i know, >> > dependencies, but my

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 65 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/65/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 14 Dec 2015 21:37:04 + Build duration: 10 sec CHANGE SET No changes

Re: Review Request 126348: Make it possible to provide the metadata in json

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126348/#review89499 --- src/kpackage/package.cpp (line 447)

Review Request 126339: remove kdewin dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126339/ --- Review request for KDE Frameworks, David Faure and Martin Tobias Holmedahl

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 14, 2015, 7:53 a.m., Martin Gräßlin wrote: > > src/gui/CMakeLists.txt, line 2 > > > > > > this introduces a QtWidgets dependency and thus changes the integration > > level of the framework. I highly

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 47 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/47/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 14 Dec 2015 10:03:21 + Build duration: 21 sec CHANGE SET Revision

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 47 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/47/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 14 Dec 2015 10:03:21 + Build duration: 21 sec CHANGE SET Revision

Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126320/#review89459 --- src/plasma/scripting/scriptengine.cpp (line 67)

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126350/#review89492 --- src/klocalizedstring.cpp (line 389)

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126350/ --- (Updated Dec. 14, 2015, 7:37 p.m.) Review request for KDE Frameworks and

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

> On Dec. 14, 2015, 7:38 p.m., Aleix Pol Gonzalez wrote: > > I ran the tests locally and I can confirm that clazy warnings are gone and > > all tests still pass. +1, waiting for maintainer approval. - Aleix --- This is an

Re: Review Request 126348: Make it possible to provide the metadata in json

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126348/#review89482 --- Can't really comment on KPackage internals, but looks good to

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126350/#review89488 --- I ran the tests locally and I can confirm that clazy warnings

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126350/ --- (Updated Gru 14, 2015, 7:46 po południu) Status -- This change has

Re: Review Request 126312: Add xcb variant for static KStartupInfo::sendFoo methods

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126312/#review89451 --- Ship it! Ship It! - David Faure On Dec. 14, 2015, 7:08

Re: Review Request 126348: Make it possible to provide the metadata in json

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126348/#review89504 --- src/kpackage/private/packages.cpp (line 57)

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

> On Dec. 14, 2015, 7:10 p.m., Sergio Martins wrote: > > src/klocalizedstring.cpp, line 389 > > > > > > this will break the build with MSVC, it doesn't support QStringLiteral > > with multi-line literals. > >

Re: system tray test?

Sebastian Kügler wrote: >> >> I'd suggest replacing the line above with a sequence "m->addAction, m- >> >> >addSeparator" on OS X, or do you have other suggestions? > > Seems to make sense to me. Could you file a review request for this? Ok, will put that on my todo list :) Cheers, R.

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 64 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/64/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 14 Dec 2015 21:14:23 + Build duration: 11 sec CHANGE SET No changes

Jenkins-kde-ci: kdeclarative master stable-kf5-qt5 » Linux,gcc - Build # 65 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdeclarative%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/65/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 14 Dec 2015 21:14:23 + Build duration: 10 sec CHANGE SET No changes

Re: Review Request 126167: Expose QMimeType comment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126167/ --- (Updated Dec. 14, 2015, 9:13 p.m.) Status -- This change has been