Review Request 126397: [xcb] Safety check whether we have a QApplication in mapViewport

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126397/ --- Review request for KDE Frameworks, kwin and Albert Astals Cid. Bugs:

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 10, 2015, 11:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogButtonBoxPrivate::createButton() seems to

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. > > Marco Martin wrote: > I'm not sure what the

Re: Review Request 126397: [xcb] Safety check whether we have a QApplication in mapViewport

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126397/ --- (Updated Dec. 17, 2015, 10:21 a.m.) Review request for KDE Frameworks,

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/#review89652 --- Well, it isn't exactly easy, but I remembered that KMail can

Re: Review Request 126400: [GCI] Fix some Clazy warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126400/#review89654 --- src/kconfig_compiler/kconfig_compiler.cpp (line 1265)

Re: Review Request 126400: [GCI] Fix some Clazy warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126400/ --- (Updated Дек. 17, 2015, 9 п.п.) Review request for KDE Frameworks.

Re: Review Request 126397: [xcb] Safety check whether we have a QApplication in mapViewport

> On Dec. 17, 2015, 1:55 p.m., Thomas Lübking wrote: > > Looks like this boils down to multiple qApp->desktop()->size() calls, ie. > > displayWidth/displayHeight in kwinglobals.h, right? > > > > We could just "borrow" that code and kick the qApp dep then? > > Thomas Lübking wrote: > Ok,

Re: Review Request 126397: [xcb] Safety check whether we have a QApplication in mapViewport

> On Dec. 17, 2015, 12:55 p.m., Thomas Lübking wrote: > > Looks like this boils down to multiple qApp->desktop()->size() calls, ie. > > displayWidth/displayHeight in kwinglobals.h, right? > > > > We could just "borrow" that code and kick the qApp dep then? Ok, further check - there's another,

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated Dec. 17, 2015, 3 p.m.) Review request for KDE Software on Mac

Review Request 126400: [GCI] Fix some Clazy warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126400/ --- Review request for KDE Frameworks. Repository: kconfig Description

Re: Review Request 126397: [xcb] Safety check whether we have a QApplication in mapViewport

> On Dec. 17, 2015, 12:55 p.m., Thomas Lübking wrote: > > Looks like this boils down to multiple qApp->desktop()->size() calls, ie. > > displayWidth/displayHeight in kwinglobals.h, right? > > > > We could just "borrow" that code and kick the qApp dep then? > > Thomas Lübking wrote: > Ok,

Re: Review Request 126397: [xcb] Safety check whether we have a QApplication in mapViewport

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126397/#review89648 --- Looks like this boils down to multiple

Re: Review Request 126400: [GCI] Fix some Clazy warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126400/#review89657 --- Looks good to me, waiting for the maintainer to approve.

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 11, 2015, 1:55 p.m., Thomas Lübking wrote: > > src/kdeui/kdialogbuttonbox.cpp, line 39 > > > > > > QDialogButtonBox::addButton should do correctly anyway, so please don't > > workaround things that are

Re: Review Request 126397: [xcb] Safety check whether we have a QApplication in mapViewport

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126397/#review89663 --- src/platforms/xcb/kwindowsystem.cpp (line 355)

Re: Review Request 126397: [xcb] Safety check whether we have a QApplication in mapViewport

> On Dec. 17, 2015, 12:55 p.m., Thomas Lübking wrote: > > Looks like this boils down to multiple qApp->desktop()->size() calls, ie. > > displayWidth/displayHeight in kwinglobals.h, right? > > > > We could just "borrow" that code and kick the qApp dep then? > > Thomas Lübking wrote: > Ok,

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126324/#review89665 --- src/gui/kwindowconfig.h (lines 38 - 39)

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated Dec. 17, 2015, 5:26 p.m.) Review request for KDE Software on

Re: Draft split for qpt plugin from frameworkintegration

On Thursday, December 17, 2015 4:32:48 PM CET Aleix Pol wrote: > On Wed, Dec 16, 2015 at 4:12 PM, Martin Graesslin wrote: > > Hi all, > > > > following up on [1] I have prepared a split of frameworkintegration to > > move > > the QPT plugin into a dedicated repository. You

Re: Draft split for qpt plugin from frameworkintegration

On Wed, Dec 16, 2015 at 4:12 PM, Martin Graesslin wrote: > Hi all, > > following up on [1] I have prepared a split of frameworkintegration to move > the QPT plugin into a dedicated repository. You can find it in [2]. Please > have > a look at the split repo to verify that it

Re: Draft split for qpt plugin from frameworkintegration

forgot CC to plasma On Thursday, December 17, 2015 4:32:48 PM CET Aleix Pol wrote: > On Wed, Dec 16, 2015 at 4:12 PM, Martin Graesslin wrote: > > Hi all, > > > > following up on [1] I have prepared a split of frameworkintegration to > > move > > the QPT plugin into a

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. > > Marco Martin wrote: > I'm not sure what the

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89671 --- tests/CMakeLists.txt (line 43)

Re: lib/x86_64-linux-gnu/libKF5FileMetaData.so | lib/libKF5FileMetaData.3.dylib

On Thursday 17 of December 2015 12:51:42 René J. V. Bertin wrote: > šumski wrote: > >> Yes, bug fixes can do that ;) > > > > Yes, but frameworks are under BC guarantee. > > So how are bugs supposed to be fixed if they break ABI compatibility? Certainly not by breaking one of core policies. >

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Dec. 17, 2015, 7:40 p.m.) Review request for KDE Software on

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > > > > > That doesn't match the method name. It's saveWindowSize, not > > saveWindowGeometry. It's highly

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > > > > > That doesn't match the method name. It's saveWindowSize, not > > saveWindowGeometry. It's highly

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 11, 2015, 2:55 p.m., Thomas Lübking wrote: > > > > René J.V. Bertin wrote: > For the record: I've raised a few interrogations that are preventing me > from following up and addressing the open issues raised by Thomas. I'm stepping out, patching icons out of buttons elsewhere but

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/#review89684 --- I still want to see other OSX devs comment on that this is

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > > > > > That doesn't match the method name. It's saveWindowSize, not > > saveWindowGeometry. It's highly

Review Request 126392: Fix some Clazy warnings in kcoreaddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126392/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository:

Re: Review Request 126409: Fix use-after-free in .desktop file parser

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126409/ --- (Updated Dec. 18, 2015, 3:44 a.m.) Review request for KDE Frameworks and

Re: Review Request 126409: Fix use-after-free in .desktop file parser

> On Dec. 18, 2015, 3:17 a.m., Alex Richardson wrote: > > src/lib/plugin/desktopfileparser.cpp, line 346 > > > > > > `defs << *def // This must...` instead? And then the `defs << *def` in > > the else block?

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/ --- (Updated Dec. 17, 2015, 11:15 a.m.) Review request for Build System, KDE

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. > > Marco Martin wrote: > I'm not sure what the

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated Dec. 17, 2015, 12:40 p.m.) Review request for KDE Software on

Re: lib/x86_64-linux-gnu/libKF5FileMetaData.so | lib/libKF5FileMetaData.3.dylib

šumski wrote: >> Yes, bug fixes can do that ;) > Yes, but frameworks are under BC guarantee. So how are bugs supposed to be fixed if they break ABI compatibility? If I'm not mistaken Linux will not check beyond shared library file names. If that's correct, the build system can install a

Review Request 126410: Fix FILE* leak in kwalletd

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126410/ --- Review request for KDE Frameworks, Martin Klapetek and Valentin Rusu.