Re: Review Request 126506: Fix improper destruction of non-virtual KDirModel subclasses

> On Dec. 25, 2015, 1:58 a.m., Aleix Pol Gonzalez wrote: > > If making the destructor virtual doesn't break ABI, I'd vote for that... The node classes are internal, so this wouldn't break ABI indeed. Hmm, right, this would make "delete node" work everywhere. Michael's fix misses the other

Re: Review Request 126506: Fix improper destruction of non-virtual KDirModel subclasses

> On Dec. 25, 2015, 9:14 a.m., David Faure wrote: > > Ship It! withdrawn, see above - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126506/#review90085

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 4:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > > > > > That doesn't match the method name. It's saveWindowSize, not > > saveWindowGeometry. It's highly

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > > > Jaime Torres Amate wrote: > Hello, > > This is just a warning to know if this patch has been tested in a two > monitor environment in a laptop. > In a pyqt application I save and restore the size and position of

Review Request 126516: Add StatusNotifier flag

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126516/ --- Review request for KDE Frameworks. Repository: kcrash Description

Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126515/ --- Review request for KDE Frameworks, Plasma, KDE Usability, and Martin

Re: klauncher & .desktop Execs

On Friday December 25 2015 09:57:05 David Faure wrote: > On Tuesday 22 December 2015 11:33:53 René J.V. Bertin Bouncing this to the list. > > Looking at `ps` output klauncher shows up as kcmshell5's parent process, > > does that mean we're looking at KLauncher::requestStart using > >

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > src/gui/kwindowconfig.h, lines 38-39 > > > > > > That doesn't match the method name. It's saveWindowSize, not > > saveWindowGeometry. It's highly

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126515/#review90100 --- Usability: I envisioned this to be used for auto-restarting

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 5:16 p.m., Martin Gräßlin wrote: > > > > Jaime Torres Amate wrote: > Hello, > > This is just a warning to know if this patch has been tested in a two > monitor environment in a laptop. > In a pyqt application I save and restore the size and position of

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126515/#review90104 --- code looks fine. Though please do the TODOs before merging

Re: klauncher & .desktop Execs

On Friday December 25 2015 18:03:47 René J.V. Bertin wrote: >So what I'd like to do as a last test is this: >- leave the mechanism by which klauncher is started alone, as well as a few >others (to be defined) >- for everything else, use the fact that /usr/bin/open will spawn in the >background,

Re: Review Request 126161: OS X housekeeping

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126161/#review90098 --- src/kdeinit/kinit_mac.mm (lines 662 - 666)

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

> On Dez. 25, 2015, 5:31 nachm., David Edmundson wrote: > > code looks fine. > > > > Though please do the TODOs before merging as historically we have a have a > > habbit of them not getting done > > Also your StatusNotifierItem leaks - but it proably wants to be the > > lifespan of the

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 4:16 p.m., Martin Gräßlin wrote: > > Hello, This is just a warning to know if this patch has been tested in a two monitor environment in a laptop. In a pyqt application I save and restore the size and position of the window (without additional checks), using:

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

> On Dec. 17, 2015, 4:16 p.m., Martin Gräßlin wrote: > > > > Jaime Torres Amate wrote: > Hello, > > This is just a warning to know if this patch has been tested in a two > monitor environment in a laptop. > In a pyqt application I save and restore the size and position of

Re: klauncher & .desktop Execs

On Friday December 25 2015 12:34:08 René J.V. Bertin wrote: > With the proper changes (still assessing them) that should work on OS X too, > no? With the USE_KPROCESS_FOR_KIOSLAVES/QProcess::start I had to jump to a > number of hoops and resort to calling the commandline AppleScript interpreter

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

> On Dec. 2, 2015, 8:51 a.m., David Faure wrote: > > Please kind in mind that kded must be able to pop up dialogs, though. > > (cookie dialog, SSL cert messagebox + dialog, etc. etc.). > > > > If making it an "agent" doesn't prevent it from showing GUI elements now > > and then, then no

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126170/ --- (Updated Dec. 25, 2015, 10:14 p.m.) Review request for KDE Software on