Review Request 126620: Fixed most of level 1 and level 2 warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126620/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository:

Re: Review Request 126620: Fixed most of level 1 and level 2 warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126620/#review90515 --- I'm not sure `clazy-old-style-connect` changes can apply. Is

Re: Review Request 126587: Add option to build with gcov support

> On Jan. 2, 2016, 12:56 a.m., Aleix Pol Gonzalez wrote: > > That's provided by ecm, isn't it? > > Dāvis Mosāns wrote: > I don't know... I based this on KWin > https://quickgit.kde.org/?p=kwin.git=blob=master=CMakeLists.txt#l249 the check in KWin predates the one in ecm and as Aleix says:

Re: RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

On Thursday, December 24, 2015 12:16:13 PM CET Simon Lees wrote: > Hi All, > > Sorry for double posting, but after chatting with someone on IRC we > discovered that exporting QT_QPA_PLATFORMTHEME=kde or > QT_QPA_PLATFORMTHEME=gtk2 fixes the issue. For now I can just patch > enlightenment to

Re: Review Request 126595: [KFileMetaData] Allow querying for a file's origin URL

> On Jan. 2, 2016, 10:59 a.m., David Edmundson wrote: > > src/properties.h, line 215 > > > > > > adding an enum value in the middle breaks API > > Kai Uwe Broulik wrote: > where can I place it? the last

Re: Review Request 126472: Don't always load the timetracker

> On Dec. 22, 2015, 3:36 p.m., Sebastian Kügler wrote: > > Nice. > > > > I agree with Aleix that the env var would be good to have documented. (Is > > that even English?) But then, where? as an idea check: https://community.kde.org/KWin/Environment_Variables - Martin

Re: Review Request 126403: Get rid of QApplication dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126403/#review90522 --- anyone tested this on an "affected system"? - Martin Gräßlin

Re: closest equivalent to KApplicationPrivate::init() ?

On Sunday January 03 2016 10:22:27 David Faure wrote: >> You saw I said "wait for QProcess to be improved", right? I don't expect a >> patch for QProcess to be incorporated before 5.7.x ... > >Patience is a virtue :-) Oh indeed it is ... and getting a [real] life waiting for something this

Re: closest equivalent to KApplicationPrivate::init() ?

On Saturday 02 January 2016 19:00:48 René J.V. Bertin wrote: > > I very much disagree with this approach. Qt is opensource, if there's > > something to be fixed in QProcess, make a patch, > > then it won't be hypothetical. I don't see "starting a GUI application" as > > a KF5-specific need at

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126618/#review90496 --- According to the documentation AppLocalDataLocation is the

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

> On Jan. 3, 2016, 3:22 p.m., Alex Richardson wrote: > > According to the documentation AppLocalDataLocation is the following: > > "C:/Users//AppData/Local/", "C:/ProgramData/", > > "", "/data" > > > > In which directory are the desktop files? Unfortunately I can't check as my > > Windows

Re: test failures on http://ci-logs.kde.flaska.net

And indeed the value of XDG_DATA_DIRS in http://ci-logs.kde.flaska.net/7f/7f50569d59eabc20897f54fb97483bd7f8b89d63/rebuilddep/rebuilddep-kf5-qt55-clang-el7/3cef5be/shell_output.log is long and messy and has /usr/share in front (so it's viewed as being "on top of" the kde mimetype file, while

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

> On Jan. 3, 2016, 3:22 nachm., Alex Richardson wrote: > > According to the documentation AppLocalDataLocation is the following: > > "C:/Users//AppData/Local/", "C:/ProgramData/", > > "", "/data" > > > > In which directory are the desktop files? Unfortunately I can't check as my > > Windows

Review Request 126615: Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126615/ --- Review request for KDE Frameworks. Repository: knewstuff Description

Re: Review Request 126615: (knewstuff) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126615/ --- (Updated Jan. 3, 2016, 12:46 p.m.) Review request for KDE Frameworks.

Review Request 126616: (ktextwidgets) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126616/ --- Review request for KDE Frameworks. Repository: ktextwidgets

Re: Review Request 126615: (knewstuff) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126615/#review90492 --- Ship it! Ship It! - Kevin Funk On Jan. 3, 2016, 12:51

Re: Review Request 126616: (ktextwidgets) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126616/#review90491 --- Ship it! Ship It! - Kevin Funk On Jan. 3, 2016, 12:53

Re: Review Request 126614: (Ki18n) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126614/#review90493 --- Ship it! Ship It! - Kevin Funk On Jan. 3, 2016, 12:45

Review Request 126614: Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126614/ --- Review request for KDE Frameworks. Repository: ki18n Description

Re: Review Request 126614: (Ki18n) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126614/ --- (Updated Jan. 3, 2016, 12:45 p.m.) Review request for KDE Frameworks.

Re: Review Request 126615: (knewstuff) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126615/ --- (Updated Jan. 3, 2016, 12:51 p.m.) Review request for KDE Frameworks.

Review Request 126617: (kxmlgui) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126617/ --- Review request for KDE Frameworks. Repository: kxmlgui Description

Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126618/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: Review Request 126617: (kxmlgui) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126617/#review90490 --- Ship it! Ship It! - Kevin Funk On Jan. 3, 2016, 12:57

Re: Review Request 126614: (Ki18n) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126614/ --- (Updated Jan. 3, 2016, 6:04 p.m.) Status -- This change has been

Re: Review Request 126615: (knewstuff) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126615/ --- (Updated Jan. 3, 2016, 6:10 p.m.) Status -- This change has been

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

> On Jan. 3, 2016, 3:22 p.m., Alex Richardson wrote: > > According to the documentation AppLocalDataLocation is the following: > > "C:/Users//AppData/Local/", "C:/ProgramData/", > > "", "/data" > > > > In which directory are the desktop files? Unfortunately I can't check as my > > Windows

Re: Review Request 126616: (ktextwidgets) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126616/ --- (Updated Jan. 3, 2016, 6:18 p.m.) Status -- This change has been

Re: Review Request 125869: Allows protocoltojson & kio to handle translated json ExtraNames

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125869/ --- (Updated Jan. 3, 2016, 6:19 p.m.) Review request for KDE Frameworks,

Re: Review Request 126617: (kxmlgui) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126617/ --- (Updated Jan. 3, 2016, 6:45 p.m.) Status -- This change has been

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

> On Jan. 3, 2016, 3:22 p.m., Alex Richardson wrote: > > According to the documentation AppLocalDataLocation is the following: > > "C:/Users//AppData/Local/", "C:/ProgramData/", > > "", "/data" > > > > In which directory are the desktop files? Unfortunately I can't check as my > > Windows

Re: Review Request 126614: (Ki18n) Fix compilation: QStringLiteral and multistring parameter do not mix on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126614/#review90504 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 3, 2016,

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

> On Jan. 3, 2016, 4:22 nachm., Alex Richardson wrote: > > According to the documentation AppLocalDataLocation is the following: > > "C:/Users//AppData/Local/", "C:/ProgramData/", > > "", "/data" > > > > In which directory are the desktop files? Unfortunately I can't check as my > > Windows

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

> On Jan. 3, 2016, 3:22 p.m., Alex Richardson wrote: > > According to the documentation AppLocalDataLocation is the following: > > "C:/Users//AppData/Local/", "C:/ProgramData/", > > "", "/data" > > > > In which directory are the desktop files? Unfortunately I can't check as my > > Windows