Jenkins-kde-ci: kdbusaddons master stable-kf5-qt5 » Linux,gcc - Build # 31 - Fixed!

2016-01-08 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdbusaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/31/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 08 Jan 2016 08:10:25 + Build duration: 2 min 5 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kdbusaddons master stable-kf5-qt5 » Linux,gcc - Build # 31 - Fixed!

2016-01-08 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdbusaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/31/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 08 Jan 2016 08:10:25 + Build duration: 2 min 5 sec CHANGE SET No changes JUNIT RESULTS

Re: Review Request 126670: Fix some Clazy warnings in KPeople framework

2016-01-08 Thread David Faure
> On Jan. 8, 2016, 1:20 a.m., Aleix Pol Gonzalez wrote: > > I did it myself because you're a GCI student, but besides compilation, you > > should have checked if tests still pass and specified so in the testing > > field. > > > > The change looks, good. Thanks! > > Andrey Cygankov wrote: >

Review Request 126675: Add .kra and .ora qimagio plugins

2016-01-08 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126675/ --- Review request for KDE Frameworks. Repository: kimageformats

Re: Review Request 126670: Fix some Clazy warnings in KPeople framework

2016-01-08 Thread Andrey Cygankov
> On Янв. 8, 2016, 1:20 д.п., Aleix Pol Gonzalez wrote: > > I did it myself because you're a GCI student, but besides compilation, you > > should have checked if tests still pass and specified so in the testing > > field. > > > > The change looks, good. Thanks! > > Andrey Cygankov wrote: >

Review Request 126674: Add a thumbnailer for kra/ora images

2016-01-08 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126674/ --- Review request for KDE Frameworks and David Faure. Repository:

Re: Review Request 126410: Fix FILE* leak in kwalletd

2016-01-08 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126410/#review90801 --- Heads-up: this commit actually broke kwallet when opened from

Re: Review Request 126410: Fix FILE* leak in kwalletd

2016-01-08 Thread Martin Klapetek
> On Jan. 8, 2016, 7:50 p.m., Martin Klapetek wrote: > > Heads-up: this commit actually broke kwallet when opened from pam; > > kwallet is basically blocked forever and all requests time out. > > > > I'll try to break down this patch to pinpoint which change it was > > exactly. This is the

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

2016-01-08 Thread Andreas Hartmetz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126660/ --- (Updated Jan. 8, 2016, 7:11 p.m.) Review request for KDE Frameworks,

Re: Review Request 126410: Fix FILE* leak in kwalletd

2016-01-08 Thread Christoph Cullmann
> On Jan. 8, 2016, 6:50 p.m., Martin Klapetek wrote: > > Heads-up: this commit actually broke kwallet when opened from pam; > > kwallet is basically blocked forever and all requests time out. > > > > I'll try to break down this patch to pinpoint which change it was > > exactly. > > Martin

Review Request 126681: Duplicate the file descriptor while opening

2016-01-08 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126681/ --- Review request for KDE Frameworks and Christoph Cullmann. Repository:

Re: Review Request 126681: Duplicate the file descriptor while opening

2016-01-08 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126681/#review90807 --- Ship it! Ship It! - Christoph Cullmann On Jan. 8, 2016,

Re: Review Request 126410: Fix FILE* leak in kwalletd

2016-01-08 Thread Christoph Cullmann
> On Jan. 8, 2016, 6:50 p.m., Martin Klapetek wrote: > > Heads-up: this commit actually broke kwallet when opened from pam; > > kwallet is basically blocked forever and all requests time out. > > > > I'll try to break down this patch to pinpoint which change it was > > exactly. > > Martin

Re: Review Request 126410: Fix FILE* leak in kwalletd

2016-01-08 Thread Martin Klapetek
> On Jan. 8, 2016, 7:50 p.m., Martin Klapetek wrote: > > Heads-up: this commit actually broke kwallet when opened from pam; > > kwallet is basically blocked forever and all requests time out. > > > > I'll try to break down this patch to pinpoint which change it was > > exactly. > > Martin

Re: Review Request 126681: Duplicate the file descriptor while opening

2016-01-08 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126681/ --- (Updated Jan. 8, 2016, 9:41 p.m.) Status -- This change has been

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

2016-01-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126660/#review90808 --- Ship it! Ship It! - Marco Martin On Jan. 8, 2016, 7:11

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

2016-01-08 Thread Andreas Hartmetz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126660/ --- (Updated Jan. 8, 2016, 11:29 p.m.) Status -- This change has been

Re: Review Request 126661: [GCI] Apply qstring-related clazy fixes to the core lib.

2016-01-08 Thread Mihail Ivchenko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126661/ --- (Updated Jan. 8, 2016, 12:53 p.m.) Status -- This change has been

Re: Review Request 126662: [GCI] Fix clazy's issues in core lib.

2016-01-08 Thread Mihail Ivchenko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126662/ --- (Updated Jan. 8, 2016, 12:53 p.m.) Status -- This change has been

Re: Menu/Command capitalization

2016-01-08 Thread Jaroslaw Staniek
On 8 January 2016 at 00:28, Pino Toscano wrote: > Hi, > > In data giovedì 7 gennaio 2016 22:42:18, Jaroslaw Staniek ha scritto: >> Not too long ago MS Windows has moved from "Title Capitalization" to >> "Sentence capitalization" for menus and commands: >>

Re: Review Request 126661: [GCI] Apply qstring-related clazy fixes to the core lib.

2016-01-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126661/#review90796 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 7, 2016,

Re: Menu/Command capitalization

2016-01-08 Thread Pino Toscano
In data venerdì 8 gennaio 2016 12:51:35, Jaroslaw Staniek ha scritto: > On 8 January 2016 at 00:28, Pino Toscano wrote: > > Hi, > > > > In data giovedì 7 gennaio 2016 22:42:18, Jaroslaw Staniek ha scritto: > >> Not too long ago MS Windows has moved from "Title Capitalization" to >