Re: Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

2016-01-13 Thread Kai Uwe Broulik
> On Jan. 6, 2016, 2:59 nachm., Kai Uwe Broulik wrote: > > src/inhibition.cpp, lines 38-40 > > > > > > initializer list? > > > > Private() > > : status(Inhibition::Inactive) > > , ... > >

Re: Review Request 126724: Expose callingUser in HelperSupport if available

2016-01-13 Thread Martin Gräßlin
> On Jan. 12, 2016, 3:45 p.m., David Edmundson wrote: > > looks good, thanks for this patch. > > > > note given my comment in the other patch you'll need to change 1 line here. I have adjusted to the new code locally. As it's only a minor change I'm not going to upload again to RB. - Martin

Re: Review Request 126632: add a "Complementary" color scheme to kcolorscheme

2016-01-13 Thread Jens Reuterberg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126632/#review90998 --- If I could take this, steal it away on a summer cruise,

Re: Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync

2016-01-13 Thread Martin Gräßlin
> On Jan. 12, 2016, 3:43 p.m., David Edmundson wrote: > > core/polkitqt1-subject.cpp, line 184 > > > > > > Identity > > whcih this inherits from > > > > has a QExplicitlySharedDataPointer for it's

Re: Review Request 126632: add a "Complementary" color scheme to kcolorscheme

2016-01-13 Thread Marco Martin
> On Jan. 11, 2016, 12:14 p.m., David Edmundson wrote: > > >Gwenview switches to a dark palette when in fullscreen mode for instance > > > > and how does this help solve that? There's no method to get a palette from > > a ColorSet > > Marco Martin wrote: > that may be useful to add then?

Re: Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

2016-01-13 Thread Martin Gräßlin
> On Jan. 11, 2016, 1:05 p.m., Martin Gräßlin wrote: > > src/inhibition.h, line 30 > > > > > > Maybe an explicit InhibitLockScreen? > > Martin Klapetek wrote: > Can add. Btw. is there any dbus interface to

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 199 - Unstable!

2016-01-13 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/199/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 13 Jan 2016 10:34:55 + Build duration: 7 min 28 sec CHANGE SET Revision

Re: Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync

2016-01-13 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126723/ --- (Updated Jan. 13, 2016, 11:52 a.m.) Review request for KDE Frameworks,

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 200 - Fixed!

2016-01-13 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/200/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 13 Jan 2016 11:10:26 + Build duration: 5 min 40 sec CHANGE SET Revision

Re: KIOGui ?

2016-01-13 Thread Sebastian Kügler
On Wednesday, January 13, 2016 12:33:36 AM David Faure wrote: > The question is: this would only depend on KIOCore and QImage. Shall I put > it in KIOWidgets or shall I create a new KIOGui library, for QML apps to > avoid the QWidget dependency ? I'd use this in the angelfish (experimental)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 200 - Fixed!

2016-01-13 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/200/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 13 Jan 2016 11:10:26 + Build duration: 5 min 40 sec CHANGE SET Revision

Re: KIOGui ?

2016-01-13 Thread David Faure
On Wednesday 13 January 2016 00:57:57 Kai Uwe Broulik wrote: > Hi, > > I think there are many more features in KIO that aren't really > widget-dependant, so +1 for that, though we probably cannot move them anymore > now. Yes that's exactly why I'm thinking "at least for new classes, better put

Re: Review Request 126727: [plasmaquick/dialog] Don't use KWindowEffects for Notification window type

2016-01-13 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126727/ --- (Updated Jan. 13, 2016, 7:37 p.m.) Status -- This change has been

Re: Review Request 126725: prevent crash-on-exit in KSelectAction::~KSelectAction

2016-01-13 Thread René J . V . Bertin
> On Jan. 12, 2016, 10:49 p.m., David Faure wrote: > > Can I see the backtrace, with a description of how this gets triggered? I'm > > not sure the issue is fully understood (as shown by the use of "might" in > > the description...). > > > > Is the action being destroyed by clicking into a

Re: Review Request 126734: Fix Clazy warnings in KNotifications.

2016-01-13 Thread Andrey Cygankov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126734/ --- (Updated Jan. 14, 2016, 12:30 a.m.) Review request for KDE Frameworks

Re: Review Request 126725: prevent crash-on-exit in KSelectAction::~KSelectAction

2016-01-13 Thread David Faure
> On Jan. 12, 2016, 9:49 p.m., David Faure wrote: > > Can I see the backtrace, with a description of how this gets triggered? I'm > > not sure the issue is fully understood (as shown by the use of "might" in > > the description...). > > > > Is the action being destroyed by clicking into a

Re: Review Request 126734: Fix Clazy warnings in KNotifications.

2016-01-13 Thread Andrey Cygankov
> On Янв. 13, 2016, 11:30 п.п., Aleix Pol Gonzalez wrote: > > Only the foreach I don't understand, as for the rest, note that `NewStatus` > > first argument is `QString`. > > > > Use QString::fromLatin1(). What to put in kstatusnotifieritemdbus_.cpp ? - Andrey

Re: Review Request 126734: Fix Clazy warnings in KNotifications.

2016-01-13 Thread Andrey Cygankov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126734/ --- (Updated Янв. 13, 2016, 11:59 п.п.) Review request for KDE Frameworks

Re: Review Request 126734: Fix Clazy warnings in KNotifications.

2016-01-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126734/#review91035 --- Ah, the issue with the foreach, is that the const& isn't

Re: Review Request 126734: Fix Clazy warnings in KNotifications.

2016-01-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126734/#review91038 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 14, 2016,

Review Request 126735: Fix most Clazy warnings in KItemModels.

2016-01-13 Thread Andrey Cygankov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126735/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository:

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

2016-01-13 Thread Aleix Pol Gonzalez
> On Jan. 14, 2016, 1:07 a.m., Aleix Pol Gonzalez wrote: > > These look good. You wrote "most". Which warnings couldn't you fix? > > Andrey Cygankov wrote: > log file sent `/home/andrey/dev/projects/kitemmodels/autotests/proxymodeltestsuite/proxymodeltest.h:762:17: note: expanded from

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

2016-01-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126735/#review91040 --- These look good. You wrote "most". Which warnings couldn't

Re: Review Request 126734: Fix Clazy warnings in KNotifications.

2016-01-13 Thread Andrey Cygankov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126734/ --- (Updated Янв. 13, 2016, 11:51 п.п.) Review request for KDE Frameworks

Review Request 126736: Fix all Clazy warnings in KFileMetadata.

2016-01-13 Thread Andrey Cygankov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126736/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository:

Re: Review Request 126736: Fix all Clazy warnings in KFileMetadata.

2016-01-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126736/#review91039 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 14, 2016,

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

2016-01-13 Thread Andrey Cygankov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126735/ --- (Updated Янв. 14, 2016, 12:24 д.п.) Review request for KDE Frameworks

Re: Review Request 126734: Fix Clazy warnings in KNotifications.

2016-01-13 Thread Aleix Pol Gonzalez
> On Jan. 14, 2016, 12:30 a.m., Aleix Pol Gonzalez wrote: > > Only the foreach I don't understand, as for the rest, note that `NewStatus` > > first argument is `QString`. > > > > Use QString::fromLatin1(). > > Andrey Cygankov wrote: > What to put in kstatusnotifieritemdbus_.cpp ? `return

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

2016-01-13 Thread Andrey Cygankov
> On Янв. 14, 2016, 12:07 д.п., Aleix Pol Gonzalez wrote: > > These look good. You wrote "most". Which warnings couldn't you fix? log file sent - Andrey --- This is an automatically generated e-mail. To reply, visit:

Review Request 126740: Add a script for optimizing svgs

2016-01-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126740/ --- Review request for KDE Frameworks and Plasma. Repository: breeze-icons

Review Request 126738: Remove external dependencies from svgs

2016-01-13 Thread Dirk Hohndel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126738/ --- Review request for KDE Frameworks. Repository: breeze-icons

Re: Review Request 126738: Remove external dependencies from svgs

2016-01-13 Thread Dirk Hohndel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126738/#review91047 --- this will need to be done for dozens more SVGs - I sent the

Re: KIOGui ?

2016-01-13 Thread Friedrich W. H. Kossebau
Am Mittwoch, 13. Januar 2016, 00:33:36 schrieb David Faure: > I'm about to write a class to handle favicons in a KIO library, rather than > using DBus communication to a (currently kded, could be kiod otherwise) > module. > > I think there just isn't any point in using a central DBus module to

Re: Review Request 126740: Add a script for optimizing svgs

2016-01-13 Thread Dirk Hohndel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126740/#review91046 --- I think this is a good idea - but just a small side note,

Re: Review Request 126738: Remove external dependencies from svgs

2016-01-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126738/#review91043 --- +1 Good catch. - Aleix Pol Gonzalez On Jan. 14, 2016, 2:18

Re: Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync

2016-01-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126723/#review91014 --- Ship it! Ship It! - David Edmundson On Jan. 13, 2016,