Re: Review Request 127488: Fix usage of std::isprint() function

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127488/#review93956 --- Could we get a test for this? - Aleix Pol Gonzalez On

Re: Review Request 127486: Fix uninitialized int array in UnicodeGroupProber

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127486/#review93955 --- src/probers/UnicodeGroupProber.cpp (line 78)

Re: Raising Qt requirement to Qt 5.4

El diumenge, 20 de març de 2016, a les 10:12:14 CET, David Faure va escriure: > On Friday 18 March 2016 20:16:05 Ivan Čukić wrote: > > Hi all, > > > > IIRC, the last time we talked about this we decided (I'll try to find > > the e-mail thread when I get back home, IIRC the conclusion was by > >

Re: Review Request 127488: Fix usage of std::isprint() function

> On March 24, 2016, 9:11 p.m., Dominik Haumann wrote: > > Btw: If you think QChar::isPrint() is a better choice [1], I'm happy to > > update the review request accordingly. > > > > [1] http://doc.qt.io/qt-5/qchar.html#isPrint-1 Oh, and for a correct review, the isprint() comes from

Re: Review Request 127488: Fix usage of std::isprint() function

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127488/#review93946 --- Btw: If you think QChar::isPrint() is a better choice [1],

Review Request 127488: Fix usage of std::isprint() function

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127488/ --- Review request for KDE Frameworks. Bugs: 357341

Review Request 127486: Fix uninitialized int array in UnicodeGroupProber

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127486/ --- Review request for KDE Frameworks. Bugs: 357341

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127424/#review93943 --- Given the feedback I got, I will submit tomorrow (Friday),

Re: Review Request 127409: Make sure we're not forcing the window to be created prematurely

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127409/#review93934 --- src/plasmaquick/dialog.cpp (lines 1000 - 1001)

Re: Review Request 127462: Add support for XDG_*_HOME enviroment variables.

> On März 24, 2016, 9:15 vorm., Jarosław Staniek wrote: > > My thoughts mostly related to non-Plasma, non-XDG run environments. > > > > KF5 is a great addition, in hierarchy often sitting aside of Qt, not a part > > of XDG-compliant desktop. As such we can't say too much about the > >

Re: Review Request 127462: Add support for XDG_*_HOME enviroment variables.

> On März 24, 2016, 8:16 vorm., David Faure wrote: > > autotests/kconfigtest.cpp, line 536 > > > > > > Why? On my system this wouldn't pass. > > If you want to make sure it's empty, use qunsetenv. Okay I

Re: Review Request 127462: Add support for XDG_*_HOME enviroment variables.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127462/#review93920 --- My thoughts mostly related to non-Plasma, non-XDG run

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 2 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 24 Mar 2016 08:18:45 + Build duration: 5 min 29 sec CHANGE SET Revision d6eadae8337e80f1bb8f06ce92cb4a77d67d00cb

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 2 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 24 Mar 2016 08:18:45 + Build duration: 5 min 56 sec CHANGE SET Revision

Re: Review Request 127437: Fix many threading issues in KUrlCompletion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127437/ --- (Updated March 24, 2016, 8:18 a.m.) Status -- This change has been

Re: Review Request 127462: Add support for XDG_*_HOME enviroment variables.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127462/#review93914 --- It's a bit of a stretch to say that the XDG base dir spec

Re: setting default widgetStyle (and ColorScheme)

On Saturday, November 28, 2015 7:58:47 PM CET René J. V. Bertin wrote: > Olivier Goffart wrote: > > A pure KF5 appliation would anyway use the KDE platform theme plugin > > provided by KDE Frameworks. (in frameworkintegration) > > (So in other words: that code should not be executed when kde

Re: Policy for Dependencies

On Tuesday, October 13, 2015 8:42:43 AM CEST Christoph Cullmann wrote: > Hi, thanks for raising this topic. I think it's very important that we have a general strategy for frameworks and not have thousands of micro-fixes in various frameworks. > 1) "Normal" deployment like we do in on Linux =>

Re: Jenkins and XDG_DATA_DIRS

On Tuesday, March 22, 2016 6:46:50 PM CET Ben Cooksley wrote: > On Mon, Mar 21, 2016 at 7:56 PM, Martin Graesslin wrote: > > On Saturday, March 19, 2016 10:27:38 PM CET David Faure wrote: > >> It appears that something regressed in the jenkins setup. > >> > >> Almost all of