Re: Review Request 127462: Add support for get QStandardPaths locations.

2016-03-27 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127462/#review94057 --- Much better! I don't think this should handle XDG*

Re: Review Request 127501: Improve TCPSlaveBase::isConnected

2016-03-27 Thread David Faure
> On March 27, 2016, 10:03 a.m., David Faure wrote: > > Given how the socket API works, you should only call error() after a call > > that returns false (e.g. waitForConnected, etc.). As you found out, calling > > error() at random points in time doesn't give useful information, you get > >

Re: Review Request 127488: Fix usage of std::isprint() function

2016-03-27 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127488/ --- (Updated March 27, 2016, 6:21 p.m.) Review request for KDE Frameworks.

Re: Review Request 127501: Improve TCPSlaveBase::isConnected

2016-03-27 Thread Andreas Hartmetz
> On March 27, 2016, 10:03 a.m., David Faure wrote: > > Given how the socket API works, you should only call error() after a call > > that returns false (e.g. waitForConnected, etc.). As you found out, calling > > error() at random points in time doesn't give useful information, you get > >

Re: Review Request 127462: Add support for get QStandardPaths locations.

2016-03-27 Thread Sandro Knauß
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127462/ --- (Updated März 27, 2016, 2:22 nachm.) Review request for KDE Frameworks

Re: Review Request 127501: Improve TCPSlaveBase::isConnected

2016-03-27 Thread Albert Astals Cid
> On March 27, 2016, 10:03 a.m., David Faure wrote: > > Given how the socket API works, you should only call error() after a call > > that returns false (e.g. waitForConnected, etc.). As you found out, calling > > error() at random points in time doesn't give useful information, you get > >

Re: Review Request 127501: Improve TCPSlaveBase::isConnected

2016-03-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127501/#review94042 --- Given how the socket API works, you should only call error()