Re: Review Request 127122: [Kate] Back/Forward mouse buttons

> On Март 28, 2016, 11:22 след обяд, Sven Brauch wrote: > > Hmm. Do we really need code for that? Can't you simply assign those buttons > > to the forward / backward actions as shortcuts? Try setting them as > > alternate shortcuts by default. > > Anthony Fieroni wrote: > This code is

Re: Review Request 127122: [Kate] Back/Forward mouse buttons

> On March 28, 2016, 5:22 p.m., Sven Brauch wrote: > > Hmm. Do we really need code for that? Can't you simply assign those buttons > > to the forward / backward actions as shortcuts? Try setting them as > > alternate shortcuts by default. > > Anthony Fieroni wrote: > This code is needed.

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 2 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Mar 2016 21:02:47 + Build duration: 15 min CHANGE SET Revision

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 4 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/4/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Mar 2016 21:02:47 + Build duration: 14 min CHANGE SET Revision 58b0927ac69b172a82dace1bc28990abbaa45a3e

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 2 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Mar 2016 20:46:54 + Build duration: 41 min CHANGE SET Revision

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 2 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Mar 2016 20:46:54 + Build duration: 15 min CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 3 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/3/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Mar 2016 20:46:14 + Build duration: 1 min 11 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 3 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/3/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Mar 2016 20:46:14 + Build duration: 1 min 11 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 4 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/4/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Mar 2016 20:46:14 + Build duration: 1 min 2 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 4 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/4/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Mar 2016 20:46:14 + Build duration: 1 min 2 sec CHANGE SET Revision

Re: Review Request 127122: [Kate] Back/Forward mouse buttons

> On March 28, 2016, 8:22 p.m., Sven Brauch wrote: > > Hmm. Do we really need code for that? Can't you simply assign those buttons > > to the forward / backward actions as shortcuts? Try setting them as > > alternate shortcuts by default. > > Anthony Fieroni wrote: > This code is needed.

Re: Review Request 127122: [Kate] Back/Forward mouse buttons

> On Март 28, 2016, 11:22 след обяд, Sven Brauch wrote: > > Hmm. Do we really need code for that? Can't you simply assign those buttons > > to the forward / backward actions as shortcuts? Try setting them as > > alternate shortcuts by default. > > Anthony Fieroni wrote: > This code is

Re: Review Request 127122: [Kate] Back/Forward mouse buttons

> On März 28, 2016, 8:22 nachm., Sven Brauch wrote: > > Hmm. Do we really need code for that? Can't you simply assign those buttons > > to the forward / backward actions as shortcuts? Try setting them as > > alternate shortcuts by default. > > Anthony Fieroni wrote: > This code is needed.

Re: Review Request 127122: [Kate] Back/Forward mouse buttons

> On March 28, 2016, 8:22 p.m., Sven Brauch wrote: > > Hmm. Do we really need code for that? Can't you simply assign those buttons > > to the forward / backward actions as shortcuts? Try setting them as > > alternate shortcuts by default. > > Anthony Fieroni wrote: > This code is needed.

Re: Review Request 127122: [Kate] Back/Forward mouse buttons

> On Март 28, 2016, 11:22 след обяд, Sven Brauch wrote: > > Hmm. Do we really need code for that? Can't you simply assign those buttons > > to the forward / backward actions as shortcuts? Try setting them as > > alternate shortcuts by default. This code is needed. QKeySequence is about *only*

Re: Review Request 127122: [Kate] Back/Forward mouse buttons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127122/#review94084 --- Hmm. Do we really need code for that? Can't you simply

Re: Review Request 127122: [Kate] Back/Forward mouse buttons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127122/ --- (Updated Март 28, 2016, 11:20 след обяд) Review request for Kate, KDE

Re: Review Request 126610: kwidgetitemdelegate: properly cleanup widgets on index removal

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126610/#review94076 --- Do you still have the sample application you made to

Re: Review Request 127462: Add support for get QStandardPaths locations.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127462/ --- (Updated March 28, 2016, 3:47 p.m.) Status -- This change has been

Re: Review Request 127462: Add support for get QStandardPaths locations.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127462/ --- (Updated März 28, 2016, 3:21 nachm.) Review request for KDE Frameworks

Re: Review Request 127462: Add support for get QStandardPaths locations.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127462/#review94075 --- LGTM. Two minor issues with the documentation, then it is

Re: Review Request 127462: Add support for get QStandardPaths locations.

> On March 28, 2016, 1:39 a.m., Matthew Dawson wrote: > > Much better! I don't think this should handle XDG* variables explicitly, > > as they won't be used on other platforms and may cause confusion there. On > > platforms using XDG* variables, Qt handles this for us internally. I > >

Re: Review Request 127501: Improve TCPSlaveBase::isConnected

> On March 27, 2016, 10:03 a.m., David Faure wrote: > > Given how the socket API works, you should only call error() after a call > > that returns false (e.g. waitForConnected, etc.). As you found out, calling > > error() at random points in time doesn't give useful information, you get > >

Re: Review Request 127501: Improve TCPSlaveBase::isConnected

> On March 27, 2016, 10:03 a.m., David Faure wrote: > > Given how the socket API works, you should only call error() after a call > > that returns false (e.g. waitForConnected, etc.). As you found out, calling > > error() at random points in time doesn't give useful information, you get > >

Review Request 127514: Skip category test if no restriction is set.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127514/ --- Review request for KDE Frameworks. Repository: kcmutils Description

Re: Review Request 126610: kwidgetitemdelegate: properly cleanup widgets on index removal

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126610/#review94071 --- ping - Pino Toscano On Mar. 28, 2016, 1:39 p.m., Pino

Re: oxygen icon name clasheroo

I'm coming across more of these clashes. Just had one in Calligra. So yes I think it's a good idea to move the frameworks Oxygen icons to a new path. Jonathan On 21 March 2016 at 08:30, Harald Sitter wrote: > On Sun, Mar 20, 2016 at 10:08 AM, David Faure wrote:

Re: Review Request 125570: Handle kabc deprecated classes in kabc->kcontact porting script

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125570/ --- (Updated March 28, 2016, 4:14 p.m.) Status -- This change has been

Re: Review Request 125570: Handle kabc deprecated classes in kabc->kcontact porting script

> On March 26, 2016, 3:23 p.m., David Faure wrote: > > Looks good to me, although this could all be a single perl script instead > > of a bash script calling perl so many times ;) But that's unrelated to this > > commit. > > > > Also in its current form, it should be a .sh rather than a .pl

Re: Review Request 127462: Add support for get QStandardPaths locations.

> On März 28, 2016, 5:39 vorm., Matthew Dawson wrote: > > Much better! I don't think this should handle XDG* variables explicitly, > > as they won't be used on other platforms and may cause confusion there. On > > platforms using XDG* variables, Qt handles this for us internally. I > >