Re: Review Request 126480: Fix assorted memory leaks and undefined accesses

2016-04-09 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126480/ --- (Updated April 10, 2016, 12:52 a.m.) Status -- This change has been

Re: Finding local translations?

2016-04-09 Thread Chusslove Illich
>> [: Boudewijn Rempt :] >> However, KCatalog::catalogLocaleDir is run before the main runs, and uses >> QStandardPaths to find the location of the translations. That's before >> the XDG_DATA_DIRS environment variable is set. > > [: Alexander Potashev :] > You can use a wrapper application that

Re: Finding local translations?

2016-04-09 Thread Alexander Potashev
2016-04-07 12:56 GMT+03:00 Boudewijn Rempt : > However, KCatalog::catalogLocaleDir is run before the main runs, > and uses QStandardPaths to find the location of the translations. > That's before the XDG_DATA_DIRS environment variable is set. You can use a wrapper application

Re: Please add new versions on bugs.kde.org products on KF5 releases

2016-04-09 Thread Friedrich W. H. Kossebau
Am Samstag, 9. April 2016, 18:33:33 CEST schrieb David Faure: > On Saturday 09 April 2016 17:04:06 Friedrich W. H. Kossebau wrote: > > Though perhaps the versions should be added to bugs.kde.org on time or > > even > > before bumping the version number in the sources. Because developers who > >

Re: Finding local translations?

2016-04-09 Thread David Faure
On Thursday 07 April 2016 11:56:59 Boudewijn Rempt wrote: > > In other words, the translations are located relative to the > application binary. I add these locations to the XDG_DATA_DIRS > environment variable in my main. > > However, KCatalog::catalogLocaleDir is run before the main runs, >

Re: Please add new versions on bugs.kde.org products on KF5 releases

2016-04-09 Thread David Faure
On Saturday 09 April 2016 17:04:06 Friedrich W. H. Kossebau wrote: > Though perhaps the versions should be added to bugs.kde.org on time or even > before bumping the version number in the sources. Because developers who run > from latest git master and find bugs would rely on the version number

Re: Please add new versions on bugs.kde.org products on KF5 releases

2016-04-09 Thread Friedrich W. H. Kossebau
Am Samstag, 9. April 2016, 12:09:30 CEST schrieb David Faure: > On Friday 08 April 2016 02:10:15 Friedrich W. H. Kossebau wrote: > > Hi, > > > > please do not forget to also add versions to KF5 products on bugs.kde.org > > on new releases. > > I don't, it's now part of the release procedure.

Re: Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

2016-04-09 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127253/#review94450 --- Ship it! Ship It! - John Layt On April 7, 2016, 10:53

Re: Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

2016-04-09 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127253/#review94443 --- - John Layt On April 7, 2016, 10:53 p.m., Kai Uwe Broulik

Re: Please add new versions on bugs.kde.org products on KF5 releases

2016-04-09 Thread David Faure
On Friday 08 April 2016 02:10:15 Friedrich W. H. Kossebau wrote: > Hi, > > please do not forget to also add versions to KF5 products on bugs.kde.org on > new releases. I don't, it's now part of the release procedure. > Was there not a script provided by some good developers meanwhile to help

Re: Review Request 127613: Add a test application to render all icons installed on an X11 window

2016-04-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127613/#review94448 --- Fix it, then Ship it! Cool, sounds useful for our

Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

2016-04-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127251/#review94447 --- src/currency.cpp (line 667)

Re: Review Request 127380: More conservative approach to saving some disk accesses

2016-04-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127380/#review94446 --- Fix it, then Ship it! Only minor things left.