Re: Review Request 127795: [DataEngine] Fix memory leak and possible crash + detailed test

2016-04-30 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127795/ --- (Updated Май 1, 2016, 8:54 преди обяд) Review request for KDE Frameworks

Re: Review Request 127795: [DataEngine] Fix memory leak and possible crash + detailed test

2016-04-30 Thread Anthony Fieroni
> On Май 1, 2016, 3:14 преди обяд, Michael Pyne wrote: > > src/plasma/private/dataenginemanager.cpp, line 49 > > > > > > Is it safe to remove this, given that even the change to > >

Re: Review Request 127795: [DataEngine] Fix memory leak and possible crash + detailed test

2016-04-30 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127795/#review95047 --- Note first off that I'm not a Plasma dev, so some of these

Re: Review Request 127666: kconfig and kurlrequester friendship: store local paths in string-typed item without file:// prefix

2016-04-30 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127666/ --- (Updated April 30, 2016, 11:45 p.m.) Status -- This change has been

Review Request 127800: Format number in KLocalizedString::subs

2016-04-30 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127800/ --- Review request for KDE Frameworks. Repository: ki18n Description

Fwd: [kate/Applications/16.04] kate: Close document: use icon document-close instead of window-close

2016-04-30 Thread Dominik Haumann
Hi all, I wonder, whether the correct fix would be to change the default icon for KStandardAction::Close from "window-close" to "document-close"? Cheers, Dominik -- Forwarded message -- From: Dominik Haumann Date: Sat, Apr 30, 2016 at 11:02 PM Subject:

Review Request 127795: [DataEngine] Fix memory leak and possible crash + detailed test

2016-04-30 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127795/ --- Review request for KDE Frameworks and Marco Martin. Repository:

Jenkins-kde-ci: krunner master kf5-qt5 » Linux,gcc - Build # 38 - Fixed!

2016-04-30 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/krunner%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/38/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 30 Apr 2016 08:53:34 + Build duration: 5 min 40 sec CHANGE SET No changes JUNIT RESULTS Name:

Re: Review Request 127786: Remove custom read functions for QString and QStringList

2016-04-30 Thread Jos van den Oever
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127786/ --- (Updated April 30, 2016, 1:50 a.m.) Status -- This change has been

Re: Review Request 127786: Remove custom read functions for QString and QStringList

2016-04-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127786/#review95037 --- Ship it! I see. That function in Qt3 was allocating