Review Request 127865: Check size of unix domain socket path before copying to it.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127865/ --- Review request for KDE Frameworks. Repository: kcrash Description

Re: Review Request 127833: KWallet: More Coverity fixes, and include Qt headers for endianness check.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127833/ --- (Updated May 8, 2016, 12:10 a.m.) Review request for KDE Frameworks.

Re: Review Request 127860: kauth: helperDebugHandler is not handling QtInfoMsg

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127860/#review95267 --- Fix it, then Ship it! Use LOG_INFO (and add LOG_INFO to

Re: KFilePlacesModelTest

On Sat, May 7, 2016 14:33:53 David Faure wrote: > The thing I wonder is... does it really make sense to have a model with > random ordering? Isn't it a problem for users if their visible list of > places is different between every run? Or am I missing something and the > different order in the

Re: Review Request for KWayland for inclusion in frameworks

On Sat, May 7, 2016 13:50:05 David Faure wrote: > Hi guys, > > Can you check the CI for KWayland? ASAN detects an invalid memory usage > in KWayland::Client::OutputDevice::Private::doneCallback() called after > KWayland::Client::OutputDevice::~OutputDevice(). > >

Re: Review Request 127834: ki18n: Fix theoretically possible use-after-free in gettext when using strict ANSI compilers

> On May 7, 2016, 12:26 p.m., Christoph Feck wrote: > > This commit causes compilation failure: > > > > ki18n/src/gettext.h:130:9: error: 'translation_found' was not declared in > > this scope > > ki18n/src/gettext.h:180:9: error: 'translation_found' was not declared in > > this scope > >

LGPL for Breeze QStyle and qtquickcontrols?

Hi, Is relicensing Breeze QStyle to LGPL from GPL for possible and acceptable? I've found cases when bits of the code beyond QStyle/KStyle API need to be reused. One example is: custom widgets. If we're considering Breeze QStyle as implementation of certain artwork, and KDE artwork in general

Re: KFilePlacesModelTest

Hello, Not sure I can be of any help anymore in that area, I've been way to remote from that code for years now. That said there's a couple of questions at the end I might be able to answer: On Saturday, 7 May 2016 14:33:53 CEST David Faure wrote: > The thing I wonder is... does it really make

Jenkins-kde-ci: kmediaplayer master stable-kf5-qt5 » Linux,gcc - Build # 53 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kmediaplayer%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/53/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 19:34:50 + Build duration: 55 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kmediaplayer master stable-kf5-qt5 » Linux,gcc - Build # 53 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kmediaplayer%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/53/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 19:34:50 + Build duration: 55 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kdewebkit master stable-kf5-qt5 » Linux,gcc - Build # 53 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdewebkit%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/53/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 19:34:50 + Build duration: 42 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kdewebkit master stable-kf5-qt5 » Linux,gcc - Build # 53 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdewebkit%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/53/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 19:34:50 + Build duration: 42 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: knewstuff master stable-kf5-qt5 » Linux,gcc - Build # 53 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knewstuff%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/53/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 19:28:44 + Build duration: 1 min 29 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: knewstuff master stable-kf5-qt5 » Linux,gcc - Build # 53 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/knewstuff%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/53/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 19:28:44 + Build duration: 1 min 29 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 50 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/50/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 19:22:34 + Build duration: 5 min 48 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kxmlgui master kf5-qt5 » Linux,gcc - Build # 20 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kxmlgui%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/20/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 19:11:32 + Build duration: 2 min 48 sec CHANGE SET No changes

Jenkins-kde-ci: kunitconversion master kf5-qt5 » Linux,gcc - Build # 24 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kunitconversion%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/24/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 19:11:32 + Build duration: 2 min 17 sec CHANGE SET No changes

Re: KFilePlacesModelTest

On Saturday 07 May 2016 19:03:17 Giuseppe D'Angelo wrote: > Il 07/05/2016 14:33, David Faure ha scritto: > > The thing I wonder is... does it really make sense to have a model with > > random ordering? > > Isn't it a problem for users if their visible list of places is different > > between

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 31 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/31/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 15:03:48 + Build duration: 34 min CHANGE SET Revision

Review Request 127860: kauth: helperDebugHandler is not handling QtInfoMsg

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127860/ --- Review request for KDE Frameworks. Repository: kauth Description

Jenkins-kde-ci: threadweaver master kf5-qt5 » Linux,gcc - Build # 18 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/threadweaver%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/18/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 15:27:55 + Build duration: 1 min 27 sec CHANGE SET Revision

Jenkins-kde-ci: threadweaver master kf5-qt5 » Linux,gcc - Build # 18 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/threadweaver%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/18/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 15:27:55 + Build duration: 1 min 27 sec CHANGE SET Revision

Jenkins-kde-ci: kmediaplayer master stable-kf5-qt5 » Linux,gcc - Build # 52 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kmediaplayer%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/52/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 15:16:14 + Build duration: 5.3 sec CHANGE SET No changes

Jenkins-kde-ci: kdewebkit master stable-kf5-qt5 » Linux,gcc - Build # 52 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdewebkit%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/52/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 15:16:14 + Build duration: 5.8 sec CHANGE SET No changes

Jenkins-kde-ci: knewstuff master stable-kf5-qt5 » Linux,gcc - Build # 52 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/knewstuff%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/52/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 15:14:39 + Build duration: 9.1 sec CHANGE SET No changes

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 49 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/49/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 14:52:32 + Build duration: 21 min CHANGE SET Revision 69e4e71fe3db699f4a68bb7278cedf641fa43c2a

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 28 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/28/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 15:03:48 + Build duration: 5 min 15 sec CHANGE SET Revision

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 53 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/53/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 14:52:32 + Build duration: 4 min 59 sec CHANGE SET Revision 69e4e71fe3db699f4a68bb7278cedf641fa43c2a

Re: Review Request 127806: Q_BYTE_ORDER not defined in the kwallet backends

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127806/ --- (Updated May 7, 2016, 2:54 p.m.) Status -- This change has been

Re: Review Request 127806: Q_BYTE_ORDER not defined in the kwallet backends

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127806/#review95263 --- Ship it! Ship It! - David Faure On May 7, 2016, 2:25

Re: Jenkins-kde-ci (many CI failures)

kdewebkit just failed with "Broken pipe" (the TCP error you mentionned) (and kxmlrpcclient failed again with an anongit error). This is like playing wack-a-mole... I thought TCP was more robust than that. Would it help to increase some TCP-related timeout somewhere? On Saturday 07 May 2016

Re: Review Request 127806: Q_BYTE_ORDER not defined in the kwallet backends

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127806/ --- (Updated May 7, 2016, 2:25 p.m.) Review request for KDE Frameworks and

Jenkins-kde-ci: kdewebkit master stable-kf5-qt5 » Linux,gcc - Build # 51 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdewebkit%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/51/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 12:55:20 + Build duration: 18 min CHANGE SET No changes

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 52 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/52/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 12:45:54 + Build duration: 6 min 28 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 48 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/48/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 12:44:49 + Build duration: 4 min 21 sec CHANGE SET No changes JUNIT RESULTS Name:

Re: Review Request 127834: ki18n: Fix theoretically possible use-after-free in gettext when using strict ANSI compilers

> On Мај 7, 2016, 2:26 по п., Christoph Feck wrote: > > This commit causes compilation failure: > > > > ki18n/src/gettext.h:130:9: error: 'translation_found' was not declared in > > this scope > > ki18n/src/gettext.h:180:9: error: 'translation_found' was not declared in > > this scope Moved

Re: Review Request 127834: ki18n: Fix theoretically possible use-after-free in gettext when using strict ANSI compilers

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127834/#review95259 --- This commit causes compilation failure:

Jenkins-kde-ci: kxmlrpcclient master stable-kf5-qt5 » Linux,gcc - Build # 47 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kxmlrpcclient%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/47/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 11:50:55 + Build duration: 1 min 10 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kxmlrpcclient master stable-kf5-qt5 » Linux,gcc - Build # 47 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kxmlrpcclient%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/47/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 11:50:55 + Build duration: 1 min 10 sec CHANGE SET No changes JUNIT RESULTS

Re: Jenkins-kde-ci: kbookmarks master stable-kf5-qt5 » Linux, gcc - Build # 17 - Failure!

On Sat, May 7, 2016 at 9:02 PM, David Faure wrote: > On Saturday 07 May 2016 04:19:37 no-re...@kde.org wrote: >> >> GENERAL INFO >> >> BUILD FAILURE >> Build URL: >> https://build.kde.org/job/kbookmarks%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/17/ > > Something's

Re: Review Request for KWayland for inclusion in frameworks

Hi guys, Can you check the CI for KWayland? ASAN detects an invalid memory usage in KWayland::Client::OutputDevice::Private::doneCallback() called after KWayland::Client::OutputDevice::~OutputDevice().

Jenkins-kde-ci: kxmlrpcclient master stable-kf5-qt5 » Linux,gcc - Build # 46 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kxmlrpcclient%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/46/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 11:23:17 + Build duration: 4 min 38 sec CHANGE SET No changes

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 51 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/51/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 11:17:07 + Build duration: 4 min 26 sec CHANGE SET Revision 31bc0c2ca113fa4e8352fa3faaf2ab04b011ae74

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 47 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/47/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 11:17:07 + Build duration: 5 min 41 sec CHANGE SET Revision

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 50 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/50/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 10:46:03 + Build duration: 14 min CHANGE SET Revision ce72392bbcba0f51eac1a729e928a52192e904ac by

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 46 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/46/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 10:46:03 + Build duration: 5 min 45 sec CHANGE SET Revision

Re: Review Request 127843: Properly remove composed characters

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127843/#review95257 --- I can see that the patch works, since Qt's QTextLayout

Re: Review Request 127843: Properly remove composed characters

> On May 5, 2016, 10:07 a.m., Jan Grulich wrote: > > Looks that review board cannot handle indic characters. I posted them here: > > https://paste.kde.org/piptzo584 > > Dominik Haumann wrote: > I guess backspace should remove the entire character, i.e. as much as > when navigating with

Jenkins-kde-ci: ktextwidgets master stable-kf5-qt5 » Linux,gcc - Build # 17 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktextwidgets%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/17/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 09:10:53 + Build duration: 55 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: ktextwidgets master stable-kf5-qt5 » Linux,gcc - Build # 17 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktextwidgets%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/17/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 09:10:53 + Build duration: 55 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 27 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/27/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 09:03:41 + Build duration: 6 min 15 sec CHANGE SET Revision

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 45 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/45/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 08:58:20 + Build duration: 5 min 39 sec CHANGE SET No changes JUNIT RESULTS Name:

Re: Review Request 127843: Properly remove composed characters

> On May 5, 2016, 10:07 a.m., Jan Grulich wrote: > > Looks that review board cannot handle indic characters. I posted them here: > > https://paste.kde.org/piptzo584 I guess backspace should remove the entire character, i.e. as much as when navigating with the cursor, right? There is also a

Re: Jenkins-kde-ci: kbookmarks master stable-kf5-qt5 » Linux, gcc - Build # 17 - Failure!

On Saturday 07 May 2016 04:19:37 no-re...@kde.org wrote: > > GENERAL INFO > > BUILD FAILURE > Build URL: > https://build.kde.org/job/kbookmarks%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/17/ Something's quite unstable with DNS. Could not resolve hostname build.kde.org: Temporary

Jenkins-kde-ci: kbookmarks master stable-kf5-qt5 » Linux,gcc - Build # 18 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kbookmarks%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/18/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 08:56:40 + Build duration: 1 min 10 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kbookmarks master stable-kf5-qt5 » Linux,gcc - Build # 18 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kbookmarks%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/18/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 08:56:40 + Build duration: 1 min 10 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 26 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/26/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 May 2016 08:15:09 + Build duration: 13 min CHANGE SET Revision