Re: Review Request 127896: make dbus optional on osx: kauth

2016-05-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127896/#review95394 --- src/CMakeLists.txt (line 32)

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2016-05-21 Thread David Faure
> On April 5, 2015, 2:26 p.m., David Faure wrote: > > Well, +1 for the idea. But I wonder what the apidox will look like, the > > macro+template probably don't make it work. > > > > Also missing @since 5.10. > > > > Ship it from me once the apidox issue is resolved. > > Gleb Popov wrote: >

Re: LGPL for Breeze QStyle and qtquickcontrols?

2016-05-21 Thread Jaroslaw Staniek
On 18 May 2016 at 17:51, Martin Graesslin wrote: > On Wednesday, May 18, 2016 12:41:49 PM CEST Jaroslaw Staniek wrote: > > On 17 May 2016 at 20:38, Martin Graesslin wrote: > > > On Tuesday, May 17, 2016 6:23:10 PM CEST Jaroslaw Staniek wrote: > > > > > If

Re: Review Request 127984: Always update the Trader parser from y/l sources

2016-05-21 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127984/#review95687 --- Ship it! Ship It! - Michael Pyne On May 21, 2016, 1:50

Re: Review Request 127747: Create a new script that generate the documentation for all projects following the syntax I proposed

2016-05-21 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127747/#review95686 --- Ship it! Well I'm not the Maintainer of All Frameworks

Re: Review Request 127835: KHTML: Try again to fix Coverity memory leak in CSS background property

2016-05-21 Thread Michael Pyne
> On May 21, 2016, 1:56 p.m., Andrea Iacovitti wrote: > > src/css/cssparser.cpp, lines 2143-2158 > > > > > > If value->length() is 0 we should not return true because we failed to > > parse the value. > >

Re: Review Request 127896: make dbus optional on osx: kauth

2016-05-21 Thread René J . V . Bertin
> On May 21, 2016, 10:20 p.m., Kåre Särs wrote: > > CMakeLists.txt, line 12 > > > > > > Why is this not: option(DISABLE_DBUS "Remove..." OFF) ? > > > > For the rest I'm happy :) Idem. Isn't there a

Re: Review Request 127896: make dbus optional on osx: kauth

2016-05-21 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127896/#review95681 --- CMakeLists.txt (line 12)

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 42 - Fixed!

2016-05-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/42/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 21 May 2016 16:02:54 + Build duration: 5 min 29 sec CHANGE SET Revision

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 42 - Fixed!

2016-05-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/42/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 21 May 2016 16:02:54 + Build duration: 5 min 29 sec CHANGE SET Revision

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 39 - Still unstable!

2016-05-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/39/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 21 May 2016 16:02:54 + Build duration: 3 min 55 sec CHANGE SET Revision

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 38 - Failure!

2016-05-21 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/38/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 21 May 2016 15:54:30 + Build duration: 1 min 38 sec CHANGE SET Revision

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 41 - Failure!

2016-05-21 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/41/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 21 May 2016 15:54:29 + Build duration: 1 min 58 sec CHANGE SET Revision

Re: Review Request 127973: Fix race in which the file containing the X11 cookie has the wrong permissions

2016-05-21 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127973/ --- (Updated May 21, 2016, 3:49 p.m.) Status -- This change has been

Re: Review Request 127835: KHTML: Try again to fix Coverity memory leak in CSS background property

2016-05-21 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127835/#review95672 --- src/css/cssparser.cpp (lines 2120 - 2134)

Review Request 127984: Always update the Trader parser from y/l sources

2016-05-21 Thread Pino Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127984/ --- Review request for KDE Frameworks. Repository: kservice Description

Re: Review Request 127972: Always update the Predicate parser from y/l sources

2016-05-21 Thread Pino Toscano
> On May 20, 2016, 11:21 p.m., René J.V. Bertin wrote: > > I've done some testing with Solid 5.20.0 .The patch applies cleanly, but > > I'm getting the error below. I'd write that down to using the older Solid > > version if it weren't for that fact I'm quite sure I've seen this kind of > >

Re: Review Request 127972: Always update the Predicate parser from y/l sources

2016-05-21 Thread René J . V . Bertin
> On May 21, 2016, 1:21 a.m., René J.V. Bertin wrote: > > I've done some testing with Solid 5.20.0 .The patch applies cleanly, but > > I'm getting the error below. I'd write that down to using the older Solid > > version if it weren't for that fact I'm quite sure I've seen this kind of > >

Re: Review Request 126610: kwidgetitemdelegate: properly cleanup widgets on index removal

2016-05-21 Thread Pino Toscano
> On March 28, 2016, 5:14 p.m., Stephen Kelly wrote: > > Do you still have the sample application you made to test/verify this? I'd > > like to try it and it should probably be committed too. No I don't :-/ I remember it was just removing indexes with associated widgets. - Pino