Re: Review Request 128263: Don't include embedded contrainers in containmentAt(pos) - fix crash when adding a system tray.

2016-06-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128263/ --- (Updated June 21, 2016, 12:54 p.m.) Status -- This change has been

Re: Review Request 128263: Don't include embedded contrainers in containmentAt(pos) - fix crash when adding a system tray.

2016-06-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128263/#review96780 --- Ship it! Ship It! - Marco Martin On June 20, 2016,

Re: Review Request 127912: Add 2 methods to gain more info about a mimetype or protocol

2016-06-21 Thread Martin Kostolný
> On May 14, 2016, 1:59 p.m., David Faure wrote: > > But how is the app supposed to then choose which protocol to use? > > > > If it needs its own setting for the preferred kioslave, then what's the > > point of the query that returns a list? > > > > In other words, if you know you want to

Jenkins-kde-ci: kparts master kf5-qt5 » Linux,gcc - Build # 116 - Fixed!

2016-06-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kparts%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/116/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 21 Jun 2016 10:54:06 + Build duration: 2 min 8 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kparts master kf5-qt5 » Linux,gcc - Build # 116 - Fixed!

2016-06-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kparts%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/116/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 21 Jun 2016 10:54:06 + Build duration: 2 min 8 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 111 - Still Unstable!

2016-06-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/111/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 21 Jun 2016 10:40:51 + Build duration: 11 min CHANGE SET Revision 5bfd8cd7b2b62c95f66871c1f049650a52975379 by

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 111 - Still Unstable!

2016-06-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/111/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 21 Jun 2016 10:40:51 + Build duration: 8 min 19 sec CHANGE SET Revision

Re: Review Request 127912: Add 2 methods to gain more info about a mimetype or protocol

2016-06-21 Thread David Faure
> On May 14, 2016, 1:59 p.m., David Faure wrote: > > But how is the app supposed to then choose which protocol to use? > > > > If it needs its own setting for the preferred kioslave, then what's the > > point of the query that returns a list? > > > > In other words, if you know you want to

Re: Review Request 127912: Add 2 methods to gain more info about a mimetype or protocol

2016-06-21 Thread Martin Kostolný
> On May 14, 2016, 1:59 p.m., David Faure wrote: > > But how is the app supposed to then choose which protocol to use? > > > > If it needs its own setting for the preferred kioslave, then what's the > > point of the query that returns a list? > > > > In other words, if you know you want to

Re: Review Request 128249: Add switch to disable KParts' handling of window titles

2016-06-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128249/#review96773 --- Would it be better to just have a setter and a member bool

Re: Review Request 128249: Add switch to disable KParts' handling of window titles

2016-06-21 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128249/#review96772 --- Rest LGTM src/mainwindow.cpp (line 81)