Re: Review Request 128219: No longer allow installing to generic data folder because of security hole.

> On June 17, 2016, 1:36 a.m., David Faure wrote: > > src/core/installation.cpp, line 379 > > > > > > There are of course other values for targetDirectory which would create > > problems. > > - "//" > >

Re: Review Request 128283: Add checksums tab to the properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/#review96962 --- src/widgets/kpropertiesdialog.cpp (line 2776)

Re: Review Request 128283: Add checksums tab to the properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/ --- (Updated June 29, 2016, 6:06 p.m.) Review request for KDE Frameworks,

Re: Review Request 128283: Add checksums tab to the properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/#review96960 --- Nice feature addition :) Is there a plan for plugins to this

Re: Review Request 128319: Fix memory leaks in the properties dialog

> On June 29, 2016, 2:44 p.m., David Faure wrote: > > src/widgets/kpropertiesdialog.cpp, line 825 > > > > > > This line, here, reparents the frame to the properties dialog. There is > > no leak. Oh, that

Re: Review Request 128319: Fix memory leaks in the properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128319/#review96958 --- src/widgets/kpropertiesdialog.cpp (line 825)

Review Request 128319: Fix memory leaks in the properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128319/ --- Review request for KDE Frameworks and David Faure. Repository: kio

Re: Review Request 128283: Add checksums tab to the properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/ --- (Updated June 29, 2016, 2:37 p.m.) Review request for KDE Frameworks,

Re: Review Request 128312: Fix notify by taskbar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128312/#review96957 --- Ship it! Looks good! - Martin Klapetek On June 28,

Re: Review Request 128317: Make the download dialog fail when *all* categories are missing, not just one

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128317/ --- (Updated June 29, 2016, 2:28 p.m.) Status -- This change has been

Re: Review Request 128317: Make the download dialog fail when *all* categories are missing, not just one

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128317/#review96956 --- Ship it! Ship It! - Jeremy Whiting On June 29, 2016,

Re: Review Request 128316: Make use of QQuickItem::setSize instead of width and height indpedently.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128316/#review96954 --- Ship it! Ship It! - Marco Martin On June 29, 2016,

Review Request 128317: Make the download dialog fail when *all* categories are missing, not just one

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128317/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository:

Re: Review Request 128317: Make the download dialog fail when *all* categories are missing, not just one

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128317/ --- (Updated June 29, 2016, 11:27 a.m.) Review request for KDE Frameworks

Re: Review Request 128316: Make use of QQuickItem::setSize instead of width and height indpedently.

> On jun 29, 2016, 11:05 a.m., Mark Gaiser wrote: > > I think you found an undocumented feature. > > The docs don't mention it, not even in the list of all members + inherited > > ones: http://doc.qt.io/qt-5/qquickitem-members.html > > > > But if i add a QQuickItem in my project and look up

Re: Review Request 128316: Make use of QQuickItem::setSize instead of width and height indpedently.

> On Juni 29, 2016, 11:05 vorm., Mark Gaiser wrote: > > I think you found an undocumented feature. > > The docs don't mention it, not even in the list of all members + inherited > > ones: http://doc.qt.io/qt-5/qquickitem-members.html > > > > But if i add a QQuickItem in my project and look up

Re: Review Request 128316: Make use of QQuickItem::setSize instead of width and height indpedently.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128316/#review96951 --- Ship it! I think you found an undocumented feature. The

Review Request 128316: Make use of QQuickItem::setSize instead of wight and height indpedently.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128316/ --- Review request for KDE Frameworks and Plasma. Repository:

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 119 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/119/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 29 Jun 2016 09:34:08 + Build duration: 10 min CHANGE SET Revision

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 119 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/119/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 29 Jun 2016 09:34:08 + Build duration: 4 min 55 sec CHANGE SET Revision cb3b08058484008910b8c18b549554a08519ea4b

kded's cmake package

Hola! So, I just noticed that KDED's cmake package is inconsistently named. cmake/KF5DocTools/ versus cmake/KDED/ Is there a reason for this? Are we going to change this for KF6? :/ HS ___ Kde-frameworks-devel mailing list

Re: Is it able to make kservice's weightedOffers public access?

On 2016-06-28, Leslie Zhai wrote: > Hi KDE developers, > > It might needs to use static KServiceTypeTrader::weightedOffers(const > QString ) to get KServiceOfferList offers, for example, I'll let David Faure (kservice maintainer) to comment on if this makes sense or