Re: Where to put kwayland integration plugins

2016-07-03 Thread Martin Graesslin
On Saturday, July 2, 2016 8:59:28 PM CEST you wrote: > On samedi 2 juillet 2016 15:25:39 CEST Martin Graesslin wrote: > > On Saturday, July 2, 2016 11:41:11 AM CEST David Faure wrote: > > > On lundi 6 juin 2016 11:26:58 CEST Aleix Pol wrote: > > > > On Mon, Jun 6, 2016 at 8:32 AM, Martin Graesslin

Re: Review Request 128233: Don't trust files claiming to be created on unix more than other files

2016-07-03 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128233/#review97067 --- Fix it, then Ship it! autotests/karchivetest.cpp (line

Re: Review Request 128353: Unit tests of directory permissions in zip files

2016-07-03 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128353/#review97066 --- Fix it, then Ship it! autotests/karchivetest.cpp (line

Re: Review Request 128283: Add checksums tab to the properties dialog

2016-07-03 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128283/ --- (Updated July 3, 2016, 3:27 p.m.) Review request for KDE Frameworks, KDE

Re: Review Request 128349: Silence warning about widget already having a layout

2016-07-03 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128349/ --- (Updated July 3, 2016, 4:57 p.m.) Status -- This change has been

Re: Review Request 128353: Unit tests of directory permissions in zip files

2016-07-03 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128353/ --- (Updated July 3, 2016, 1:09 p.m.) Review request for KDE Frameworks and

Review Request 128353: Unit tests of directory permissions in zip files

2016-07-03 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128353/ --- Review request for KDE Frameworks and David Faure. Repository: karchive

Re: Review Request 128340: Don't use QQuickWidget::quickWindow() as it was added in Qt 5.5

2016-07-03 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128340/ --- (Updated July 3, 2016, 1:05 p.m.) Status -- This change has been

Re: Review Request 128233: Don't trust files claiming to be created on unix more than other files

2016-07-03 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128233/ --- (Updated July 3, 2016, 1:03 p.m.) Review request for KDE Frameworks and

Re: Review Request 128233: Don't trust files claiming to be created on unix more than other files

2016-07-03 Thread Sune Vuorela
> On July 2, 2016, 10:50 a.m., David Faure wrote: > > autotests/karchivetest.cpp, line 1097 > > > > > > That's not really a unit test, if the person running the test has to > > read the output ;) heh. I the

Re: Review Request 128237: add failing unit test likely showing off bug 232843

2016-07-03 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128237/ --- (Updated July 3, 2016, 12:20 p.m.) Status -- This change has been

Re: Review Request 128237: add failing unit test likely showing off bug 232843

2016-07-03 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128237/#review97057 --- autotests/kfiltertest.cpp (line 443)

Re: Review Request 128014: [KToggleToolBarAction] Honor action/options_show_toolbar restriction

2016-07-03 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128014/ --- (Updated July 3, 2016, 11:26 a.m.) Status -- This change has been

Re: Review Request 128103: Add license texts for KAboutLicense ; add LGPL v2.1 as separate license.

2016-07-03 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128103/#review97056 --- Ship it! Ship It! - David Faure On July 2, 2016, 9:44