Re: Review Request 128471: [kio] Some fixes for KNewFileMenu.

2016-07-21 Thread Chinmoy Ranjan Pradhan
> On July 21, 2016, 9:52 p.m., David Faure wrote: > > Did you check if knewfilemenutest still passes? > > > > I see that it's not testing the properties dialog case, I'm working on that. > > > > (Maybe it would have been easier to split this into 3 different commits & > > review requests, if

Re: Review Request 128490: Checksums tab: replace groupbox with vertical separator

2016-07-21 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128490/#review97737 --- Just a tiny note - that separator is horizontal, not

Re: Review Request 128471: [kio] Some fixes for KNewFileMenu.

2016-07-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128471/#review97725 --- Did you check if knewfilemenutest still passes? I see that

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 142 - Fixed!

2016-07-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/142/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 21:35:24 + Build duration: 4 min 32 sec CHANGE SET Revision

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 142 - Fixed!

2016-07-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/142/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 21:35:24 + Build duration: 4 min 32 sec CHANGE SET Revision

Re: Review Request 128458: KProtocolInfo: refill cache to find newly installed protocols

2016-07-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128458/ --- (Updated July 21, 2016, 9:35 p.m.) Status -- This change has been

Re: Review Request 128451: KNewFileMenu: fix creating symlinks with a relative target.

2016-07-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128451/ --- (Updated July 21, 2016, 9:35 p.m.) Status -- This change has been

Re: Review Request 128494: KPropertiesDialog: simplify button box usage, fix behavior on Esc

2016-07-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128494/ --- (Updated July 21, 2016, 9:35 p.m.) Status -- This change has been

Re: Review Request 128451: KNewFileMenu: fix creating symlinks with a relative target.

2016-07-21 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128451/#review97731 --- Ship it! Ship It! - Jeremy Whiting On July 21, 2016,

Re: Review Request 128413: Add clipboard buttons in the Checksums tab

2016-07-21 Thread Elvis Angelaccio
> On July 16, 2016, 10:30 a.m., Elvis Angelaccio wrote: > > Ping? > > > > (String freeze for frameworks is next Saturday, right?) > > Olivier Churlaud wrote: > I would say: replace the [copy] button by a select on click. and then > ship it Not sure about this. A button is

Re: Review Request 128490: Checksums tab: replace groupbox with vertical separator

2016-07-21 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128490/#review97729 --- If there are no objections by tomorrow, I'm going to push

Re: Review Request 128494: KPropertiesDialog: simplify button box usage, fix behavior on Esc

2016-07-21 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128494/#review97728 --- Ship it! Ship It! - Jeremy Whiting On July 21, 2016,

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 203 - Fixed!

2016-07-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/203/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 20:58:09 + Build duration: 7 min 34 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 203 - Fixed!

2016-07-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/203/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 20:58:09 + Build duration: 7 min 34 sec CHANGE SET No changes JUNIT RESULTS Name:

Review Request 128494: KPropertiesDialog: simplify button box usage, fix behavior on Esc

2016-07-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128494/ --- Review request for KDE Frameworks. Repository: kio Description ---

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 141 - Unstable!

2016-07-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/141/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 20:14:24 + Build duration: 16 min CHANGE SET Revision

Re: Review Request 128492: [kio] Minor typo in file ioslave

2016-07-21 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128492/ --- (Updated July 21, 2016, 8:14 p.m.) Status -- This change has been

Re: Review Request 128471: [kio] Some fixes for KNewFileMenu.

2016-07-21 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128471/ --- (Updated July 21, 2016, 4:30 p.m.) Review request for KDE Frameworks and

Re: Review Request 128492: [kio] Minor typo in file ioslave

2016-07-21 Thread Chinmoy Ranjan Pradhan
> On July 21, 2016, 6:44 a.m., David Faure wrote: > > Porting bug indeed, the kdelibs4 code said KDE::lstat(dest_orig, _orig) > > Good catch! > > > > (This shows a missing unittest though) commit it on my behalf :) - Chinmoy --- This

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

2016-07-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126131/ --- (Updated July 21, 2016, 1:37 p.m.) Review request for KDE Frameworks and

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 202 - Failure!

2016-07-21 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/202/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 12:13:41 + Build duration: 26 min CHANGE SET No changes

Re: Review Request 128488: Add a fallback method for query_qmake() when there's no Qt5 installation

2016-07-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128488/#review97710 --- modules/ECMQueryQmake.cmake (line 14)

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 80 - Fixed!

2016-07-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/80/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 10:58:22 + Build duration: 5 min 12 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 80 - Fixed!

2016-07-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/80/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 10:58:22 + Build duration: 5 min 12 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 90 - Unstable!

2016-07-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/90/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 10:44:43 + Build duration: 4 min 53 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 79 - Unstable!

2016-07-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/79/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 10:37:59 + Build duration: 4 min 58 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 89 - Unstable!

2016-07-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/89/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 10:32:24 + Build duration: 1 min 56 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 89 - Fixed!

2016-07-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/89/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 10:18:18 + Build duration: 2 min 46 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 89 - Fixed!

2016-07-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/89/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 10:18:18 + Build duration: 2 min 46 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 88 - Fixed!

2016-07-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/88/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 10:06:41 + Build duration: 4 min 52 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 88 - Fixed!

2016-07-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/88/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 10:06:41 + Build duration: 4 min 52 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kwidgetsaddons master kf5-qt5 » Linux,gcc - Build # 55 - Unstable!

2016-07-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwidgetsaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/55/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 09:12:15 + Build duration: 5 min 25 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 88 - Still Unstable!

2016-07-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/88/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 09:12:08 + Build duration: 6 min 31 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kemoticons master kf5-qt5 » Linux,gcc - Build # 59 - Fixed!

2016-07-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kemoticons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/59/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 09:12:08 + Build duration: 1 min 26 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kemoticons master kf5-qt5 » Linux,gcc - Build # 59 - Fixed!

2016-07-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kemoticons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/59/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 09:12:08 + Build duration: 1 min 26 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 87 - Still Unstable!

2016-07-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/87/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 09:09:15 + Build duration: 4 min 12 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kemoticons master kf5-qt5 » Linux,gcc - Build # 58 - Unstable!

2016-07-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kemoticons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/58/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 08:30:05 + Build duration: 1 min 23 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 87 - Unstable!

2016-07-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/87/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 08:29:09 + Build duration: 3 min 7 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 86 - Still Unstable!

2016-07-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/86/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jul 2016 08:29:01 + Build duration: 1 min 51 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 109 - Fixed!

2016-07-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/109/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Thu, 21 Jul 2016 08:28:41 + Build duration: 7 min 2 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 109 - Fixed!

2016-07-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/109/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Thu, 21 Jul 2016 08:28:41 + Build duration: 7 min 2 sec CHANGE SET

Re: Review Request 128492: [kio] Minor typo in file ioslave

2016-07-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128492/#review97688 --- Ship it! Porting bug indeed, the kdelibs4 code said