Re: Review Request 128150: [libkerfuffle] Ark application exits before job's finished

2016-08-10 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128150/ --- (Updated Авг. 11, 2016, 8:18 преди обяд) Status -- This change has

Re: Review Request 128652: Fix wording an -> one

2016-08-10 Thread Ragnar Thomsen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128652/#review98307 --- Ship it! Ship It! - Ragnar Thomsen On Aug. 10, 2016,

Review Request 128652: Fix wording an -> one

2016-08-10 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128652/ --- Review request for KDE Frameworks, KDE Utils, Ragnar Thomsen, and Valentin

Re: Review Request 127023: [KFileMetadata] Support Origin Email subject/sender/id

2016-08-10 Thread Kai Uwe Broulik
> On Aug. 10, 2016, 4:52 nachm., Kevin Funk wrote: > > I'm late to the party, but ...: This won't fly on Windows (at least under > > MSVC). I'm not usually compiling kfilemetadata.git on Windows, so I wasn't > > affected by this change thus didn't notice. > > > > Can we make the dependency on

Re: Review Request 127023: [KFileMetadata] Support Origin Email subject/sender/id

2016-08-10 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127023/#review98302 --- I'm late to the party, but ...: This won't fly on Windows

Re: Review Request 128650: [KBookmarks] Fix crash on app shutdown due to QRegExp(QStringLiteral())

2016-08-10 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128650/#review98301 --- Rather port to `QRegularExpression` right away? - Kevin

Review Request 128650: [KBookmarks] Fix crash on app shutdown due to QRegExp(QStringLiteral())

2016-08-10 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128650/ --- Review request for KDE Frameworks. Repository: kbookmarks Description

Re: Review Request 128635: [knewstuff] Fix build with Qt 5.8

2016-08-10 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128635/ --- (Updated Aug. 10, 2016, 12:17 p.m.) Status -- This change has been

Re: Review Request 128635: [knewstuff] Fix build with Qt 5.8

2016-08-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128635/#review98279 --- Ship it! Ship It! - David Faure On Aug. 9, 2016, 12:19

Re: Review Request 128640: Keep compatiable slot createApplet with Frameworks 5.24 *THIS NEEDS BACKPORTING TO 5.25*

2016-08-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128640/ --- (Updated Aug. 10, 2016, 9:37 a.m.) Status -- This change has been

Re: Review Request 128641: Fix argument type in QMetaObject invoke *NEEDS BACKPORTING TO 5.25*

2016-08-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128641/ --- (Updated Aug. 10, 2016, 9:37 a.m.) Status -- This change has been

Re: Review Request 128642: Fix blatant bug in code that was pushed unreviewed

2016-08-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128642/ --- (Updated Aug. 10, 2016, 9:37 a.m.) Status -- This change has been

Re: Review Request 128640: Keep compatiable slot createApplet with Frameworks 5.24 *THIS NEEDS BACKPORTING TO 5.25*

2016-08-10 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128640/#review98270 --- Ship it! aww, crap, didn't see that :/ thanks for

Re: Review Request 128642: Fix blatant bug in code that was pushed unreviewed

2016-08-10 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128642/#review98262 --- Can we change this to use QSignalBlocker, returning and