Re: Review Request 128951: Load user's avatar from AccountsService if it exists

2016-09-19 Thread Aleix Pol Gonzalez
> On Sept. 20, 2016, 12:03 a.m., Aleix Pol Gonzalez wrote: > > src/lib/CMakeLists.txt, line 13 > > > > > > Use CMAKE_INSTALL_FULL_LOCALSATEDIR instead of > > CMAKE_INSTALL_LOCALSTATEDIR. > > David Edmundson

Re: Review Request 128951: Load user's avatar from AccountsService if it exists

2016-09-19 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128951/#review99287 --- src/lib/CMakeLists.txt (line 13)

Review Request 128951: Load user's avatar from AccountsService if it exists

2016-09-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128951/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: Review Request 128944: Reduce temporary allocations in the DesktopFileParser

2016-09-19 Thread Alex Richardson
> On Sept. 19, 2016, 9:08 p.m., Alex Richardson wrote: > > src/lib/plugin/desktopfileparser.cpp, line 478 > > > > > > If I read this correctly we no longer handle leading/trailing spaces > > properly. Does the

Re: Review Request 128944: Reduce temporary allocations in the DesktopFileParser

2016-09-19 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128944/#review99278 --- Thanks for looking into this! When I wrote the code I

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

2016-09-19 Thread Evgeniy Sadovnik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128916/ --- (Updated Sept. 19, 2016, 6:14 p.m.) Review request for KDE Frameworks

Review Request 128944: Reduce temporary allocations in the DesktopFileParser

2016-09-19 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128944/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

[Differential] [Commented On] D2545: Cleanup KSharedUiServerProxy before qApp exists

2016-09-19 Thread mutlaqja (Jasem Mutlaq)
mutlaqja added a comment. Any update on this? BRANCH master REVISION DETAIL https://phabricator.kde.org/D2545 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, vonreth, dfaure Cc: mutlaqja, arrowdodger, #frameworks