Re: Review Request 129065: Fix frameworks compilation with Qt < 5.6

2016-09-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129065/ --- (Updated Sept. 29, 2016, 11:50 p.m.) Review request for KDE Frameworks

Re: Review Request 129065: Fix frameworks compilation with Qt < 5.6

2016-09-29 Thread David Edmundson
> On Sept. 29, 2016, 8:25 a.m., Marco Martin wrote: > > are you sure they are completely interchangeable? (would have to have an > > ifdef otherwise) they're not completely intechangable normally, but for this particular case it seems fine. I've just filled in the Testing Done propery. This

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

2016-09-29 Thread Evgeniy Sadovnik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128916/ --- (Updated Sept. 29, 2016, 3:41 p.m.) Status -- This change has been

[Differential] [Updated, 751 lines] D2854: New: ECMGenerateApiDox, for generating qch & tag files

2016-09-29 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 6993. kossebau added a comment. Add support for multiple qch in same build, example dir, MD mainpage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=6979=6993 BRANCH addGenerateApiDox REVISION DETAIL

Re: Review Request 129042: Replace all blocking calls when initializing properties by just one blocking call to get them all

2016-09-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129042/#review99667 --- Ship it! looks good to me - David Edmundson On Sept.

Review Request 129071: Use Gpgmepp from GpgME-1.7.0

2016-09-29 Thread Andreas Sturmlechner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129071/ --- Review request for KDE Frameworks. Repository: kwallet Description

Re: Review Request 129042: Replace all blocking calls when initializing properties by just one blocking call to get them all

2016-09-29 Thread Jan Grulich
> On Zář. 29, 2016, 10:22 dop., Aleix Pol Gonzalez wrote: > > Since I applied your patch, I get this output when starting plasma: > > > > ``` > > void NetworkManager::NetworkManagerPrivate::propertiesChanged(const > > QVariantMap &) Unhandled property "AllDevices" > > void

Re: Review Request 129042: Replace all blocking calls when initializing properties by just one blocking call to get them all

2016-09-29 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129042/#review99656 --- Since I applied your patch, I get this output when starting

Re: Review Request 128922: Remove invalid directory from index.theme

2016-09-29 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128922/ --- (Updated Sept. 29, 2016, 4:28 a.m.) Status -- This change has been

Re: Review Request 129065: Fix frameworks compilation with Qt < 5.6

2016-09-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129065/#review99654 --- are you sure they are completely interchangeable? (would

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 309 - Still Unstable!

2016-09-29 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/309/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 29 Sep 2016 07:17:55 + Build duration: 5 min 21 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 312 - Still Unstable!

2016-09-29 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/312/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 29 Sep 2016 07:17:55 + Build duration: 2 min 16 sec CHANGE SET Revision

Re: Review Request 129042: Replace all blocking calls when initializing properties by just one blocking call to get them all

2016-09-29 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129042/ --- (Updated Zář. 29, 2016, 7:10 dop.) Review request for KDE Frameworks,