Re: Review Request 129259: Fix the buffersize in certain situations.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129259/#review100282 --- src/ioslaves/file/file.cpp (line 790)

Re: Review Request 129251: Remove Shift+Del as secondary shortcut for Cut

> On Oct. 24, 2016, 7 a.m., Albert Astals Cid wrote: > > -1 it's an established shortcut for cut too. even > > https://en.wikipedia.org/wiki/Table_of_keyboard_shortcuts lists it in "Cut > > the selection and store it in the clipboard" > > Elvis Angelaccio wrote: > Ah, sorry I didn't know

Re: Review Request 128944: Reduce temporary allocations in the DesktopFileParser

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128944/ --- (Updated Oct. 26, 2016, 2:54 a.m.) Status -- This change has been

Re: Review Request 129257: [KNewStuff] Make it possible to query installed entries

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129257/ --- (Updated Oct. 26, 2016, 1:57 a.m.) Status -- This change has been

Re: Review Request 129261: Hide the "Show Menu Bar" action if all the menubars are native

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129261/#review100279 --- +1 pretty cool! - Aleix Pol Gonzalez On Oct. 26, 2016,

Review Request 129261: Hide the "Show Menu Bar" action if all the menubars are native

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129261/ --- Review request for KDE Frameworks. Repository: kconfigwidgets

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 246 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/246/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 25 Oct 2016 20:59:16 + Build duration: 21 min CHANGE SET Revision 9f6b69237c299cabff1427da54768624545e1943 by

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 246 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/246/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 25 Oct 2016 20:59:16 + Build duration: 21 min CHANGE SET Revision 9f6b69237c299cabff1427da54768624545e1943 by

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 248 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/248/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 25 Oct 2016 20:59:17 + Build duration: 20 min CHANGE SET Revision

Re: Review Request 129260: Add find module for QtPlatformSupport

> On Oct. 25, 2016, 1:31 p.m., Hrvoje Senjan wrote: > > find-modules/FindQt5PlatformSupport.cmake, line 75 > > > > > > Shouldn't this be rather Qt5PlatformSupport_PRIVATE_INCLUDE_DIRS, and > >

Re: Review Request 129252: Support non integer scale factors in KFileDelegate

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129252/ --- (Updated Oct. 25, 2016, 4:58 p.m.) Status -- This change has been

Re: Review Request 129253: Support non integer scale factors in kiconengine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129253/ --- (Updated Oct. 25, 2016, 8:55 p.m.) Status -- This change has been

Re: Review Request 128773: Revert "Don't use QQuickWidget::quickWindow() as it was added in Qt 5.5"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128773/ --- (Updated Oct. 25, 2016, 4:49 p.m.) Status -- This change has been

Re: Review Request 129251: Remove Shift+Del as secondary shortcut for Cut

> On Oct. 24, 2016, 11 a.m., Albert Astals Cid wrote: > > -1 it's an established shortcut for cut too. even > > https://en.wikipedia.org/wiki/Table_of_keyboard_shortcuts lists it in "Cut > > the selection and store it in the clipboard" > > Elvis Angelaccio wrote: > Ah, sorry I didn't know

Re: Review Request 128773: Revert "Don't use QQuickWidget::quickWindow() as it was added in Qt 5.5"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128773/#review100274 --- Ship it! Ship It! - David Edmundson On Oct. 25, 2016,

Re: Review Request 129251: Remove Shift+Del as secondary shortcut for Cut

> On okt 24, 2016, 11 a.m., Albert Astals Cid wrote: > > -1 it's an established shortcut for cut too. even > > https://en.wikipedia.org/wiki/Table_of_keyboard_shortcuts lists it in "Cut > > the selection and store it in the clipboard" > > Elvis Angelaccio wrote: > Ah, sorry I didn't know

Re: Review Request 129252: Support non integer scale factors in KFileDelegate

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129252/#review100271 --- Ship it! Tested and fixes the problem on my system

Re: ATTN: latest changes in breeze-icons make packaging untenable

On Tuesday, October 25, 2016 4:47:40 PM CEST Luca Beltrame wrote: > Hello, > > recent changes in breeze broke building in openSUSE's OBS: after a > discussion on IRC, it turned out that there were incorrect symlinks. > Adjustments were made in order to preserve space. However, while > harmless at

Re: ATTN: latest changes in breeze-icons make packaging untenable

Il giorno Tue, 25 Oct 2016 16:47:40 +0200 Luca Beltrame ha scritto: > If there's no consensus, I will revert these commits [1][2][3][4] in > breeze-icons by Sunday morning. After discussion on IRC, the commits were reverted. pgpkAXusssxMw.pgp Description: Firma digitale

Re: Review Request 129260: Add find module for QtPlatformSupport

> On Okt. 25, 2016, 11:31 vorm., Hrvoje Senjan wrote: > > find-modules/FindQt5PlatformSupport.cmake, line 75 > > > > > > Shouldn't this be rather Qt5PlatformSupport_PRIVATE_INCLUDE_DIRS, and > >

Re: Review Request 129259: Fix the buffersize in certain situations.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129259/ --- (Updated Oct. 25, 2016, 2:51 p.m.) Review request for KDE Frameworks.

Re: Review Request 128773: Revert "Don't use QQuickWidget::quickWindow() as it was added in Qt 5.5"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128773/ --- (Updated Oct. 25, 2016, 8:19 p.m.) Review request for KDE Frameworks.

ATTN: latest changes in breeze-icons make packaging untenable

Hello, recent changes in breeze broke building in openSUSE's OBS: after a discussion on IRC, it turned out that there were incorrect symlinks. Adjustments were made in order to preserve space. However, while harmless at first (I didn't notice earlier, and CI was green) these changes *break*

Re: Review Request 129251: Remove Shift+Del as secondary shortcut for Cut

> On Okt. 24, 2016, 11 vorm., Albert Astals Cid wrote: > > -1 it's an established shortcut for cut too. even > > https://en.wikipedia.org/wiki/Table_of_keyboard_shortcuts lists it in "Cut > > the selection and store it in the clipboard" > > Elvis Angelaccio wrote: > Ah, sorry I didn't

Re: Review Request 129260: Add find module for QtPlatformSupport

> On Oct. 25, 2016, 1:31 p.m., Hrvoje Senjan wrote: > > find-modules/FindQt5PlatformSupport.cmake, line 75 > > > > > > Shouldn't this be rather Qt5PlatformSupport_PRIVATE_INCLUDE_DIRS, and > >

Re: Review Request 129251: Remove Shift+Del as secondary shortcut for Cut

> On Ott. 24, 2016, 1 p.m., Albert Astals Cid wrote: > > -1 it's an established shortcut for cut too. even > > https://en.wikipedia.org/wiki/Table_of_keyboard_shortcuts lists it in "Cut > > the selection and store it in the clipboard" > > Elvis Angelaccio wrote: > Ah, sorry I didn't know

Re: Review Request 129251: Remove Shift+Del as secondary shortcut for Cut

> On Oct. 24, 2016, 11 a.m., Albert Astals Cid wrote: > > -1 it's an established shortcut for cut too. even > > https://en.wikipedia.org/wiki/Table_of_keyboard_shortcuts lists it in "Cut > > the selection and store it in the clipboard" > > Elvis Angelaccio wrote: > Ah, sorry I didn't know

Re: Review Request 129260: Add find module for QtPlatformSupport

> On Oct. 25, 2016, 11:37 a.m., Aleix Pol Gonzalez wrote: > > Shouldn't this be in Qt? What am I missing? > > Martin Gräßlin wrote: > Yes it should, but it isn't. No idea why not. > > Hrvoje Senjan wrote: > The module is internal, so it intentionally doesn't install any cmake > files.

Re: Review Request 129260: Add find module for QtPlatformSupport

> On Oct. 25, 2016, 1:37 p.m., Aleix Pol Gonzalez wrote: > > Shouldn't this be in Qt? What am I missing? > > Martin Gräßlin wrote: > Yes it should, but it isn't. No idea why not. The module is internal, so it intentionally doesn't install any cmake files. - Hrvoje

Re: Review Request 129251: Remove Shift+Del as secondary shortcut for Cut

> On Oct. 24, 2016, 11 a.m., Albert Astals Cid wrote: > > -1 it's an established shortcut for cut too. even > > https://en.wikipedia.org/wiki/Table_of_keyboard_shortcuts lists it in "Cut > > the selection and store it in the clipboard" > > Elvis Angelaccio wrote: > Ah, sorry I didn't know

Re: Review Request 129251: Remove Shift+Del as secondary shortcut for Cut

> On Okt. 24, 2016, 11 vorm., Albert Astals Cid wrote: > > -1 it's an established shortcut for cut too. even > > https://en.wikipedia.org/wiki/Table_of_keyboard_shortcuts lists it in "Cut > > the selection and store it in the clipboard" > > Elvis Angelaccio wrote: > Ah, sorry I didn't

Re: Review Request 129251: Remove Shift+Del as secondary shortcut for Cut

> On okt 24, 2016, 11 a.m., Albert Astals Cid wrote: > > -1 it's an established shortcut for cut too. even > > https://en.wikipedia.org/wiki/Table_of_keyboard_shortcuts lists it in "Cut > > the selection and store it in the clipboard" > > Elvis Angelaccio wrote: > Ah, sorry I didn't know

Re: Review Request 129260: Add find module for QtPlatformSupport

> On Okt. 25, 2016, 11:31 vorm., Hrvoje Senjan wrote: > > find-modules/FindQt5PlatformSupport.cmake, line 75 > > > > > > Shouldn't this be rather Qt5PlatformSupport_PRIVATE_INCLUDE_DIRS, and > >

Re: Review Request 129260: Add find module for QtPlatformSupport

> On Oct. 25, 2016, 1:37 p.m., Aleix Pol Gonzalez wrote: > > Shouldn't this be in Qt? What am I missing? Yes it should, but it isn't. No idea why not. - Martin --- This is an automatically generated e-mail. To reply, visit:

Review Request 129259: Fix the buffersize in certain situations.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129259/ --- Review request for KDE Frameworks. Bugs: 369275

Re: Review Request 129260: Add find module for QtPlatformSupport

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129260/#review100257 --- Shouldn't this be in Qt? What am I missing? - Aleix Pol

Re: Review Request 129260: Add find module for QtPlatformSupport

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129260/#review100256 --- find-modules/FindQt5PlatformSupport.cmake (line 75)

Re: Review Request 129260: Add find module for QtPlatformSupport

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129260/#review100255 --- +1 - Martin Gräßlin On Oct. 25, 2016, 1:21 p.m., Kai Uwe

Review Request 129260: Add find module for QtPlatformSupport

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129260/ --- Review request for KDE Frameworks, Alex Merry and Martin Gräßlin.

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 343 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/343/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 25 Oct 2016 09:37:43 + Build duration: 1 min 52 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 344 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/344/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 25 Oct 2016 10:02:45 + Build duration: 5 min 24 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 344 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/344/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 25 Oct 2016 10:02:45 + Build duration: 5 min 24 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 346 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/346/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 25 Oct 2016 10:02:45 + Build duration: 5 min 7 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 346 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/346/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 25 Oct 2016 10:02:45 + Build duration: 5 min 7 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 345 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/345/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 25 Oct 2016 09:37:43 + Build duration: 25 sec CHANGE SET Revision