Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

> On Ноев. 21, 2016, 10:34 преди обяд, David Faure wrote: > > filenamesearch/kded/filenamesearchmodule.cpp, line 84 > > > > > > Well, if dirUrl looks like > > "filenamesearch:?search=file=file:///path/to/file"

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Ноев. 16, 2016, 8 след обяд, Anthony Fieroni wrote: > > Ping, i'm still using it without issues, it isn't good enough? > > Anthony Fieroni wrote: > Ping? Any problems with to go in ? - Anthony --- This is an automatically

Re: Review Request 129281: [Konsole] Render text at primary font's baseline

> On Nov. 9, 2016, 1:22 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > looks good to me, but I think hindenburg should ack it (might want to add > > him to reviewers) > > Christoph Feck wrote: > Pretty sure "konsole" reviewers group includes the maintainer, but I > would actually

[Differential] [Updated] D3386: Generate an instance with KSharedConfig::Ptr for singleton and arg

ltoscano set the repository for this revision to R237 KConfig. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D3386 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #frameworks, dfaure, mdawson Cc: aacid, apol

[Differential] [Commented On] D3386: Generate an instance with KSharedConfig::Ptr for singleton and arg

ltoscano added a comment. Created and added the KConfig repository. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D3386 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #frameworks, dfaure, mdawson Cc: ltoscano,

[Differential] [Updated] D3544: Small optimization

ltoscano set the repository for this revision to R235 Attica. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D3544 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #frameworks, leinir, whiting Cc: ltoscano, aacid

[Differential] [Commented On] D3544: Small optimization

ltoscano added a comment. Not all projects are defined here. Please ping the community admin if you want to send a patch for a repository which is not tracked here. Btw, this seems to be attica, I'm going to enable it. REVISION DETAIL https://phabricator.kde.org/D3544 EMAIL PREFERENCES

[Differential] [Commented On] D3386: Generate an instance with KSharedConfig::Ptr for singleton and arg

aacid added a comment. Is this another patch that doesn't say to which repository it applies? Or am i just too stupid to find it in phabricator? REVISION DETAIL https://phabricator.kde.org/D3386 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Commented On] D3544: Small optimization

aacid added a comment. Can we please stop having patches on phabricator that don't reference the repository they are supposed to be applied to? REVISION DETAIL https://phabricator.kde.org/D3544 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol,

[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

shumski added inline comments. INLINE COMMENTS > kossebau wrote in KDEInstallDirs.cmake:534 > Fear I am still missing what you mean. So let's go explicitely, here is what > I understand to happen: > > There are six different cases when using this macro and on the first > invocation of cmake,

[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

kossebau added inline comments. INLINE COMMENTS > shumski wrote in KDEInstallDirs.cmake:534 > It is :) But with this latest revision it is not when that var is off =) I'm > saying that for both cases it should happen. Fear I am still missing what you mean. So let's go explicitely, here is what

[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

shumski added inline comments. INLINE COMMENTS > kossebau wrote in KDEInstallDirs.cmake:534 > But isn't this free recognition happening via KDE_INSTALL_USE_QT_SYS_PATHS as > well? > At least this is how I understand >

[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

kossebau added inline comments. INLINE COMMENTS > shumski wrote in KDEInstallDirs.cmake:534 > Right. But if you install a framework to same prefix as Qt, you get free > recognition of plugins, qml imports, etc... This is valid for both /usr and > custom prefix installs. > I guess what i want

[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

kossebau added inline comments. INLINE COMMENTS > shumski wrote in KDEInstallDirs.cmake:534 > I mean, addition of qch subdir is 'your' invention here. > If Frameworks were to use only qmake build-system, i'm sure qch files would > end up in QT_INSTALL_DOCS directory. > I.e. for

[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

kossebau added inline comments. INLINE COMMENTS > shumski wrote in KDEInstallDirs.cmake:534 > I think e.g. QMLDIR, PLUGINDIR, ECM_MKSPECS_INSTALL_DIR, etc. are vanilla > Qt's. QCH files are thus installed straight into QT_INSTALL_DOCS dir AFAICS > ... Not sure what you mean, please point out

[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

shumski added inline comments. INLINE COMMENTS > kossebau wrote in KDEInstallDirs.cmake:534 > Not sure what you mean, please point out the issue you see here with more > details :) > > The plan here is: > if KDE_INSTALL_USE_QT_SYS_PATHS is set, install QCH files to QT_INSTALL_DOCS, > if not,

[Differential] [Updated, 1,080 lines] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

kossebau updated this revision to Diff 8639. kossebau added a comment. adapt also documentation to doc/QCH CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=8635=8639 BRANCH addApiDox REVISION DETAIL https://phabricator.kde.org/D2854 AFFECTED FILES

[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

shumski added inline comments. INLINE COMMENTS > KDEInstallDirs.cmake:534 > +else() > +_define_relative(QTQCHDIR DATAROOTDIR "doc/QCH" > +"documentation bundles in QCH format for Qt-extending libraries") I think e.g. QMLDIR, PLUGINDIR, ECM_MKSPECS_INSTALL_DIR, etc. are vanilla Qt's.

[Differential] [Updated, 1,080 lines] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

kossebau updated this revision to Diff 8635. kossebau added a comment. Use rather subfolder doc/QCH for installing QCH files CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=8586=8635 BRANCH addApiDox REVISION DETAIL https://phabricator.kde.org/D2854 AFFECTED FILES

[Differential] [Commented On] D3530: Import plasma-workspace kioslaves

aacid added a comment. In https://phabricator.kde.org/D3530#66090, @mart wrote: > In https://phabricator.kde.org/D3530#65734, @aacid wrote: > > > > Dolphin in other environments currently gives a big error until you install plasma-workspace, which defeats the point of the split. >

[Differential] [Commented On] D3530: Import plasma-workspace kioslaves

mart added a comment. In https://phabricator.kde.org/D3530#65734, @aacid wrote: > > Dolphin in other environments currently gives a big error until you install plasma-workspace, which defeats the point of the split. > > Maybe Dolphin needs to be patched not to assume remote:/ will

Review Request 129590: KAuth: Make D-Bus dependency optional.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129590/ --- Review request for KDE Frameworks and kdewin. Repository: kauth

[Differential] [Updated] D3386: Generate an instance with KSharedConfig::Ptr for singleton and arg

graesslin added reviewers: dfaure, mdawson. REVISION DETAIL https://phabricator.kde.org/D3386 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #frameworks, dfaure, mdawson Cc: apol