Re: Review Request 129540: DropJob: emit started copy job after creation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129540/ --- (Updated Dec. 4, 2016, 7:22 p.m.) Review request for KDE Frameworks.

Re: Review Request 129540: DropJob: emit started copy job after creation

> On Dec. 4, 2016, 5:50 p.m., David Faure wrote: > > I would prefer the subjob to remain an implementation detail. Just like so > > many other KIO jobs which use other jobs internally. > > > > Instead this code should connect the signals from the subjob to the DropJob > > signals. Much like

[Differential] [Commented On] D3530: Import plasma-workspace kioslaves

dfaure added a comment. In https://phabricator.kde.org/D3530#65873, @mart wrote: > desktop:/ should be probably conditionally built only on Linux(but in there is quite core), while, may make sense to actually kill applications:/ altogether?? I have no doubt it seems "core on

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

> On Nov. 21, 2016, 8:34 a.m., David Faure wrote: > > filenamesearch/kded/filenamesearchmodule.cpp, line 84 > > > > > > Well, if dirUrl looks like > > "filenamesearch:?search=file=file:///path/to/file" then

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129394/#review101273 --- Sure, ship the RAM-usage fix, even if we still need to

Re: Review Request 129540: DropJob: emit started copy job after creation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129540/#review101272 --- I would prefer the subjob to remain an implementation

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

> On Ноев. 21, 2016, 10:34 преди обяд, David Faure wrote: > > filenamesearch/kded/filenamesearchmodule.cpp, line 84 > > > > > > Well, if dirUrl looks like > > "filenamesearch:?search=file=file:///path/to/file"

Re: Review Request 129611: Make Gpgme a required dependency if we build Gpgme interface.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129611/#review101269 --- Is it really a possible scenario that Gpgmepp is installed,

Re: Review Request 129609: utils.js: Escape backslash in i18n string

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129609/#review101268 --- Ship it! I guess this is fine. Please commit. - Dominik

Re: Review Request 129613: Revert "If Gpgmepp is not found, try to use KF5Gpgmepp"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129613/ --- (Updated Dec. 4, 2016, 12:33 p.m.) Review request for KDE Frameworks and

Review Request 129613: Revert "If Gpgmepp is not found, try to use KF5Gpgmepp"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129613/ --- Review request for KDE Frameworks and David Faure. Repository: kwallet

Re: Review Request 129341: [kwallet] boost::shared_ptr -> std::shared_ptr

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129341/ --- (Updated Dec. 4, 2016, 6:55 a.m.) Status -- This change has been

Re: Review Request 129341: [kwallet] boost::shared_ptr -> std::shared_ptr

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129341/ --- (Updated Dec. 4, 2016, 11:55 a.m.) Status -- This change has been

Jenkins-kde-ci: kmediaplayer master kf5-qt5 » Linux,gcc - Build # 302 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kmediaplayer%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/302/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 04 Dec 2016 10:31:32 + Build duration: 1 min 19 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kmediaplayer master kf5-qt5 » Linux,gcc - Build # 302 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kmediaplayer%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/302/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 04 Dec 2016 10:31:32 + Build duration: 1 min 19 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 296 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/296/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 04 Dec 2016 09:58:58 + Build duration: 14 min CHANGE SET Revision 84d5c6c71d2f0e37ef4cc9c4349531ba088e2ae6 by

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 301 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/301/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 04 Dec 2016 09:56:43 + Build duration: 7 min 38 sec CHANGE SET Revision

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 301 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/301/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 04 Dec 2016 09:56:43 + Build duration: 7 min 38 sec CHANGE SET Revision

Jenkins-kde-ci: kmediaplayer master kf5-qt5 » Linux,gcc - Build # 301 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kmediaplayer%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/301/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 04 Dec 2016 09:58:57 + Build duration: 3 min 46 sec CHANGE SET No changes

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 295 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/295/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 04 Dec 2016 09:42:36 + Build duration: 8 min 33 sec CHANGE SET Revision 91fd82cc595a07549ef9da85079415497a7780ae

Re: Problems managing KIO::Jobs

On lundi 14 novembre 2016 15:23:01 CET A. Bikadorov wrote: > 1. Creating and immediately suspending a job does not work as expected. E.g. > after > > KIO::Job job = KIO::copy(urls, dest, flags); > > bool result = job->suspend(); // returns true > > bool result2 = job->isSuspended(); // returns

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 300 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/300/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 04 Dec 2016 09:42:36 + Build duration: 7 min 12 sec CHANGE SET Revision

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 294 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/294/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 04 Dec 2016 09:29:21 + Build duration: 6 min 53 sec CHANGE SET Revision d31c594e7bb7a3cf83c4dff68b9263f7769deed0

Re: Review Request 129396: Allow to read X-KDE-RunOnDiscreteGpu property from desktop file + take this option into account when starting service using KToolInvocation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129396/#review101265 --- Fix it, then Ship it! src/services/kservice.h (line

Re: Review Request 129341: [kwallet] boost::shared_ptr -> std::shared_ptr

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129341/#review101264 --- Ship it! Looks OK. It would have been better to make