[Differential] [Commented On] D2545: Cleanup KSharedUiServerProxy before qApp exists

2016-12-19 Thread kfunk (Kevin Funk)
kfunk added a comment. In https://phabricator.kde.org/D2545#69298, @thiago wrote: > In https://phabricator.kde.org/D2545#69187, @kfunk wrote: > > > In https://phabricator.kde.org/D2545#69091, @thiago wrote: > > > > > There doesn't seem to be a way of doing some clean up before the

Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 338 - Fixed!

2016-12-19 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/338/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 19 Dec 2016 21:01:38 + Build duration: 1 min 4 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 338 - Fixed!

2016-12-19 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/338/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 19 Dec 2016 21:01:38 + Build duration: 1 min 4 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 315 - Unstable!

2016-12-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/315/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 19 Dec 2016 20:18:40 + Build duration: 28 min CHANGE SET Revision 82b5a8dd5f3dbcca6815ef32c39255c86898 by

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 319 - Still Unstable!

2016-12-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/319/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 19 Dec 2016 20:52:19 + Build duration: 7 min 13 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 384 - Still Unstable!

2016-12-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/384/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 19 Dec 2016 19:46:33 + Build duration: 3 min 48 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 101 - Fixed!

2016-12-19 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/101/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 19 Dec 2016 19:31:56 + Build duration: 1 min 52 sec CHANGE SET No

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 101 - Fixed!

2016-12-19 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/101/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 19 Dec 2016 19:31:56 + Build duration: 1 min 52 sec CHANGE SET No

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 387 - Still Unstable!

2016-12-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/387/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 19 Dec 2016 19:25:49 + Build duration: 3 min 1 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 383 - Still Unstable!

2016-12-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/383/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 19 Dec 2016 19:09:08 + Build duration: 14 min CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 100 - Unstable!

2016-12-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/100/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 19 Dec 2016 19:09:08 + Build duration: 1 min 47 sec CHANGE SET No

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 386 - Still Unstable!

2016-12-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/386/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 19 Dec 2016 19:04:04 + Build duration: 14 min CHANGE SET No changes JUNIT RESULTS Name:

[Differential] [Closed] D3646: Ignore host libs/includes/cmakeconfig files in Android toolchain

2016-12-19 Thread kossebau (Friedrich W. H. Kossebau)
This revision was automatically updated to reflect the committed changes. Closed by commit R240:5f17bf2c0c65: Ignore host libs/includes/cmakeconfig files in Android toolchain (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3646?vs=9166=9180#toc REPOSITORY R240

[Differential] [Closed] D3732: Document usage of gnustl_shared with Android toolchain

2016-12-19 Thread kossebau (Friedrich W. H. Kossebau)
This revision was automatically updated to reflect the committed changes. kossebau marked an inline comment as done. Closed by commit R240:957e00fe3d32: Document usage of gnustl_shared with Android toolchain (authored by kossebau). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

[Differential] [Updated] D3646: Ignore host libs/includes/cmakeconfig files in Android toolchain

2016-12-19 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated the summary for this revision. REPOSITORY R240 Extra CMake Modules BRANCH avoidHostLibsIncludesinAndroidToolchain REVISION DETAIL https://phabricator.kde.org/D3646 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau,

[Differential] [Accepted] D3732: Document usage of gnustl_shared with Android toolchain

2016-12-19 Thread apol (Aleix Pol Gonzalez)
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH addCommentAboutGNUSTLCheck REVISION DETAIL https://phabricator.kde.org/D3732 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 267 - Unstable!

2016-12-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/267/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 19 Dec 2016 17:28:57 + Build duration: 3 min 10 sec CHANGE SET

[Differential] [Request, 7 lines] D3733: Force colored warnings in ninja's output

2016-12-19 Thread elvisangelaccio (Elvis Angelaccio)
elvisangelaccio created this revision. elvisangelaccio added a reviewer: Frameworks. REVISION SUMMARY Colored compiler warnings in ninja output only work with the `-fdiagnostics-color=always` flag. See https://github.com/ninja-build/ninja/issues/814 for a rationale. This patch adds

Re: Review Request 129628: knewstuff - install missing headers

2016-12-19 Thread Dan Leinir Turthra Jensen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129628/#review101508 --- i'm afraid this patch fixes the wrong problem - but thank

[Differential] [Updated, 8 lines] D3732: Document usage of gnustl_shared with Android toolchain

2016-12-19 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 9168. kossebau added a comment. - Added explanation for hardcoding gnustl_shared for now - Removed comment as proposed REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3732?vs=9167=9168 BRANCH

[Differential] [Accepted] D3646: Ignore host libs/includes/cmakeconfig files in Android toolchain

2016-12-19 Thread apol (Aleix Pol Gonzalez)
apol accepted this revision. REPOSITORY R240 Extra CMake Modules BRANCH avoidHostLibsIncludesinAndroidToolchain REVISION DETAIL https://phabricator.kde.org/D3646 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, #frameworks, #gcompris,

[Differential] [Commented On] D3732: Document usage of gnustl_shared with Android toolchain

2016-12-19 Thread apol (Aleix Pol Gonzalez)
apol added inline comments. INLINE COMMENTS > Android.cmake:160 > +# See https://developer.android.com/ndk/guides/cpp-support.html > +# TODO: reason for choosing gnustl_shared over the other options? > find_library(GNUSTL_SHARED gnustl_shared) when I started working on Android it was the only

[Differential] [Commented On] D3732: Document usage of gnustl_shared with Android toolchain

2016-12-19 Thread kossebau (Friedrich W. H. Kossebau)
kossebau added a comment. http://doc.qt.io/qbs/android-ndk-module.html allows to control which helper runtime to use, so hardcoding gnustl_shared in the ECM toolchain could have been done for a certain reason or perhaps just was done once to get started, but never revisited? REPOSITORY

[Differential] [Commented On] D3646: Ignore host libs/includes/cmakeconfig files in Android toolchain

2016-12-19 Thread kossebau (Friedrich W. H. Kossebau)
kossebau added inline comments. INLINE COMMENTS > apol wrote in Android.cmake:188 > It's where the STL lives: > https://developer.android.com/ndk/guides/cpp-support.html Moved to separate https://phabricator.kde.org/D3732 REPOSITORY R240 Extra CMake Modules BRANCH

[Differential] [Request, 7 lines] D3732: Document usage of gnustl_shared with Android toolchain

2016-12-19 Thread kossebau (Friedrich W. H. Kossebau)
kossebau created this revision. kossebau added reviewers: Frameworks, apol, cordlandwehr. REPOSITORY R240 Extra CMake Modules BRANCH addCommentAboutGNUSTLCheck REVISION DETAIL https://phabricator.kde.org/D3732 AFFECTED FILES toolchain/Android.cmake EMAIL PREFERENCES

[Differential] [Updated, 50 lines] D3646: Ignore host libs/includes/cmakeconfig files in Android toolchain

2016-12-19 Thread kossebau (Friedrich W. H. Kossebau)
kossebau updated this revision to Diff 9166. kossebau added a comment. - Rename ECM_ANDROID_ROOT_PATH -> ECM_ADDITIONAL_FIND_ROOT_PATH - drop gnustl_shared documenting todo for a separate review REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3691: Update QMake syntax highlighting file

2016-12-19 Thread kfunk (Kevin Funk)
This revision was automatically updated to reflect the committed changes. Closed by commit R216:c3fc1271d6ad: Update QMake syntax highlighting file (authored by kfunk). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3691?vs=9048=9163#toc REPOSITORY R216 Syntax Highlighting CHANGES

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 265 - Fixed!

2016-12-19 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/265/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 19 Dec 2016 12:49:44 + Build duration: 11 min CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 265 - Fixed!

2016-12-19 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/265/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 19 Dec 2016 12:49:44 + Build duration: 11 min CHANGE SET Revision

Re: Review Request 129642: Introduce org.kde.kconfig QML import with KAuthorized

2016-12-19 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129642/ --- (Updated Dec. 19, 2016, 12:54 p.m.) Status -- This change has been

[Differential] [Commented On] D3646: Ignore host libs/includes/cmakeconfig files in Android toolchain

2016-12-19 Thread apol (Aleix Pol Gonzalez)
apol added inline comments. INLINE COMMENTS > kossebau wrote in Android.cmake:188 > So gnustl_shared is required by Qt for Android? Any link for backing this up > which I could use to please curious people? I could not find anything when I > quickly searched, so this here seemed just some

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 264 - Unstable!

2016-12-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/264/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 19 Dec 2016 11:24:54 + Build duration: 11 min CHANGE SET Revision

[Differential] [Accepted] D3691: Update QMake syntax highlighting file

2016-12-19 Thread vkrause (Volker Krause)
vkrause accepted this revision. vkrause added a reviewer: vkrause. vkrause added a comment. This revision is now accepted and ready to land. Please also add a license header to the generator script. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL

[Differential] [Commented On] D3691: Update QMake syntax highlighting file

2016-12-19 Thread kfunk (Kevin Funk)
kfunk added a comment. Bump REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D3691 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

2016-12-19 Thread David Faure
> On Dec. 10, 2016, 4:36 a.m., Anthony Fieroni wrote: > > filenamesearch/kio_filenamesearch.cpp, line 113 > > > > > > Or we must keep KIO::UDSEntry::UDS_URL in new patch ? > > Anthony Fieroni wrote: >