Re: Review Request 129648: New widget: tooltip that contains another widget

2016-12-28 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129648/#review101637 --- src/ktooltipwidget.cpp (line 98)

Re: Review Request 129716: Improve installation process of KPackage bundles

2016-12-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129716/ --- (Updated Dec. 29, 2016, 12:25 a.m.) Status -- This change has been

Re: Review Request 129261: Hide the "Show Menu Bar" action if all the menubars are native

2016-12-28 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129261/ --- (Updated Dec. 28, 2016, 10:47 p.m.) Review request for KDE Frameworks.

[Differential] [Commented On] D3548: Add begin/end insert/remove columns to RearrangeColumns

2016-12-28 Thread ltoscano (Luigi Toscano)
ltoscano added a comment. As a general suggestion, if this fixes the bug, please add the usual line BUG: xyz and please add a bit more of explanation in the description so that it's clear even without reading the bug. (I'm not qualified to comment on the content of the review itself).

[Differential] [Updated] D3548: Add begin/end insert/remove columns to RearrangeColumns

2016-12-28 Thread ltoscano (Luigi Toscano)
ltoscano added a reviewer: Frameworks. ltoscano set the repository for this revision to R275 KItemModels. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D3548 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: lepagevalleeemmanuel,

Re: Review Request 129709: Fix checking for valid date entered

2016-12-28 Thread David Jarvie
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129709/ --- (Updated Dec. 28, 2016, 5:49 p.m.) Review request for KDE Frameworks and

Re: Review Request 129716: Improve installation process of KPackage bundles

2016-12-28 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129716/#review101629 --- Ship it! Ship It! - Marco Martin On Dec. 28, 2016,

Re: Review Request 129715: KPackage KNSHandler: Improve

2016-12-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129715/ --- (Updated Dec. 28, 2016, 5:35 p.m.) Review request for KDE Frameworks.

Review Request 129716: Improve installation process of KPackage bundles

2016-12-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129716/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage

Review Request 129715: KPackage KNSHandler: Improve

2016-12-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129715/ --- Review request for KDE Frameworks. Repository: frameworkintegration

Review Request 129713: Only try to open the file if it's not empty

2016-12-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129713/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository:

[Differential] [Commented On] D3830: Add a new FindGperf module

2016-12-28 Thread pino (Pino Toscano)
pino added a comment. Cool -- thanks guys for the feedback on FreeBSD/Mac/Windows! REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3830 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: pino, #frameworks, #buildsystem,

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 326 - Unstable!

2016-12-28 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/326/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 28 Dec 2016 12:52:04 + Build duration: 8 min 8 sec CHANGE SET Revision ccb616e73292f97b3b22fea3c42fda24b5aff08e

[Differential] [Commented On] D3830: Add a new FindGperf module

2016-12-28 Thread kfunk (Kevin Funk)
kfunk added a comment. Windows: We have working gperf recipe in Craft => we're fine. QtWebKit already had an (optional) dependency on gperf. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3830 EMAIL PREFERENCES

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 329 - Fixed!

2016-12-28 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/329/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 28 Dec 2016 12:33:47 + Build duration: 18 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 329 - Fixed!

2016-12-28 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/329/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 28 Dec 2016 12:33:47 + Build duration: 18 min CHANGE SET No changes JUNIT RESULTS Name: (root)

[Differential] [Commented On] D3830: Add a new FindGperf module

2016-12-28 Thread René J.V. Bertin
rjvbb added a comment. In https://phabricator.kde.org/D3830#71722, @pino wrote: > Windows and Mac people: at least from a quick glance, GNU gperf should be already available on Windows and Mac I can only speak for 10.9 but indeed, gperf is available in /usr/bin . REPOSITORY

Re: Review Request 129706: Don't focus progress windows

2016-12-28 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129706/ --- (Updated Dec. 28, 2016, 7:51 a.m.) Status -- This change has been

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 163 - Still Unstable!

2016-12-28 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/163/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 28 Dec 2016 11:29:47 + Build duration: 1 min 50 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kjs master stable-kf5-qt5 » Linux,gcc - Build # 155 - Fixed!

2016-12-28 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kjs%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/155/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 28 Dec 2016 11:20:05 + Build duration: 6 min 12 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kjs master stable-kf5-qt5 » Linux,gcc - Build # 155 - Fixed!

2016-12-28 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kjs%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/155/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 28 Dec 2016 11:20:05 + Build duration: 6 min 12 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 166 - Fixed!

2016-12-28 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/166/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 28 Dec 2016 11:16:36 + Build duration: 5 min 1 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 166 - Fixed!

2016-12-28 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/166/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 28 Dec 2016 11:16:36 + Build duration: 5 min 1 sec CHANGE SET No changes JUNIT RESULTS Name:

Re: Review Request 129710: KConfigDialogManager: drop kdelibs3 classes

2016-12-28 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129710/ --- (Updated Dec. 28, 2016, 11:54 a.m.) Status -- This change has been

Re: Review Request 129659: KConfigDialogManager: improve documentation for custom widgets

2016-12-28 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129659/ --- (Updated Dec. 28, 2016, 1:54 p.m.) Status -- This change has been

Jenkins-kde-ci: kjs master kf5-qt5 » Linux,gcc - Build # 152 - Fixed!

2016-12-28 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kjs%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/152/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 28 Dec 2016 11:13:30 + Build duration: 5 min 4 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

[Differential] [Commented On] D3830: Add a new FindGperf module

2016-12-28 Thread adridg (Adriaan de Groot)
adridg added a comment. gperf is also available in the base system for FreeBSD, so this doesn't have any effects on the build there, either. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3830 EMAIL PREFERENCES

Re: Review Request 129710: KConfigDialogManager: drop kdelibs3 classes

2016-12-28 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129710/#review101628 --- Ship it! Ship It! - Albert Astals Cid On Dec. 28,

Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 132 - Fixed!

2016-12-28 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/132/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 28 Dec 2016 11:05:48 + Build duration: 2 min 23 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 132 - Fixed!

2016-12-28 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/132/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 28 Dec 2016 11:05:48 + Build duration: 2 min 23 sec CHANGE SET No changes JUNIT RESULTS

Re: Review Request 129648: New widget: tooltip that contains another widget

2016-12-28 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129648/#review101627 --- src/ktooltipwidget.cpp (lines 139 - 141)

Jenkins-kde-ci: kcoreaddons master kf5-qt5 » Linux,gcc - Build # 127 - Fixed!

2016-12-28 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/127/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 28 Dec 2016 11:04:22 + Build duration: 5 min 44 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kcoreaddons master kf5-qt5 » Linux,gcc - Build # 127 - Fixed!

2016-12-28 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/127/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 28 Dec 2016 11:04:22 + Build duration: 5 min 44 sec CHANGE SET No changes JUNIT RESULTS Name:

Review Request 129710: KConfigDialogManager: drop kdelibs3 classes

2016-12-28 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129710/ --- Review request for KDE Frameworks, Albert Astals Cid and Aleix Pol

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-28 Thread Elvis Angelaccio
> On Dec. 27, 2016, 9:16 p.m., Albert Astals Cid wrote: > > -1 Don't break what is not broken. > > > > First thing i check "KButtonGroup", is already wrong to be removed. > > Elvis Angelaccio wrote: > Why? Isn't it deprecated? >

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

2016-12-28 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129658/ --- (Updated Dec. 28, 2016, 11:05 a.m.) Status -- This change has been

[Differential] [Commented On] D3830: Add a new FindGperf module

2016-12-28 Thread pino (Pino Toscano)
pino added a comment. Windows and Mac people: at least from a quick glance, GNU gperf should be already available on Windows and Mac; can you please confirm the new (build time only) dependency could be acceptable? REPOSITORY R240 Extra CMake Modules REVISION DETAIL

[Differential] [Updated] D3830: Add a new FindGperf module

2016-12-28 Thread pino (Pino Toscano)
pino added reviewers: Windows, kde-mac. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3830 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: pino, #frameworks, #kde_buildsystem, #windows, kde-mac

[Differential] [Updated] D3830: Add a new FindGperf module

2016-12-28 Thread ltoscano (Luigi Toscano)
ltoscano added a reviewer: KDE Buildsystem. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3830 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: pino, #frameworks, #kde_buildsystem

[Differential] [Request, 126 lines] D3830: Add a new FindGperf module

2016-12-28 Thread pino (Pino Toscano)
pino created this revision. pino added a reviewer: Frameworks. REVISION SUMMARY Add a simple module to look for GNU gperf at build time, providing an helper macro for adding generations to a list of sources. gperf will be used to generate the C/C++ sources at build time, instead of