Re: Sonnet: Trigram data file for Greek

2017-01-24 Thread Christoph Feck
On 24.01.2017 19:45, John Salatas wrote: On 2017-01-24 10:40 AM, Christoph Feck wrote: On 24.01.2017 09:01, John Salatas wrote: I just built a trigram data file (attached) for Greek language using a wikipedia dump as corpus. Can I just push it to sonnet's git or do I need to generate a

[Differential] [Commented On] D4258: redesign gimp icon

2017-01-24 Thread Alexey Varfolomeev
varlesh added a comment. without pencil and more dark gradien for eyes F2164770: Снимок экрана от 2017-01-25 01-55-08.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4258 EMAIL PREFERENCES

[Differential] [Commented On] D4258: redesign gimp icon

2017-01-24 Thread Andreas Kainz
andreaska added a comment. How does it look without pencil? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4258 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: varlesh, andreask, #breeze Cc: andreaska, alex-l, #frameworks

[Differential] [Commented On] D4258: redesign gimp icon

2017-01-24 Thread Alexey Varfolomeev
varlesh added a comment. In https://phabricator.kde.org/D4258#79842, @alex-l wrote: > To be honest any of them is in Breeze style for me (in fact I proposed a Gimp icon time ago but it wasn't accepted) Sorry Alex, but now icon on master used from another icon theme - it's my

[Differential] [Commented On] D4234: Change algorithm for autobrace.

2017-01-24 Thread Jérémy Girard
cactus added a comment. Sorry, I am not sure to understand what do you want. You would like the previous behavior with a multi-depth stack of range? I don't understand what disturb you in my solution. You can close a missing bracket. If you have (| and you press ')', you obtain ()|.

[Differential] [Commented On] D4262: redesign android-studio icon

2017-01-24 Thread Alexey Varfolomeev
varlesh added a comment. In https://phabricator.kde.org/D4262#79950, @andreaska wrote: > oh schit didn't no this. thanks but I thought only the circle is in the icon now nearly the full height and in your design only 2/3 of the icon height. Circle have not 40px, because it'

[Differential] [Commented On] D4262: redesign android-studio icon

2017-01-24 Thread Andreas Kainz
andreaska added a comment. oh schit didn't no this. thanks but I thought only the circle is in the icon now nearly the full height and in your design only 2/3 of the icon height. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4262 EMAIL PREFERENCES

[Differential] [Commented On] D4264: redesign android-file-transfer icon

2017-01-24 Thread Alexey Varfolomeev
varlesh added a comment. In https://phabricator.kde.org/D4264#79832, @alex-l wrote: > With the green gradient in the opposite direction it would be perfect not possible, because colors merged and not good looking. In https://phabricator.kde.org/D4264#79871, @andreaska wrote:

[Differential] [Commented On] D4264: redesign android-file-transfer icon

2017-01-24 Thread Alexey Varfolomeev
varlesh added a comment. @alex-l reverted gradient: F2164722: Снимок экрана от 2017-01-25 01-18-07.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4264 EMAIL PREFERENCES

[Differential] [Commented On] D4262: redesign android-studio icon

2017-01-24 Thread Alexey Varfolomeev
varlesh added a comment. In https://phabricator.kde.org/D4262#79869, @andreaska wrote: > why is the circle now so small? Please see code, icon on now exis breeze (№2) have wrong size 512px on 48px folder: viewBox="0 0 512 512" height="512" width="512" My icon

Re: Sonnet: Trigram data file for Greek

2017-01-24 Thread John Salatas
On 2017-01-24 10:40 AM, Christoph Feck wrote: On 24.01.2017 09:01, John Salatas wrote: I just built a trigram data file (attached) for Greek language using a wikipedia dump as corpus. Can I just push it to sonnet's git or do I need to generate a differential review in phabricator or something?

Re: Sonnet: Trigram data file for Greek

2017-01-24 Thread Christoph Feck
On 24.01.2017 09:01, John Salatas wrote: I just built a trigram data file (attached) for Greek language using a wikipedia dump as corpus. Can I just push it to sonnet's git or do I need to generate a differential review in phabricator or something? Isn't Greek language automatically detected

[Differential] [Updated, 12 lines] D4190: Update file type on save only if path changes

2017-01-24 Thread Mikko Perttunen
mperttunen removed R39 KTextEditor as the repository for this revision. mperttunen updated this revision to Diff 10504. mperttunen added a comment. Fixed issue pointed out by cullmann CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4190?vs=10324=10504 REVISION DETAIL

[Differential] [Closed] D4268: deprecate the security class

2017-01-24 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R304:0dc151ae2c8b: deprecate the security class (authored by sitter). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4268?vs=10491=10501 REVISION DETAIL

[Differential] [Accepted] D4268: deprecate the security class

2017-01-24 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D4268 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, apol Cc: #frameworks

[Differential] [Closed] D4214: Make sure we display enabled ListItem on hover

2017-01-24 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R242:54e87fe879ba: Make sure we display enabled ListItem on hover (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D4264: redesign android-file-transfer icon

2017-01-24 Thread Andreas Kainz
andreaska added a comment. where is this icon used? is it an application or an mimetype? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4264 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: varlesh, andreask, #breeze Cc:

[Differential] [Commented On] D4262: redesign android-studio icon

2017-01-24 Thread Andreas Kainz
andreaska added a comment. why is the circle now so small? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4262 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: varlesh, andreask, #breeze Cc: andreaska, alex-l, #frameworks

[Differential] [Accepted] D4259: fix alienarena icon

2017-01-24 Thread Andreas Kainz
andreaska accepted this revision. andreaska added a reviewer: andreaska. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4259 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D4261: redesign atom icon

2017-01-24 Thread Andreas Kainz
andreaska accepted this revision. andreaska added a reviewer: andreaska. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4261 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D4260: fix bitcoin128 icon

2017-01-24 Thread Andreas Kainz
andreaska accepted this revision. andreaska added a reviewer: andreaska. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4260 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Commented On] D4253: redesign gwenview icon

2017-01-24 Thread Andreas Kainz
andreaska added a comment. I also think that we shouldn't update the icon. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4253 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: varlesh, #breeze, andreask Cc: alex-l,

[Differential] [Commented On] D4251: Redesign aptana icon

2017-01-24 Thread Alexey Varfolomeev
varlesh added a comment. icon fixed, diff updated: F2164130: Снимок экрана от 2017-01-24 18-10-21.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4251 EMAIL PREFERENCES

[Differential] [Updated, 27 lines] D4251: Redesign aptana icon

2017-01-24 Thread Alexey Varfolomeev
varlesh updated this revision to Diff 10497. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4251?vs=10454=10497 REVISION DETAIL https://phabricator.kde.org/D4251 AFFECTED FILES icons/apps/48/aptana.svg EMAIL PREFERENCES

[Differential] [Accepted] D4267: redesign bluefish icon

2017-01-24 Thread Andreas Kainz
andreaska accepted this revision. andreaska added a reviewer: andreaska. andreaska added a comment. This revision is now accepted and ready to land. ship it REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4267 EMAIL PREFERENCES

[Differential] [Commented On] D4267: redesign bluefish icon

2017-01-24 Thread Alexey Varfolomeev
varlesh added a comment. diff updated (new version on left): F2164109: Снимок экрана от 2017-01-24 17-52-14.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4267 EMAIL PREFERENCES

[Differential] [Updated, 196 lines] D4267: redesign bluefish icon

2017-01-24 Thread Alexey Varfolomeev
varlesh updated the summary for this revision. varlesh updated this revision to Diff 10496. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4267?vs=10490=10496 REVISION DETAIL https://phabricator.kde.org/D4267 AFFECTED FILES

[Differential] [Commented On] D4253: redesign gwenview icon

2017-01-24 Thread Alessandro Longo
alex-l added a comment. As mentioned on Telegram, I'm for keeping the current one (please update the screenshot of it because it's not how it currently look) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4253 EMAIL PREFERENCES

[Differential] [Commented On] D4251: Redesign aptana icon

2017-01-24 Thread Alessandro Longo
alex-l added a comment. I don't like the circular gradient in the middle and the inner shadow is wrong. OK for the rest REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4251 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Commented On] D4258: redesign gimp icon

2017-01-24 Thread Alessandro Longo
alex-l added a comment. To be honest any of them is in Breeze style for me (in fact I proposed a Gimp icon time ago but it wasn't accepted) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4258 EMAIL PREFERENCES

[Differential] [Commented On] D4259: fix alienarena icon

2017-01-24 Thread Alessandro Longo
alex-l added a comment. A bit too vibrant but good REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4259 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: varlesh, andreask, #breeze Cc: alex-l, #frameworks

[Differential] [Commented On] D4260: fix bitcoin128 icon

2017-01-24 Thread Alessandro Longo
alex-l added a comment. Very good for me REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4260 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: varlesh, andreask, #breeze Cc: alex-l, #frameworks

[Differential] [Commented On] D4261: redesign atom icon

2017-01-24 Thread Alessandro Longo
alex-l added a comment. Very good for me REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4261 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: varlesh, andreask, #breeze Cc: alex-l, #frameworks

[Differential] [Commented On] D4264: redesign android-file-transfer icon

2017-01-24 Thread Alessandro Longo
alex-l added a comment. With the green gradient in the opposite direction it would be perfect REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4264 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: varlesh, andreask, #breeze

[Differential] [Commented On] D4267: redesign bluefish icon

2017-01-24 Thread Alessandro Longo
alex-l added a comment. I think the new one is better. I'd just make the colors more vibrant REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4267 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: varlesh, andreask, #breeze

Re: Sonnet: Trigram data file for Greek

2017-01-24 Thread Luca Beltrame
Il giorno Tue, 24 Jan 2017 00:01:29 -0800 John Salatas ha scritto: Hello, > I just built a trigram data file (attached) for Greek language using > a wikipedia dump as corpus. Can I just push it to sonnet's git or do > I need to generate a differential review in phabricator

[Differential] [Accepted] D4214: Make sure we display enabled ListItem on hover

2017-01-24 Thread Marco Martin
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D4214 EMAIL PREFERENCES

[Differential] [Request, 54 lines] D4268: deprecate the security class

2017-01-24 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The Security class is not actually used, hasn't seen any active development in years and uses gpg in a

[Differential] [Request, 196 lines] D4267: redesign bluefish icon

2017-01-24 Thread Alexey Varfolomeev
varlesh created this revision. varlesh added reviewers: andreask, Breeze. varlesh set the repository for this revision to R266 Breeze Icons. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Compare: F2164034: Снимок

[Differential] [Commented On] D4214: Make sure we display enabled ListItem on hover

2017-01-24 Thread David Edmundson
davidedmundson added a comment. +1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4214 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma Cc: mart, davidedmundson, plasma-devel, #frameworks,

Sonnet: Trigram data file for Greek

2017-01-24 Thread John Salatas
Hi. I just built a trigram data file (attached) for Greek language using a wikipedia dump as corpus. Can I just push it to sonnet's git or do I need to generate a differential review in phabricator or something? Thanks! -- John Salatas το 0 αι1

[Differential] [Updated, 17 lines] D4214: Make sure we display enabled ListItem on hover

2017-01-24 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 10489. apol added a comment. Removed hover state as requested by David and Marco REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4214?vs=10379=10489 BRANCH master REVISION DETAIL

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 319 - Fixed!

2017-01-24 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/319/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 24 Jan 2017 09:49:43 + Build duration: 16 min CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 319 - Fixed!

2017-01-24 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/319/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 24 Jan 2017 09:49:43 + Build duration: 16 min CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 318 - Unstable!

2017-01-24 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/318/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 24 Jan 2017 09:10:44 + Build duration: 2 min 39 sec CHANGE