[Differential] [Commented On] D4253: redesign gwenview icon

2017-01-27 Thread Alexey Varfolomeev
varlesh added a comment. ok guys, next variant: F2186171: Снимок экрана от 2017-01-28 11-31-35.png 1:1 F2186174: Снимок экрана от 2017-01-28 11-36-20.png Also this icon use style as mime image REPOSITORY

[Differential] [Updated, 4 lines] D4294: Latex Syntax: Fix identification of alignat environment end

2017-01-27 Thread Hironori Fujimoto
hfujimoto updated this revision to Diff 10646. hfujimoto added a comment. oh, I missed. I should not change xml version but also language version. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4294?vs=10645=10646 REVISION DETAIL

[Differential] [Commented On] D4294: Latex Syntax: Fix identification of alignat environment end

2017-01-27 Thread Hironori Fujimoto
hfujimoto added a comment. @dhaumann I don't have commit access. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D4294 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hfujimoto, #framework_syntax_hightlighting Cc:

[Differential] [Updated, 4 lines] D4294: Latex Syntax: Fix identification of alignat environment end

2017-01-27 Thread Hironori Fujimoto
hfujimoto updated this revision to Diff 10645. hfujimoto added a comment. increse version number. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4294?vs=10584=10645 REVISION DETAIL https://phabricator.kde.org/D4294 AFFECTED FILES

[Differential] [Request, 7 lines] D4320: Don't fail when moving to the temp directory when installing

2017-01-27 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Frameworks, mart. Restricted Application added a project: Frameworks. REVISION SUMMARY The process to install a kpackage package through knewstuff is: - download to /tmp - copy to /tmp with the desired filename - call the install

[Differential] [Request, 106 lines] D4317: Make it possible to change icon themes from elsewhere in kns

2017-01-27 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Frameworks, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Splits the logic into a separate binary, also cleans some unneeded code in the KCM. Introduces the

[Differential] [Commented On] D4307: [RFC] Introduce an adoption command in the wallpaper knsrc file

2017-01-27 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D4307#80790, @apol wrote: > In https://phabricator.kde.org/D4307#80774, @mart wrote: > > > if this goes in, the stock knewstuff install dialog should use it as well > > > I'm not sure. In this specific case, if you're in the

[Differential] [Commented On] D4307: [RFC] Introduce an adoption command in the wallpaper knsrc file

2017-01-27 Thread Aleix Pol Gonzalez
apol added a comment. In https://phabricator.kde.org/D4307#80774, @mart wrote: > if this goes in, the stock knewstuff install dialog should use it as well I'm not sure. In this specific case, if you're in the KNS Dialog means that you already have the Wallpapers kcm open already,

[Differential] [Updated] D4307: [RFC] Introduce an adoption command in the wallpaper knsrc file

2017-01-27 Thread Marco Martin
mart added a comment. this could be a nice idea. if this goes in, the stock knewstuff install dialog should use it as well REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4307 EMAIL PREFERENCES

[Differential] [Request, 1 line] D4307: [RFC] Introduce an adoption command in the wallpaper knsrc file

2017-01-27 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Frameworks, mart, whiting, leinir. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Using the same semantics as the InstallationCommand, makes it possible for the client

[Differential] [Request, 18 lines] D4305: Work round the DBus type casting bug

2017-01-27 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY property() works in a slightly different way to just calling Get(). It allocates the variant of the relevant type in advance in

Re: Review Request 129665: [KStatusNotifierItem] Restore mnimized window as normal

2017-01-27 Thread Anthony Fieroni
> On Jan. 26, 2017, 7:18 a.m., Anthony Fieroni wrote: > > Ping KMail do this explicitly, i think it should be expected behavior. - Anthony --- This is an automatically generated e-mail. To reply, visit: