[Differential] [Updated] D4363: Don't set gnu style parameter with Clang and MSVC

2017-01-31 Thread David Faure
dfaure added a comment. I'm no expert but this seems ok, no objection from me. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D4363 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: vonreth, #windows, bcooksley,

Re: Phabricator: All repositories registered - upcoming workflow changes

2017-01-31 Thread René J . V . Bertin
On Tuesday January 31 2017 20:10:42 Luigi Toscano wrote: >> It will be a complete shutdown of Reviewboard - we'll be archiving it >> in the event for some reason it becomes necessary to access the data >> it stores. > >Isn't it a way to change the site in static website and keep it alive?

Re: Phabricator: All repositories registered - upcoming workflow changes

2017-01-31 Thread Luigi Toscano
Ben Cooksley ha scritto: > On Tue, Jan 31, 2017 at 11:36 PM, René J.V. Bertin > wrote: >> On Sunday January 29 2017 08:32:21 Ben Cooksley wrote: >> >> Hi, > > Hi Rene, > >> >> >From this point forward, communities should be moving away from >>> Reviewboard to Phabricator

Re: Phabricator: All repositories registered - upcoming workflow changes

2017-01-31 Thread Ben Cooksley
On Tue, Jan 31, 2017 at 11:36 PM, René J.V. Bertin wrote: > On Sunday January 29 2017 08:32:21 Ben Cooksley wrote: > > Hi, Hi Rene, > > >From this point forward, communities should be moving away from >>Reviewboard to Phabricator for conducting code review. Sysadmin will

[Differential] [Updated] D4377: Fix Python dependency in test scripts for KFileMetaData (bug 375472)

2017-01-31 Thread A. Wilcox
awilcox updated the test plan for this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D4377 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: awilcox Cc: #frameworks

[Differential] [Request, 10 lines] D4377: Fix Python dependency in test scripts for KFileMetaData (bug 375472)

2017-01-31 Thread A. Wilcox
awilcox created this revision. awilcox set the repository for this revision to R286 KFileMetaData. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY KFileMetaData test scripts are usable in both deprecated Python 2, and

KConfig issues prevent compiling KDE applications under Windows

2017-01-31 Thread Jasem Mutlaq
Hello, KConfig used to work perfectly fine under Windows. I recently tried to compile KStars under Windows 10 (64bit) with MSVC 2015 and Qt 5.8 using Craft, but encountered an issue as explained in this bug report: https://bugs.kde.org/show_bug.cgi?id=375654 I talked with Craft maintainers

[Differential] [Request, 88 lines] D4365: Make it possible to adopt resources, mostly for system-wide settings

2017-01-31 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Frameworks, Plasma, mart. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Makes it possible to specify commands that will put the resource in use, such as

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 485 - Still Failing!

2017-01-31 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/485/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 31 Jan 2017 12:05:05 + Build duration: 22 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 485 - Still Failing!

2017-01-31 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/485/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 31 Jan 2017 12:05:05 + Build duration: 23 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 484 - Failure!

2017-01-31 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/484/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 31 Jan 2017 11:50:40 + Build duration: 26 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 484 - Failure!

2017-01-31 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/484/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 31 Jan 2017 11:50:39 + Build duration: 42 sec CHANGE SET Revision

[Differential] [Closed] D4254: add new test for scalable exposure

2017-01-31 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R266:7d01f3d8b5c0: add new test for scalable exposure (authored by sitter). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4254?vs=10460=10757 REVISION DETAIL

[Differential] [Updated] D4363: Don't set gnu style parameter with Clang and MSVC

2017-01-31 Thread Hannah von Reth
vonreth added reviewers: Windows, bcooksley, alexmerry, dfaure. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D4363 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: vonreth, #windows, bcooksley, alexmerry, dfaure Cc:

[Differential] [Request, 38 lines] D4363: Don't set gnu style parameter with Clang and MSVC

2017-01-31 Thread Hannah von Reth
vonreth created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY Setting the gnu style compiler flags with clang-cl results in a huge bunch of unknown argument warnings.

[Differential] [Commented On] D4362: RFC: [AppletQuickItem] Cache QQmlComponent used for settings QtQuick Controls 1 style

2017-01-31 Thread David Edmundson
davidedmundson added a comment. Personally I would just kill the whole thing. - All Plasma code all uses Plasma Components not QQC so this has zero effect. It was for an idea that didn't really materialise - It gives an obscure ASAN warning on freeing "o", that I don't know how to fix

[Differential] [Request, 31 lines] D4362: RFC: [AppletQuickItem] Cache QQmlComponent used for settings QtQuick Controls 1 style

2017-01-31 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Framework (Library). Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY

Re: Phabricator: All repositories registered - upcoming workflow changes

2017-01-31 Thread René J . V . Bertin
On Sunday January 29 2017 08:32:21 Ben Cooksley wrote: Hi, >From this point forward, communities should be moving away from >Reviewboard to Phabricator for conducting code review. Sysadmin will >be announcing a timeline for the shutdown of Reviewboard in the near >future. I hope that shutdown

[Differential] [Commented On] D4361: [Containment] Move contains() check inside NDEBUG

2017-01-31 Thread Bhushan Shah
bshah added a comment. I'd say we should port away all of the users of NDEBUG to qCDebug (if anything is still using qDebug) and remove those ifdefs.. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4361 EMAIL PREFERENCES

[Differential] [Request, 4 lines] D4361: [Containment] Move contains() check inside NDEBUG

2017-01-31 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Framework (Library). Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Since