Re: Review Request 129665: [KStatusNotifierItem] Restore mnimized window as normal

> On Ян. 26, 2017, 7:18 преди обяд, Anthony Fieroni wrote: > > Ping > > Anthony Fieroni wrote: > KMail do this explicitly, i think it should be expected behavior. Ping - Anthony --- This is an automatically generated e-mail. To

Re: Review Request 129245: Add Korean Alphabet(Hangul) and Vietnamese Pronunciation.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129245/ --- (Updated Feb. 2, 2017, 3:45 a.m.) Status -- This change has been

[Differential] [Updated, 248 lines] D4329: KMessageWidget: fix behaviour on overlapping calls of animatedShow/animatedHide

kossebau updated this revision to Diff 10838. kossebau added a comment. add a note to the "500" value in code to keep test in sync REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4329?vs=10837=10838 BRANCH fixKMessageWidgetInstantShowHide

[Differential] [Updated, 247 lines] D4329: KMessageWidget: fix behaviour on overlapping calls of animatedShow/animatedHide

kossebau updated this revision to Diff 10837. kossebau marked 5 inline comments as done. kossebau added a comment. updates to code style, avoid unneeded include REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4329?vs=10669=10837 BRANCH

[Differential] [Updated, 38 lines] D4392: Fix KEditListWidget losing the focus on click of buttons

kossebau updated this revision to Diff 10836. kossebau marked an inline comment as done. kossebau added a comment. adapt to local syntax style for pointer types REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4392?vs=10818=10836 BRANCH

[Differential] [Changed Subscribers] D4392: Fix KEditListWidget losing the focus on click of buttons

cfeck added inline comments. INLINE COMMENTS > keditlistwidget.cpp:153 > +// TODO: merge with enableMoveButtons() > +QPushButton* const buttons[3] = { servUpButton, servDownButton, > servRemoveButton }; > + Please use "Type *ptr" instead of "Type* ptr" throughout. REPOSITORY R236

[Differential] [Changed Subscribers] D4329: KMessageWidget: fix behaviour on overlapping calls of animatedShow/animatedHide

cfeck added inline comments. INLINE COMMENTS > kmessagewidgetautotest.cpp:24 > #include > +#include > #include Isn't QSignalSpy part of QtTest? In other words, isn't it included by above #include line? > kmessagewidgetautotest.cpp:125 > +w.animatedShow(); > +if (delay)

[Differential] [Accepted] D4355: Add methods to hide the reveal password action

cfeck accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH disable-visibility-action REVISION DETAIL https://phabricator.kde.org/D4355 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

Re: Review Request 129849: KToolTipWidget: don't take ownership of the content widget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129849/#review102346 --- Ship it! Ship It! - Christoph Feck On Jan. 17, 2017,

breeze-icons and the symlink business

hola breeze-icons uses lots of symlinks. Unfortunately, ever so often our icon designers make a mistake and create a bad symlink. To mitigate this I added a bunch of tests making sure everything is nice and dandy. In the mean parts of the build were changed to not tolerate broken symlinks. While

[Differential] [Closed] D4365: Make it possible to adopt resources, mostly for system-wide settings

This revision was automatically updated to reflect the committed changes. Closed by commit R304:15c638307a91: Make it possible to adopt resources, mostly for system-wide settings (authored by apol). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

NOW is the time to fill in the Ideas page for GSoC! Application deadline 9 Feb.

Hello GSoC mentors, and teams supporting mentors, We've asked for more time to get ramped up for GSoC, and so the calendar has been moved back to early February. However, that means that our Ideas page needs to be filled NOW, so that it can be taken into consideration once the Org Applications

Re: Phabricator: All repositories registered - upcoming workflow changes

On Thu, 2 Feb 2017 07:45:15 +1300 Ben Cooksley wrote: [snip] > > I think that we need some cleanup on the old reviews (Albert Astal Cid > started > some time ago) and more important strongly tell new users (and old > users) to use Phabricator. I don't think that anyone wants

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 494 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/494/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 01 Feb 2017 22:58:01 + Build duration: 20 min CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 494 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/494/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 01 Feb 2017 22:57:43 + Build duration: 20 min CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 493 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/493/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 01 Feb 2017 22:53:20 + Build duration: 3 min 17 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 493 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/493/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 01 Feb 2017 22:53:20 + Build duration: 3 min 15 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 492 - Still unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/492/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 01 Feb 2017 22:05:38 + Build duration: 23 min CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 492 - Still unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/492/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 01 Feb 2017 22:05:38 + Build duration: 4 min 23 sec CHANGE SET Revision

Re: Phabricator: All repositories registered - upcoming workflow changes

El dijous, 2 de febrer de 2017, a les 7:45:15 CET, Ben Cooksley va escriure: > Anything older than that usually won't apply to the code anymore. You'd be surprised (yes i have a script that actually applies the MRs and lots of them even very old apply). Cheers, Albert

Re: Raising the requirement to Qt 5.6 ?

El dimecres, 1 de febrer de 2017, a les 14:16:35 CET, David Faure va escriure: > On mardi 31 janvier 2017 01:25:58 CET Aleix Pol wrote: > > On Tue, Jan 31, 2017 at 12:59 AM, Albert Astals Cid wrote: > > > Now that Qt 5.8 is out, should we increase requirement to Qt 5.6 as the > > >

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 491 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/491/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 01 Feb 2017 21:54:26 + Build duration: 2 min 37 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 491 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/491/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 01 Feb 2017 21:54:26 + Build duration: 23 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 490 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/490/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 01 Feb 2017 21:36:11 + Build duration: 45 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 490 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/490/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 01 Feb 2017 21:36:11 + Build duration: 2 min 58 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 489 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/489/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 01 Feb 2017 20:53:21 + Build duration: 16 min CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 489 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/489/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 01 Feb 2017 20:53:21 + Build duration: 2 min 36 sec CHANGE SET Revision

Re: Phabricator: All repositories registered - upcoming workflow changes

Am 1. Februar 2017 20:34:52 MEZ schrieb Ben Cooksley : >On Wed, Feb 1, 2017 at 9:48 PM, Milian Wolff wrote: >> On Tuesday, January 31, 2017 7:56:52 PM CET Ben Cooksley wrote: >>> On Tue, Jan 31, 2017 at 11:36 PM, René J.V. Bertin > >>

Re: Phabricator: All repositories registered - upcoming workflow changes

On Wed, Feb 1, 2017 at 9:48 PM, Milian Wolff wrote: > On Tuesday, January 31, 2017 7:56:52 PM CET Ben Cooksley wrote: >> On Tue, Jan 31, 2017 at 11:36 PM, René J.V. Bertin > wrote: >> > On Sunday January 29 2017 08:32:21 Ben Cooksley wrote: >> > >> > Hi, >>

Re: Phabricator: All repositories registered - upcoming workflow changes

On 2/02/2017 12:41 AM, "Luigi Toscano" wrote: On Wednesday, 1 February 2017 10:31:44 CET Francis Herne wrote: > Sorry, forgot to reply-all and only sent to kdevelop-devel... > > - > > Hi, > > First off, there's a lot of postponed, or at least

Re: Phabricator: All repositories registered - upcoming workflow changes

On 1/02/2017 10:38 PM, "René J.V. Bertin" wrote: On Wednesday February 1 2017 22:16:50 Ben Cooksley wrote: >We'd still have to keep the software running, and up to date (to avoid >it becoming a security risk). Running yes, but if log-in is disabled at the core and not

[Differential] [Request, 10 lines] D4398: Don't generate appdata if it's marked as NoDisplay

apol created this revision. apol added reviewers: Plasma, Frameworks, mart. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Only generate appdata information for the packages end-users are supposed to know

[Differential] [Request, 3 lines] D4396: Specify NoDisplay type

apol created this revision. apol added reviewers: Plasma, Frameworks, mart, davidedmundson. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise toBool doesn't work. I didn't see it called anywhere as

[Differential] [Commented On] D4362: RFC: [AppletQuickItem] Cache QQmlComponent used for settings QtQuick Controls 1 style

mart added a comment. In https://phabricator.kde.org/D4362#81771, @davidedmundson wrote: > Personally I would just kill the whole thing. > > - All Plasma code all uses Plasma Components not QQC so this has zero effect. It was for an idea that didn't really materialise

[Differential] [Accepted] D4365: Make it possible to adopt resources, mostly for system-wide settings

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D4365 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #frameworks, #plasma, mart

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 426 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/426/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 01 Feb 2017 16:18:31 + Build duration: 1 min 29 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 426 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/426/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 01 Feb 2017 16:18:31 + Build duration: 1 min 29 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kxmlrpcclient master kf5-qt5 » Linux,gcc - Build # 386 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kxmlrpcclient%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/386/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 01 Feb 2017 16:18:26 + Build duration: 1 min 4 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kxmlrpcclient master kf5-qt5 » Linux,gcc - Build # 386 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kxmlrpcclient%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/386/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 01 Feb 2017 16:18:26 + Build duration: 1 min 4 sec CHANGE SET No changes JUNIT RESULTS Name:

[Differential] [Accepted] D4357: Re-enable Log-to-File for KNotifications

mck182 accepted this revision. mck182 added a comment. This revision is now accepted and ready to land. Looks good, should be fine. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4357 EMAIL PREFERENCES

Jenkins-kde-ci: kross master kf5-qt5 » Linux,gcc - Build # 393 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kross%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/393/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 01 Feb 2017 15:22:36 + Build duration: 2 min 8 sec CHANGE SET No changes

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 425 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/425/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 01 Feb 2017 15:22:36 + Build duration: 2 min 8 sec CHANGE SET No changes

Jenkins-kde-ci: kxmlrpcclient master kf5-qt5 » Linux,gcc - Build # 385 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kxmlrpcclient%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/385/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 01 Feb 2017 15:22:36 + Build duration: 2 min 8 sec CHANGE SET No changes

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 225 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/225/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 01 Feb 2017 14:22:20 + Build duration: 5 min 47 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 488 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/488/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 01 Feb 2017 13:47:19 + Build duration: 16 min CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 144 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/144/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Wed, 01 Feb 2017 13:47:19 + Build duration: 1 min 11 sec CHANGE SET

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 144 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/144/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Wed, 01 Feb 2017 13:47:19 + Build duration: 1 min 11 sec CHANGE SET

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 488 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/488/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 01 Feb 2017 13:39:38 + Build duration: 2 min 54 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,NoX11,gcc - Build # 146 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/146/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Wed, 01 Feb 2017 13:39:38 + Build duration: 4 min 2 sec CHANGE SET No

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,NoX11,gcc - Build # 146 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/146/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Wed, 01 Feb 2017 13:39:38 + Build duration: 4 min 2 sec CHANGE SET No

Re: Review Request 129839: KFileMetaData: add a new property DiscNumber for audio files from multi-disc albums

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129839/#review102339 --- Should I move the review request to phabricator ? -

Re: Review Request 129798: add more audio formats to automatic test and fix one problem with Musepack

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129798/#review102338 --- Should I move the review request to phabricator ? -

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 146 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/146/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 01 Feb 2017 13:39:38 + Build duration: 1 min 53 sec CHANGE SET No changes

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 146 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/146/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 01 Feb 2017 13:39:38 + Build duration: 1 min 53 sec CHANGE SET No changes

[Differential] [Updated, 43 lines] D4363: Don't set gnu style parameter with Clang and MSVC

vonreth updated this revision to Diff 10822. vonreth added a comment. Small fix REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4363?vs=10756=10822 BRANCH arcpatch-D4363 REVISION DETAIL https://phabricator.kde.org/D4363 AFFECTED FILES

[Differential] [Updated] D4392: Fix KEditListWidget losing the focus on click of buttons

kossebau retitled this revision from "Fix KEditListWidget losing the focus on click of Add button" to "Fix KEditListWidget losing the focus on click of buttons". kossebau updated the summary for this revision. kossebau updated the test plan for this revision. REPOSITORY R236 KWidgetsAddons

Re: KConfig issues prevent compiling KDE applications under Windows

On mardi 31 janvier 2017 07:58:15 CET Jasem Mutlaq wrote: > Hello, > > KConfig used to work perfectly fine under Windows. I recently tried to > compile KStars under Windows 10 (64bit) with MSVC 2015 and Qt 5.8 using > Craft, but encountered an issue as explained in this bug report: > >

[Differential] [Updated, 38 lines] D4392: Fix KEditListWidget losing the focus on click of Add button

kossebau updated this revision to Diff 10818. kossebau added a comment. remove QDebug include again REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4392?vs=10817=10818 BRANCH makeKListEditWidgetNotLoseFocus REVISION DETAIL

[Differential] [Updated, 39 lines] D4392: Fix KEditListWidget losing the focus on click of Add button

kossebau updated this revision to Diff 10817. kossebau added a comment. Update to catch some more unwanted focus losts REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4392?vs=10811=10817 BRANCH makeKListEditWidgetNotLoseFocus REVISION DETAIL

[Differential] [Closed] D4389: Don't set gnu style parameter with Clang and MSVC

This revision was automatically updated to reflect the committed changes. Closed by commit R240:16a148feda4e: Fix ENABLE_CLAZY on Windows (authored by vonreth). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4389?vs=10802=10816 REVISION DETAIL

Re: Raising the requirement to Qt 5.6 ?

On mardi 31 janvier 2017 01:25:58 CET Aleix Pol wrote: > On Tue, Jan 31, 2017 at 12:59 AM, Albert Astals Cid wrote: > > Now that Qt 5.8 is out, should we increase requirement to Qt 5.6 as the > > rules say? > > +1 > Let's! Yes, the good thing about generic rules is that we can

[Differential] [Abandoned] D4084: Add unit test for desktopToJson being called without an explicit serviceType

davidedmundson abandoned this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D4084 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, #frameworks, apol Cc: plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Request, 8 lines] D4392: Fix KEditListWidget losing the focus on click of Add button

kossebau created this revision. kossebau added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY When the user triggers the Add button by keyboard focus or mouse, the button has focus when it gets disabled in the addItem() handler. Which results in

Re: Phabricator: All repositories registered - upcoming workflow changes

On Wednesday, 1 February 2017 10:31:44 CET Francis Herne wrote: > Sorry, forgot to reply-all and only sent to kdevelop-devel... > > - > > Hi, > > First off, there's a lot of postponed, or at least possibly-useful, > work on ReviewBoard which would be lost. Some of this is from

Re: Phabricator: All repositories registered - upcoming workflow changes

On Wednesday, 1 February 2017 11:52:01 CET Alexander Zhigalin wrote: > Completely agreeing with Rene, Luigi and Milian. > All this sounds very sad to me. > Phabricator is indeed very powerful and better for management stuff. > But Differential is not even merely comparable to RB by ease of use,

[Differential] [Accepted] D4389: Don't set gnu style parameter with Clang and MSVC

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH 2 REVISION DETAIL https://phabricator.kde.org/D4389 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: vonreth, smartins, alexmerry,

Re:Phabricator: All repositories registered - upcoming workflow changes

Completely agreeing with Rene, Luigi and Milian. All this sounds very sad to me. Phabricator is indeed very powerful and better for management stuff. But Differential is not even merely comparable to RB by ease of use, mail notifications, review immediateness and usage speed... > On Tuesday,

Re: Phabricator: All repositories registered - upcoming workflow changes

Sorry, forgot to reply-all and only sent to kdevelop-devel... - Hi, First off, there's a lot of postponed, or at least possibly-useful, work on ReviewBoard which would be lost. Some of this is from newish contributors who might be discouraged - e.g. the author of

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 487 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/487/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 01 Feb 2017 10:38:39 + Build duration: 16 min CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 487 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/487/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 01 Feb 2017 10:38:39 + Build duration: 4 min 36 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 486 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/486/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 01 Feb 2017 10:23:19 + Build duration: 4 min 46 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 486 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/486/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 01 Feb 2017 10:23:19 + Build duration: 4 min 1 sec CHANGE SET Revision

Re: Phabricator: All repositories registered - upcoming workflow changes

On Tuesday, January 31, 2017 7:56:52 PM CET Ben Cooksley wrote: > On Tue, Jan 31, 2017 at 11:36 PM, René J.V. Bertin wrote: > > On Sunday January 29 2017 08:32:21 Ben Cooksley wrote: > > > > Hi, > > Hi Rene, > > > >From this point forward, communities should be moving

Re: Phabricator: All repositories registered - upcoming workflow changes

On Wednesday February 1 2017 22:16:50 Ben Cooksley wrote: >We'd still have to keep the software running, and up to date (to avoid >it becoming a security risk). Running yes, but if log-in is disabled at the core and not linked to the central LDAP service or whatever it is you use, what

Re: Phabricator: All repositories registered - upcoming workflow changes

On Wed, Feb 1, 2017 at 9:26 PM, René J.V. Bertin wrote: > On Wednesday February 1 2017 20:59:46 Ben Cooksley wrote: > > Hi > >> >>While I have yet to test it, Reviewboard does use quite a bit of AJAX >>and other dynamic resources - so I won't be surprised to find out that

[Differential] [Updated] D4389: Don't set gnu style parameter with Clang and MSVC

vonreth updated the summary for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D4389 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: vonreth, apol, smartins, alexmerry Cc: #windows, #build_system,

[Differential] [Updated, 2 lines] D4389: Don't set gnu style parameter with Clang and MSVC

vonreth updated this revision to Diff 10802. vonreth added a comment. Trying to split the review REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4389?vs=10801=10802 BRANCH 2 REVISION DETAIL https://phabricator.kde.org/D4389 AFFECTED

[Differential] [Request, 40 lines] D4389: Don't set gnu style parameter with Clang and MSVC

vonreth created this revision. vonreth added reviewers: apol, smartins, alexmerry. vonreth added subscribers: Frameworks, Build System, Windows. vonreth added projects: Frameworks, Build System. REVISION SUMMARY Setting the gnu style compiler flags with clang-cl results in a huge bunch of

Re: Phabricator: All repositories registered - upcoming workflow changes

On Wednesday February 1 2017 20:59:46 Ben Cooksley wrote: Hi > >While I have yet to test it, Reviewboard does use quite a bit of AJAX >and other dynamic resources - so I won't be surprised to find out that >the usual mechanisms for creating static copies of sites don't produce >a workable

Re: Phabricator: All repositories registered - upcoming workflow changes

On Wed, Feb 1, 2017 at 8:10 AM, Luigi Toscano wrote: > Ben Cooksley ha scritto: >> On Tue, Jan 31, 2017 at 11:36 PM, René J.V. Bertin >> wrote: >>> On Sunday January 29 2017 08:32:21 Ben Cooksley wrote: >>> >>> Hi, >> >> Hi Rene, >> >>> >>> >From