jsalatas updated the summary for this revision.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D4538
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: jsalatas, #frameworks, #plasma
Cc: plasma-devel, kwrite-devel, lesliezhai,
jsalatas created this revision.
jsalatas added reviewers: Frameworks, Plasma.
jsalatas set the repository for this revision to R39 KTextEditor.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: kwrite-devel, plasma-devel.
REVISION SUMMARY
This
gszymaszek created this revision.
gszymaszek added a reviewer: KTextEditor.
gszymaszek set the repository for this revision to R39 KTextEditor.
Restricted Application added subscribers: Frameworks, kwrite-devel.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
This diff
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
mart/qqc2style
REVISION DETAIL
https://phabricator.kde.org/D4522
EMAIL PREFERENCES
mart created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
all indicators are not meant to be exported
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
mart/qqc2style
REVISION DETAIL
On mardi 7 février 2017 10:21:33 CET René J.V. Bertin wrote:
> On Tuesday February 7 2017 01:15:23 Marko Käning wrote:
>
> Hi,
>
> >BTW, has this problem disappeared in the meantime?
>
> Not really. The Qt error messages are no longer printed, but the underlying
> cause is still there. QActions
davidedmundson added a comment.
I want to do another full review next week when I'm home; but I'd be happy
with doing that after we merge it, as it'll only be small things, and nothing
which will affect API.
In general it all looks very good, I like that you split out ButtonShadow and
