Re: Trusting .desktop files

2017-02-10 Thread Martin Gräßlin
Am 2017-02-10 19:56, schrieb Fabian Vogt: Hi, The reddit post "How to easily trick $FILE_MANAGER users to execute arbitrary code" (https://www.reddit.com/r/linux/comments/5r6va0) spawned a discussion about .desktop files. Thanks for bringing up this important topic! (Although I get more and

Trusting .desktop files

2017-02-10 Thread Fabian Vogt
Hi, The reddit post "How to easily trick $FILE_MANAGER users to execute arbitrary code" (https://www.reddit.com/r/linux/comments/5r6va0) spawned a discussion about .desktop files. This is normally just a minor security issue as it requires manual user interaction. However, Plasma's

[Differential] [Updated] D4558: Fail the build early if xmllint is not available

2017-02-10 Thread Luigi Toscano
ltoscano added a reviewer: winterz. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D4558 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ltoscano, winterz Cc: #frameworks, #documentation

[Differential] [Request, 3 lines] D4558: Fail the build early if xmllint is not available

2017-02-10 Thread Luigi Toscano
ltoscano created this revision. Restricted Application added projects: Frameworks, Documentation. Restricted Application added subscribers: Documentation, Frameworks. REVISION SUMMARY xmllint is required later anyway, and kio_help has the check. BUG: 376246 TEST PLAN If xmllint is not

[Differential] [Request, 9 lines] D4556: Ref/deref DataEngines even if the metadata is invalid

2017-02-10 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Just because the metadata is invalid doesn't mean the DataEngine

[Differential] [Updated] D4552: [PreviewJob] Remove maximum size for local files by default

2017-02-10 Thread Kai Uwe Broulik
broulik updated the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D4552 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, dfaure, emmanuelp, hein Cc: #frameworks

[Differential] [Request, 2 lines] D4552: [PreviewJob] Remove maximum size for local files by default

2017-02-10 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: dfaure, emmanuelp, hein. broulik set the repository for this revision to R241 KIO. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Dolphin already special-cased

[Differential] [Closed] D4546: Add more API to enable custom menu positioning.

2017-02-10 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R242:701771833ee1: Align bottom edge to top edge of visualParent in the TopPosedLeftAlignedPopup… (authored by hein). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D4546: Add more API to enable custom menu positioning.

2017-02-10 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D4546 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma,

[Differential] [Commented On] D4546: Add more API to enable custom menu positioning.

2017-02-10 Thread Eike Hein
hein added a comment. To expand on the updated patch (I wrote a new commit message, but Phab doesn't notice automatically): The TM appears to be the only user of TopPosedLeftAlignedPopup currently, and the new behavior is also in line with the "Popup positioned on the top" docstring for the

[Differential] [Updated, 5 lines] D4546: Add more API to enable custom menu positioning.

2017-02-10 Thread Eike Hein
hein updated this revision to Diff 11180. hein added a comment. New approach. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4546?vs=11168=11180 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4546 AFFECTED FILES

[Differential] [Updated] D4546: Add more API to enable custom menu positioning.

2017-02-10 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D4546#84979, @hein wrote: > Although ... maybe one hack we could do is change the meaning of "TopPosedLeftAlignedPopup" to "bottom edge of menu at top of visualParent" instead of "0,0 of menu at top of visualParent". Marco?

[Differential] [Closed] D4471: Fix KCModule::setAuthAction error checking

2017-02-10 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R265:49dbf1beaff2: Fix KCModule::setAuthAction error checking (authored by davidedmundson). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4471?vs=10991=11172

[Differential] [Updated] D4546: Add more API to enable custom menu positioning.

2017-02-10 Thread Eike Hein
hein added a dependent revision: D4547: Use new PlasmaComponents.ContextMenu API for improved placement when at bottom edge.. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4546 EMAIL PREFERENCES

[Differential] [Commented On] D4546: Add more API to enable custom menu positioning.

2017-02-10 Thread Eike Hein
hein added a comment. Although ... maybe one hack we could do is change the meaning of "TopPosedLeftAlignedPopup" to "bottom edge of menu at top of visualParent" instead of "0,0 of menu at top of visualParent". Marco? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

[Differential] [Commented On] D4546: Add more API to enable custom menu positioning.

2017-02-10 Thread Eike Hein
hein added a comment. I'm not convinced it's worth it. This patch allows writing the same sort of code we already have in ContainmentInterface for context menu placement. If we resort to doing it there then clearly we need it in other places as well. (And I wrote openRelative ...)

[Differential] [Commented On] D4546: Add more API to enable custom menu positioning.

2017-02-10 Thread Kai Uwe Broulik
broulik added a comment. We have this openRelateive thing with "bottom left posed" and what not, shouldn't it have a thing for "have the bottom left corner of the menu be at the top of the parent item"? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

[Differential] [Request, 50 lines] D4546: Add more API to enable custom menu positioning.

2017-02-10 Thread Eike Hein
hein created this revision. hein added reviewers: Plasma, mart. hein added a subscriber: plasma-devel. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Without being able to get the menu size it's not possible to

[Differential] [Closed] D4543: [ConfigModel] Emit dataChanged when a ConfigCategory changes

2017-02-10 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:5becf5bc114e: [ConfigModel] Emit dataChanged when a ConfigCategory changes (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D4543: [ConfigModel] Emit dataChanged when a ConfigCategory changes

2017-02-10 Thread Eike Hein
hein accepted this revision. hein added a reviewer: hein. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4543 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Updated] D4543: [ConfigModel] Emit dataChanged when a ConfigCategory changes

2017-02-10 Thread Kai Uwe Broulik
broulik updated the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4543 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, #frameworks, lesliezhai,

[Differential] [Request, 15 lines] D4543: [ConfigModel] Emit dataChanged when a ConfigCategory changes

2017-02-10 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Framework (Library). Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. TEST PLAN Had a