[Differential] [Closed] D4572: Migrate AppearAnimation and DisappearAnimation to Animators

2017-02-11 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:263f119e17df: Migrate AppearAnimation and DisappearAnimation to Animators (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D4572: Migrate AppearAnimation and DisappearAnimation to Animators

2017-02-11 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4572 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Request, 194 lines] D4576: [WIP]: integrate drop menu and filecopy drop menu

2017-02-11 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY add an optional menu parameter to processMimeData to mnually pass an existing qmenu.

Re: Review Request 127800: Format number in KLocalizedString::subs

2017-02-11 Thread Chusslove Illich
> On Мај 1, 2016, 6:40 по п., Chusslove Illich wrote: > > To have localized numbers is the expected behavior (and documented as > > such). But it was "temporarily" disabled between kdelibs and KF5, until > > replacements for KLocale were decided. I don't remember why I didn't switch > > to

[Differential] [Request, 12 lines] D4575: add a popupmenuabouttoshow version that exposes the menu

2017-02-11 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY make it possible for clients to access the qmenu instance as is needed by the folderview

[Differential] [Request, 50 lines] D4572: Migrate AppearAnimation and DisappearAnimation to Animators

2017-02-11 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Framework (Library). Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Also

[Differential] [Closed] D4130: KConfigDialogManager: get change signal from metaObject or special property

2017-02-11 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R265:b5f90982c718: KConfigDialogManager: get change signal from metaObject or special property (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4130?vs=10874=11228#toc

Re: Review Request 129663: Don't break accelerators in KToolBar

2017-02-11 Thread Martin Tobias Holmedahl Sandsmark
> On Jan. 29, 2017, 7:32 p.m., David Faure wrote: > > Actually, Alt+letter for actions in toolbars doesn't work anymore. I > > *think* it worked long ago, when e.g. konqueror's toolbars had > > : [URL LineEdit] > > > > But re-reading the comment, that is exactly the point: no accel feature

[Differential] [Closed] D4570: [UDisks 2 Device] Add description for Floppy Disk

2017-02-11 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R245:d92588b8988f: [UDisks 2 Device] Add description for Floppy Disk (authored by broulik). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4570?vs=11225=11227 REVISION

Re: Trusting .desktop files

2017-02-11 Thread Sebastian Kügler
On Saturday, February 11, 2017 7:24:11 AM UTC Martin Gräßlin wrote: > What I don't like in general is that this is all happening as $user. > Thus any malicious program running as $user can also just change the > list of trusted Exec= values. > > So my suggestion is: let's use polkit. > > The

[Differential] [Accepted] D4570: [UDisks 2 Device] Add description for Floppy Disk

2017-02-11 Thread Jonathan Riddell
jriddell accepted this revision. jriddell added a comment. This revision is now accepted and ready to land. Genius, this solves the final problem in KDE and will be a killer feature in the next Frameworks release REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D4570

[Differential] [Updated] D4570: [UDisks 2 Device] Add description for Floppy Disk

2017-02-11 Thread Kai Uwe Broulik
broulik updated the test plan for this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D4570 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, jriddell Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed,

[Differential] [Request, 2 lines] D4570: [UDisks 2 Device] Add description for Floppy Disk

2017-02-11 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, jriddell. broulik set the repository for this revision to R245 Solid. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Ensures a floppy

[Differential] [Closed] D4558: Fail the build early if xmllint is not available

2017-02-11 Thread Luigi Toscano
This revision was automatically updated to reflect the committed changes. Closed by commit R238:d7e0d20ae5f6: Fail the build early if xmllint is not available (authored by ltoscano). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4558?vs=11197=11222

[Differential] [Accepted] D4558: Fail the build early if xmllint is not available

2017-02-11 Thread Allen Winter
winterz accepted this revision. winterz added a comment. This revision is now accepted and ready to land. ok REPOSITORY R238 KDocTools BRANCH check-xmllint REVISION DETAIL https://phabricator.kde.org/D4558 EMAIL PREFERENCES

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 429 - Unstable!

2017-02-11 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/429/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Feb 2017 13:31:36 + Build duration: 7 min 52 sec CHANGE SET No changes JUNIT RESULTS Name:

[Differential] [Commented On] D4558: Fail the build early if xmllint is not available

2017-02-11 Thread Luigi Toscano
ltoscano added a comment. I would say that the LibXML2 behaviour is correct. This "if" is what kio does as well, the same code was in kdelibs4/kdoctools but it was lost here in the split. (if you approve the change, please remember to select the specific action for it) REPOSITORY

[Differential] [Updated] D4558: Fail the build early if xmllint is not available

2017-02-11 Thread Allen Winter
winterz added a comment. guess this is the best you can do given that FindLibXml2 sets LibXml2_FOUND even if xmllint is not found. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D4558 EMAIL PREFERENCES

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 428 - Fixed!

2017-02-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/428/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Feb 2017 13:12:33 + Build duration: 5 min 45 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 428 - Fixed!

2017-02-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/428/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Feb 2017 13:12:33 + Build duration: 5 min 45 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kjsembed master kf5-qt5 » Linux,gcc - Build # 210 - Fixed!

2017-02-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kjsembed%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/210/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Feb 2017 12:53:02 + Build duration: 1 min 3 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kjsembed master kf5-qt5 » Linux,gcc - Build # 210 - Fixed!

2017-02-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kjsembed%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/210/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Feb 2017 12:53:02 + Build duration: 1 min 3 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kjsembed master kf5-qt5 » Linux,gcc - Build # 209 - Failure!

2017-02-11 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kjsembed%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/209/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Feb 2017 12:22:48 + Build duration: 1 min 3 sec CHANGE SET Revision

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 240 - Fixed!

2017-02-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/240/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Feb 2017 12:17:12 + Build duration: 1 min 44 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 240 - Fixed!

2017-02-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/240/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Feb 2017 12:17:12 + Build duration: 1 min 44 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 245 - Fixed!

2017-02-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/245/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Feb 2017 11:57:31 + Build duration: 1 min 43 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 245 - Fixed!

2017-02-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/245/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Feb 2017 11:57:31 + Build duration: 1 min 43 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 239 - Still Unstable!

2017-02-11 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/239/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Feb 2017 10:59:53 + Build duration: 8 min 10 sec CHANGE SET Revision

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 427 - Still Unstable!

2017-02-11 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/427/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Feb 2017 10:56:57 + Build duration: 5 min 59 sec CHANGE SET Revision

Jenkins-kde-ci: ktextwidgets master stable-kf5-qt5 » Linux,gcc - Build # 153 - Unstable!

2017-02-11 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktextwidgets%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/153/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Feb 2017 10:56:57 + Build duration: 1 min 6 sec CHANGE SET Revision

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 244 - Unstable!

2017-02-11 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/244/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Feb 2017 10:45:54 + Build duration: 5 min 28 sec CHANGE SET Revision

[Differential] [Request, 8 lines] D4564: KToolTipWidget: hide tooltip in enterEvent if hideDelay is zero

2017-02-11 Thread Elvis Angelaccio
elvisangelaccio created this revision. elvisangelaccio added a reviewer: cfeck. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Otherwise the tooltip will stay visible when the mouse cursor (by accident) hovers it.

[Differential] [Accepted] D4552: [PreviewJob] Remove maximum size for local files by default

2017-02-11 Thread Eike Hein
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D4552 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, dfaure, emmanuelp, hein Cc: #frameworks