ltoscano created this revision.
Restricted Application added projects: Frameworks, Documentation.
Restricted Application added subscribers: Documentation, Frameworks.
REVISION SUMMARY
Convert all occurrencies of q{Debug,Warning,Critical,...},
including the calls commented.
Cleanup for
davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Unlike the visible property, the opacity does not inherit parent values
and refers to the relative opacity of
mvourlakos added a comment.
I just noticed...
you dont have to go too far...
any qt application using 5.8 has this problem...
even qtcreator...
showing a menu and then deactivating it from outside areas then the window
needs a click from the user
in order for this window to react
mvourlakos added a comment.
You can observe the faulty behavior even with Qt's "Menu's Example".
1. Open any menu you want either with right click or from the menu
2. Close it by clicking in any outside area you want, that is (not inside the
menu example window and not in the menu)
kfunk abandoned this revision.
kfunk added a comment.
Okay, please do.
REPOSITORY
R238 KDocTools
REVISION DETAIL
https://phabricator.kde.org/D4727
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kfunk, #frameworks, ltoscano
Cc: #frameworks,
ltoscano requested changes to this revision.
ltoscano added a comment.
This revision now requires changes to proceed.
I will work on switching to categorized logging (with logs like that hidden
by defaults)
REPOSITORY
R238 KDocTools
REVISION DETAIL
https://phabricator.kde.org/D4727
kfunk added a reviewer: ltoscano.
REPOSITORY
R238 KDocTools
REVISION DETAIL
https://phabricator.kde.org/D4727
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kfunk, #frameworks, ltoscano
Cc: #frameworks, #documentation
kfunk added a reviewer: Frameworks.
REPOSITORY
R238 KDocTools
REVISION DETAIL
https://phabricator.kde.org/D4727
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kfunk, #frameworks
Cc: #frameworks, #documentation
kfunk created this revision.
Restricted Application added projects: Frameworks, Documentation.
Restricted Application added subscribers: Documentation, Frameworks.
REPOSITORY
R238 KDocTools
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4727
AFFECTED FILES
src/xslt.cpp
anthonyfieroni added a comment.
I'm not pretty sure, but
https://code.woboq.org/qt5/qtbase/src/widgets/kernel/qwidgetwindow.cpp.html#374
on click at other window we have enter && mouseGrabber
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
mvourlakos added a comment.
In https://phabricator.kde.org/D4711#88621, @mart wrote:
> do you know exactly what/where changed?
sorry if this is irrelevant...
I dont know if the above code works but in my code tree in latte dock I can
not do anything to ungrabMouse in Qt 5.8 in
mart added a comment.
do you know exactly what/where changed?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4711
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: anthonyfieroni, #plasma, broulik, mart
Cc:
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4556
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson,
drosca added a comment.
> they may end up looking a bit blurry
They are SVGs in Breeze, so they won't look blurry, with other icon themes it
may be an issue. But then again, the same issue is already there when you
request big icon (for which roundToIconSize() returns the passed size ~
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4679
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma, mart
Cc:
mart added a comment.
In https://phabricator.kde.org/D4689#88209, @drosca wrote:
> Yes, I want to use it in plasma-pa applet for volume indicator icons (the
small icon next to slider). Currently, they are too small but next round icon
size is already too big. This change will make it
mart updated this revision to Diff 11632.
mart added a comment.
- more guards on null frame
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4707?vs=11627=11632
BRANCH
arcpatch-D4707
REVISION DETAIL
https://phabricator.kde.org/D4707
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:8e360714a46a: Fix APIDOX issues raised by clang's
-Wdocumentation (authored by cfeck).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D4658?vs=11476=11631#toc
REPOSITORY
R236 KWidgetsAddons
mart updated this revision to Diff 11630.
mart marked 2 inline comments as done.
mart added a comment.
updated with https://phabricator.kde.org/D4522
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4508?vs=11082=11630
BRANCH
mart retitled this revision from "[WIP] Plasma controls based on
QtQuickControls2" to "Plasma controls based on QtQuickControls2".
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4508
EMAIL PREFERENCES
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:0fd0389f02b3: export implicitheight from background
(authored by mart).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4522?vs=11108=11629
mart edited the test plan for this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4707
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma
Cc: plasma-devel, #frameworks, progwolff, lesliezhai,
mart updated this revision to Diff 11627.
mart added a comment.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
remove useless variable
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
cfeck added inline comments.
INLINE COMMENTS
> aacid wrote in kpagewidget.h:143
> Does the other @param in this line also need to be @p ? Or even removed?
You are correct. I just checked the rendering on api.kde.org, and both should
just use @p, otherwise it would start a new line for the
mart requested review of this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4707
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma
Cc: #frameworks
mart edited the test plan for this revision.
mart added a reviewer: Plasma.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4707
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma
Cc: #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:e301b636858b: Fix binding loop regression in FrameSVGItem
(authored by davidedmundson).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
broulik accepted this revision.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4713
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma, #frameworks, mart, broulik
Cc: mart,
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4713
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson,
davidedmundson updated this revision to Diff 11621.
davidedmundson added a comment.
Updated
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4713?vs=11609=11621
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4713
elvisangelaccio updated this revision to Diff 11620.
elvisangelaccio added a comment.
- Removed redundant dir check
- Removed unused include
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4690?vs=11597=11620
BRANCH
import-remote
REVISION DETAIL
arichardson created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Add a few 64-bit MIPS instruction mnemonics
Add c-preprocessor.xml highlighting file to be included
Extracted and slightly
mart requested changes to this revision.
mart added a comment.
This revision now requires changes to proceed.
i can reproduce kai's problems, luckily the fix seems easy
INLINE COMMENTS
> framesvg.cpp:757
> fd->theme = q->theme()->d;
> -updateAndSignalSizes();
> +if (updateType
broulik added a comment.
While this fixes the binding loop warnings, it doesn't fix the broken margins
in places like NM list delegates. +1 nonetheless.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4713
EMAIL PREFERENCES
> On Jan. 2, 2017, 9:38 a.m., David Faure wrote:
> > Renaming is really a special case of moving. Saying that "kio_trash doesn't
> > support renaming" is correct but only a partial truth. It also doesn't
> > support moving from trash:/ to trash:/subdir/. So it would be more correct
> > to say
35 matches
Mail list logo
