pino added a comment.
Ping?
REPOSITORY
R270 KCodecs
REVISION DETAIL
https://phabricator.kde.org/D3883
To: pino, #frameworks
pino added a comment.
Ping?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D3830
To: pino, #frameworks, #build_system, #windows, kde-mac
Cc: kfunk, rjvbb, adridg
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/393/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Wed, 05 Apr 2017 01:59:35 +
Build duration: 3 min 18 sec
CHANGE SET
Revision
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/393/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Wed, 05 Apr 2017 01:59:35 +
Build duration: 3 min 18 sec
CHANGE SET
Revision
aacid added a comment.
Do you know where we do the parsing that allows both gui and kpartgui to be
"valid"?
I did some searching and i think i found it but would be nice if you can find
it and we agree on it D:
REPOSITORY
R263 KXmlGui
REVISION DETAIL
apol added a comment.
+1
Which warnings? Are they proper warnings that should be fixed?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5302
To: kfunk, kossebau, dfaure
Cc: apol, #frameworks, #build_system
apol added a comment.
How is this problem addressed elsewhere?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5290
To: heikobecker, #frameworks, #build_system
Cc: apol
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:6d7468be4cc6: autotests: Use QTEST_GUILESS_MAIN (authored
by heikobecker).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D5274?vs=13044=13099#toc
REPOSITORY
R286 KFileMetaData
CHANGES
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/493/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 04 Apr 2017 19:17:08 +
Build duration: 5 min 51 sec
CHANGE SET
No changes
JUNIT RESULTS
Name: (root)
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:47a4c068a4ec: FindPyModGen: Also search for an
unversioned clang++ (authored by heikobecker).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kdesignerplugin%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/166/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 04 Apr 2017 18:22:50 +
Build duration: 1 min 7 sec
CHANGE SET
No changes
JUNIT RESULTS
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kdesignerplugin%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/166/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 04 Apr 2017 18:22:50 +
Build duration: 1 min 7 sec
CHANGE SET
No changes
JUNIT RESULTS
kfunk updated this revision to Diff 13096.
kfunk added a comment.
Re-enable for Clang
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5302?vs=13094=13096
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5302
AFFECTED FILES
heikobecker added a comment.
In https://phabricator.kde.org/D5289#99625, @shaheed wrote:
> Fwiw, I think that a specific version check may not be needed. The original
> code I wrote, which I assume Steve may have simply carried forward in the
> cmake ecm logic, DID have a version
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kguiaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/147/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 04 Apr 2017 18:01:17 +
Build duration: 51 sec
CHANGE SET
No changes
JUNIT RESULTS
Name:
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kguiaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/147/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 04 Apr 2017 18:01:17 +
Build duration: 51 sec
CHANGE SET
No changes
JUNIT RESULTS
Name:
heikobecker added a comment.
In https://phabricator.kde.org/D5290#99713, @apol wrote:
> That's not how ECM is intended to work, these find modules are supposed to
be separate from the variables we use in KDE.
> What problem are you trying to address?
My distro uses a
kfunk added reviewers: kossebau, dfaure.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5302
To: kfunk, kossebau, dfaure
Cc: #frameworks, #build_system
kfunk created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY
Add it to KDECompilerSettings.cmake instead of
KDEFrameworkCompilerSettings.cmake.
Users can then just enable
markg added a reviewer: dfaure.
markg added inline comments.
INLINE COMMENTS
> kdirlistertest_gui.cpp:128-138
> /* lister->openUrl( home, KDirLister::Keep );
>lister->openUrl( root, KDirLister::Keep | KDirLister::Reload );
>lister->openUrl( QUrl::fromLocalFile("file:/etc"),
russellg added a comment.
Alright, I will in the future :)
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D4778
To: russellg, #frameworks, kfunk
Cc: kfunk
kfunk accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5299
To: davidedmundson, #frameworks, kfunk
apol added a reviewer: ilic.
apol added a comment.
Ping?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5143
To: apol, #frameworks, #build_system, kfunk, ltoscano, aacid, ilic
Cc: sitter
davidedmundson created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
We either need to set the URL file:/dev or use QUrl::fromLocalFile, not
both.
TEST PLAN
Clicked button, got some ouptut instead of an error
REPOSITORY
R241 KIO
BRANCH
master
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5291
To: heikobecker, #frameworks, #build_system, apol
apol added a comment.
That's not how ECM is intended to work, these find modules are supposed to be
separate from the variables we use in KDE.
What problem are you trying to address?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5290
To:
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
UNiQ10-patch-1
REVISION DETAIL
https://phabricator.kde.org/D5297
To: davidedmundson, #plasma, broulik
Cc: ltoscano, plasma-devel, #frameworks, progwolff,
ltoscano added a comment.
please remember the right credentials when you push, if this is accepted
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D5297
To: davidedmundson, #plasma
Cc: ltoscano, plasma-devel, #frameworks, progwolff, lesliezhai,
davidedmundson added a comment.
Not authored by me, imported from a patch on github.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D5297
To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed,
davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
The reference textField is undefined in this context
It works if the style happens to be used from
kfunk added a comment.
I've pushed your patch now. Usually the author is responsible for pushing, as
long as he has commit access to our infrastructure ;)
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D4778
To: russellg, #frameworks, kfunk
Cc: kfunk
31 matches
Mail list logo
