bruns added inline comments.
INLINE COMMENTS
> fstabdevice.cpp:47
>
> -m_description = m_vendor + " on " + m_product;
> +const QStringList =
> FstabHandling::options(m_device).filter("x-gvfs-");
> +
Why QStringList& instead of QStringList?
> fstabdevice.cpp:51
> +if
elvisangelaccio added a comment.
In https://phabricator.kde.org/D5312#100027, @fvogt wrote:
> Tested locally, works fine!
>
> The behaviour is a bit unexpected, but IMO correct:
>
> - Enter a password
> - Make it visible
> - Delete it
> - Toggle visibility ->
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/496/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 06 Apr 2017 19:04:32 +
Build duration: 8 min 27 sec
CHANGE SET
Revision 584c5eb1ea48e8f5949f35539b7101b89a211fd1
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/496/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 06 Apr 2017 19:04:32 +
Build duration: 8 min 27 sec
CHANGE SET
Revision 584c5eb1ea48e8f5949f35539b7101b89a211fd1
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/499/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 06 Apr 2017 19:01:05 +
Build duration: 8 min 3 sec
CHANGE SET
Revision
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/499/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 06 Apr 2017 19:01:05 +
Build duration: 8 min 3 sec
CHANGE SET
Revision
drosca abandoned this revision.
drosca added a comment.
> However, if your UI language is all Spanish and you want to use the US date
formatting, the month name labels would suddenly be in English while they
should remain Spanish (and this is what the code you're removing does).
Well,
mck182 added a comment.
I disagree with this because we currently don't have any
easy and/or sensible way to change date formats and so
we simply suggest using different locales for the different
formats. However, if your UI language is all Spanish and
you want to use the US date
drosca created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Qt.locale().standaloneMonthName() is used from QML side in MonthView,
so using the same code on C++ part again makes
elvisangelaccio updated this revision to Diff 13163.
elvisangelaccio edited the summary of this revision.
elvisangelaccio added a comment.
Addressed all David's issues.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5030?vs=12414=13163
REVISION DETAIL
elvisangelaccio added a comment.
Ok I got it working, thanks. There is a downside though, it seems the module
is never deleted, not even when kiod5 quits. Bug in kiod? It was deleted as
expected with kded, instead.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D5030
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/495/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 06 Apr 2017 17:29:15 +
Build duration: 40 sec
CHANGE SET
Revision 781cfa4e2ba739ee864683a3c783572852f43984 by
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/498/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 06 Apr 2017 17:26:41 +
Build duration: 54 sec
CHANGE SET
Revision 781cfa4e2ba739ee864683a3c783572852f43984
apol added a comment.
@ltoscano ping? (you asked me for this... )
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D5167
To: apol, #frameworks, sitter, ltoscano, ilic
Cc: aacid
apol added a comment.
If there's no comments, I'll push this tomorrow.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5087
To: apol, #frameworks, #build_system
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:781cfa4e2ba7: Generate a moc_predefs.h file for KIOCore
(authored by apol).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5319?vs=13160=13162
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:e6982aba: Introduce fetch-translations build command
(authored by apol).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5143?vs=13117=13161
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Thanks. I don't agree that it was a small optimization, because regenerating
a header file means recompiling all the files that include it, every single
time. It's the job of a build
apol updated this revision to Diff 13160.
apol added a comment.
Probably the smallest optimization ever. :)
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5319?vs=13151=13160
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5319
AFFECTED FILES
dfaure added a comment.
Yes, that should be it. And for good practice, rather than hardcoding kded5
or kiod5 in the calling code, create a dbus .service file to autostart it (two
purposes: making it independent from whoever is hosting the service, and
starting kiod if it's not already
elvisangelaccio marked 3 inline comments as done.
elvisangelaccio added a comment.
In https://phabricator.kde.org/D5030#98126, @dfaure wrote:
> Nice idea.
>
> Can you use kiod rather than kded? Same plugin mechanism exactly but this
way no dependency on kded.
How do I do
dfaure added inline comments.
INLINE COMMENTS
> CMakeLists.txt:165
> +if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang" OR CMAKE_CXX_COMPILER_ID STREQUAL
> "GNU")
> +execute_process(COMMAND "${CMAKE_CXX_COMPILER}" "-dM" "-E" "-c"
> "${CMAKE_ROOT}/Modules/CMakeCXXCompilerABI.cpp"
> +
apol edited the test plan for this revision.
apol added reviewers: Frameworks, dfaure, cgilles.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D5319
To: apol, #frameworks, dfaure, cgilles
Cc: #frameworks
apol updated this revision to Diff 13151.
apol added a comment.
Unused variable
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5319?vs=13150=13151
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5319
AFFECTED FILES
autotests/CMakeLists.txt
apol updated this revision to Diff 13150.
apol added a comment.
Address issues
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5319?vs=13148=13150
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5319
AFFECTED FILES
autotests/CMakeLists.txt
apol created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Otherwise moc gets through wrong files in some platforms that have weird
preprocessor hacks to support large files on 32 bits systems.
This
fvogt accepted this revision.
fvogt added a comment.
This revision is now accepted and ready to land.
Tested locally, works fine!
The behaviour is a bit unexpected, but IMO correct:
- Enter a password
- Make it visible
- Delete it
- Toggle visibility
-> VisibilityAction
tcberner added a comment.
We talked about it some more, and think that it is maybe better to not do any
cmake magic.
#ifdef st_birthtime
if (buff.st_birthtime > 0) {
entry.insert(KIO::UDSEntry::UDS_CREATION_TIME,
buff.st_birthtime);
}
#endif
28 matches
Mail list logo
