Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 504 - Failure!

2017-04-07 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/504/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 08 Apr 2017 02:16:33 + Build duration: 3 min 1 sec CHANGE SET Revision

D5275: Kapidox generates qch files

2017-04-07 Thread Olivier Churlaud
ochurlaud added a comment. In https://phabricator.kde.org/D5275#99677, @antonanikin wrote: > Hi, Olivier. > > Your QCH files displayed normally but with one bug - broken links for some JavaScript code. For example open `KTipDialog` class doc from your `Frameworks` file. Then try to

D5275: Kapidox generates qch files

2017-04-07 Thread Olivier Churlaud
ochurlaud updated this revision to Diff 13209. ochurlaud added a comment. Corrected antonanikin issue REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5275?vs=13076=13209 BRANCH olivier/do_qch REVISION DETAIL https://phabricator.kde.org/D5275 AFFECTED

D5338: Add syntax highlighting file for Doxyfile

2017-04-07 Thread Kevin Funk
kfunk edited the summary of this revision. kfunk added reviewers: vkrause, dhaumann, kwrite-devel. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5338 To: kfunk, vkrause, dhaumann, kwrite-devel Cc: #frameworks

D5338: Add syntax highlighting file for Doxyfile

2017-04-07 Thread Kevin Funk
kfunk created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D5338 AFFECTED FILES data/syntax/doxyfile.xml To: kfunk

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 274 - Unstable!

2017-04-07 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/274/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 07 Apr 2017 16:01:11 + Build duration: 4 min 36 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 170 - Fixed!

2017-04-07 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/170/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 07 Apr 2017 14:52:50 + Build duration: 1 min 49 sec CHANGE SET No

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 170 - Fixed!

2017-04-07 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/170/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 07 Apr 2017 14:52:50 + Build duration: 1 min 49 sec CHANGE SET No

D5030: kioexec: delegate upload to a kded module

2017-04-07 Thread Elvis Angelaccio
elvisangelaccio updated this revision to Diff 13202. elvisangelaccio marked an inline comment as done. elvisangelaccio added a comment. - Tested against latest master, now the module is properly cleaned up upon kiod destruction. - Use iterators for the map REPOSITORY R241 KIO CHANGES

Re: Review Request 130069: Reproducible builds: drop version from XMLGUI_COMPILING_OS

2017-04-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130069/#review102998 --- +1 - Aleix Pol Gonzalez On abr. 7, 2017, 4:47 p.m.,

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 169 - Unstable!

2017-04-07 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/169/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 07 Apr 2017 14:07:11 + Build duration: 4 min 11 sec CHANGE SET No

Review Request 130069: Reproducible builds: drop version from XMLGUI_COMPILING_OS

2017-04-07 Thread Maximiliano Curia
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130069/ --- Review request for KDE Frameworks. Repository: kxmlgui Description

D5332: Move the repository name recognition into a function

2017-04-07 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R240:2cf8a01f35de: Move the repository name recognition into a function (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D5332: Move the repository name recognition into a function

2017-04-07 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 13186. apol added a comment. Uncomment... REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5332?vs=13185=13186 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5332 AFFECTED FILES

D5332: Move the repository name recognition into a function

2017-04-07 Thread Bhushan Shah
bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D5332 To: apol, bshah Cc: #frameworks, #build_system

D5332: Move the repository name recognition into a function

2017-04-07 Thread Aleix Pol Gonzalez
apol created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY Otherwise it would pollute the namespace and weird things happened on some projects REPOSITORY R240 Extra CMake

D5167: Move .po and .ts files look-up to build-time

2017-04-07 Thread Harald Sitter
sitter added a comment. The code currently isn't working for po/ in source dir and you are losing a public function. See inline comments. (Why there are no autotests for a complicated, involved, and important function like ki18n_install is entirely beyond my appreciation. How in the

D5329: Fix KActionSelectorPrivate::insertionIndex()

2017-04-07 Thread Anton Anikin
antonanikin edited the summary of this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D5329 To: antonanikin, #frameworks Cc: kde-frameworks-devel

D5329: Fix KActionSelectorPrivate::insertionIndex()

2017-04-07 Thread Anton Anikin
antonanikin added a subscriber: kde-frameworks-devel. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D5329 To: antonanikin, #frameworks Cc: kde-frameworks-devel

D5329: Fix KActionSelectorPrivate::insertionIndex()

2017-04-07 Thread Anton Anikin
antonanikin created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Old version ignores InsertionPolicy::AtBottom enum value and produce behavior same as for InsertionPolicy::AtTop. REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL

D5328: Ignore warnings during appdata generation

2017-04-07 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R290:a0da2bd735d0: Ignore warnings during appdata generation (authored by fvogt). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5328?vs=13175=13176 REVISION DETAIL

D5328: Ignore warnings during appdata generation

2017-04-07 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D5328 To: fvogt, mart, apol Cc: #frameworks

D5328: Ignore warnings during appdata generation

2017-04-07 Thread Fabian Vogt
fvogt created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY The Plasma/PopupApplet service type for example got deprecated and removed, but is still used by various parts of Plasma 5.8. This causes kpackagetool to emit warnings, but it still succeeds.

D5030: kioexec: delegate upload to a kded module

2017-04-07 Thread David Faure
dfaure added a comment. Good point, I added a destructor to KIOD now, please try again ;) INLINE COMMENTS > kioexecd.cpp:54 > +{ > +const auto files = m_watched.keys(); > +for (const auto : files) { btw iterating over keys() is bad practice (slow because it requires creating and