Re: Review Request 130090: Fix incorrect definition of major(3)/minor(3) macros

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130090/#review103063 --- src/solid/devices/backends/udisks2/udisksblock.cpp (line

Test failures with kdelibs4support

Hi, I try building kdelibs4support 5.32.0 for GNU Guix . GNU Guix builds all software within a container, which does not have any network interface nor any service running except if explicitly started. kdelibs4support builds fine, but some tests are failing.

D5394: KAuth integration in document saving - vol. 2

fvogt added a comment. Thanks! Only one issue remaining (I somehow missed during the last time): Directory rename race. Someone with the appropriate permissions (unlikely) could change the directory the path refers to in between the verification and the chmod/fchown/rename.

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 179 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/179/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 18 Apr 2017 08:29:08 + Build duration: 3 min 56 sec CHANGE SET

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 522 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/522/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 18 Apr 2017 08:21:58 + Build duration: 18 min CHANGE SET Revision

Re: Threadweaver compilation failure: Windows

On Tue, Apr 18, 2017 at 6:53 PM, Kevin Funk wrote: > On Monday, 17 April 2017 22:43:56 CEST Aleix Pol wrote: >> On Mon, Apr 17, 2017 at 6:09 AM, Ben Cooksley wrote: >> > Hi all, >> > >> > If someone could take a look at the following build log that would be >> >

D5489: Sanitizers: Don't use GCC-like flags for e.g. MSVC

bcooksley accepted this revision. bcooksley added a comment. Looks good to me - thanks for taking this on, it'll make getting CI working for Windows much easier. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D5489 To: kfunk, aacid,

D5489: Sanitizers: Don't use GCC-like flags for e.g. MSVC

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Makes sense, the other option would be actually erroring out as we do in check_compiler_version if you don't run "the correct clang/gcc", but i guess this may be enough for MSVC at this

D5489: Sanitizers: Don't use GCC-like flags for e.g. MSVC

kfunk added reviewers: aacid, bcooksley. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5489 To: kfunk, aacid, bcooksley Cc: #frameworks, #build_system

D5489: Sanitizers: Don't use GCC-like flags for e.g. MSVC

kfunk created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY Fixes compiler warnings such as: cl : Command line warning D9002 : ignoring unknown option

Jenkins-kde-ci: threadweaver master stable-kf5-qt5 » Linux,gcc - Build # 157 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/threadweaver%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/157/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 18 Apr 2017 06:52:14 + Build duration: 5 min 22 sec CHANGE SET Revision

Jenkins-kde-ci: threadweaver master stable-kf5-qt5 » Linux,gcc - Build # 157 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/threadweaver%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/157/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 18 Apr 2017 06:52:14 + Build duration: 5 min 22 sec CHANGE SET Revision

D5430: KDECompilerSettings: Pass -Wvla & -Wdate-time

This revision was automatically updated to reflect the committed changes. Closed by commit R240:0348332744d2: KDECompilerSettings: Pass -Wvla & -Wdate-time (authored by kfunk). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5430?vs=13476=13554

Re: Threadweaver compilation failure: Windows

On Monday, 17 April 2017 22:43:56 CEST Aleix Pol wrote: > On Mon, Apr 17, 2017 at 6:09 AM, Ben Cooksley wrote: > > Hi all, > > > > If someone could take a look at the following build log that would be > > appreciated: > > https://paste.kde.org/pzyhxydjw/xxx39x/raw > > Include