jgrulich added a comment.
In https://phabricator.kde.org/D5775#108825, @apol wrote:
> In https://phabricator.kde.org/D5775#108649, @jgrulich wrote:
>
> > In https://phabricator.kde.org/D5775#108558, @aacid wrote:
> >
> > > I don't think this is a fix.
> > >
> > > I can't
graesslin added a comment.
In https://phabricator.kde.org/D5747#108916, @apol wrote:
> Who is going to be setting this pid? Because note that containerized
applications don't know their own pid (see kdbusaddons & knotifications patches
for big shrug).
It's KWin. Who gets the
cfeck edited the summary of this revision.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D5821
To: cfeck, #frameworks
Cc: mlaurent
cfeck created this revision.
cfeck added a project: Frameworks.
REVISION SUMMARY
According to bug 353380, KViewStateSerializer::restoreScrollBarState() calls
QScrollBar::maximum() on an invalid (i.e. already deleted) scrollbar. This
means, the enclosing QAbstractScrollArea has been deleted
apol added a comment.
Who is going to be setting this pid? Because note that containerized
applications don't know their own pid (see kdbusaddons & knotifications patches
for big shrug).
$ docker run ubuntu:17.04 pidof pidof
1
$ pidof pidof
6940
REPOSITORY
R127 KWayland
hein added a dependent revision: D5818: Lift app identification heuristic out
of XWindowTasksModel and share it with WaylandTasksModel..
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5747
To: sebas, #plasma, hein, graesslin
Cc: davidedmundson, plasma-devel,
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/oxygen%20Plasma-5.10%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 11 May 2017 17:34:27 +
Build duration: 7 min 52 sec
CHANGE SET
No changes
JUNIT RESULTS
sebas updated this revision to Diff 14418.
sebas added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
- Drop pid change handling in the model code
- Extend model test
--Eike on sebas' box
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R235:4eb7bcfbbd49: Improve error notification (authored by
apol).
REPOSITORY
R235 Attica
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5811?vs=14402=14415
REVISION DETAIL
hein added a comment.
Well my point was that the patch does add code to both tests (modulo the
things you asked to be extended now).
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5757
To: mart, #plasma, hein, graesslin, #plasma_on_wayland
Cc: graesslin, hein,
apol added a comment.
In https://phabricator.kde.org/D5775#108649, @jgrulich wrote:
> In https://phabricator.kde.org/D5775#108558, @aacid wrote:
>
> > I don't think this is a fix.
> >
> > I can't really i good faith recommend people to use Okular from a flatpak
if that means they
graesslin added a comment.
In https://phabricator.kde.org/D5757#108706, @hein wrote:
> Martin, did you mix things up here maybe? The patch has changes to
autotests/client/test_wayland_windowmanagement.cpp. The "newRow" bit isn't
related to QAIM. It's a row of test data.
no, I
graesslin added a comment.
Forget my last two comments - confused the review
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5757
To: mart, #plasma, hein, graesslin, #plasma_on_wayland
Cc: graesslin, hein, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff,
graesslin added inline comments.
INLINE COMMENTS
> test_plasma_window_model.cpp:215
>
> void PlasmaWindowModelTest::testRoleNames_data()
> {
Please extend this
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5747
To: sebas, #plasma, hein, graesslin
Cc:
graesslin added inline comments.
INLINE COMMENTS
> test_plasma_window_model.cpp:214
>
> void PlasmaWindowModelTest::testRoleNames_data()
> {
Please extend this
> test_plasma_window_model.cpp:306
>
> void PlasmaWindowModelTest::testDefaultData_data()
> {
Please extend this
REPOSITORY
graesslin added inline comments.
INLINE COMMENTS
> plasmawindowmodel.cpp:84-86
> +QObject::connect(window, ::pidChanged, q,
> +[window, this] { this->dataChanged(window, PlasmaWindowModel::Pid); }
> +);
I consider it as impossible that the PID changes.
REPOSITORY
R127
sebas updated this revision to Diff 14410.
sebas added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
- also test default
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5747?vs=14407=14410
BRANCH
sebas updated this revision to Diff 14407.
sebas marked 3 inline comments as done.
sebas added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
Address review comments
- Minor corrections in docs
- Use uint for the pid
- uint32 for pids
hein abandoned this revision.
hein added a comment.
Done.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5812
To: hein, #plasma, sebas, graesslin
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, eliasp,
sebas added a comment.
Adding it to https://phabricator.kde.org/D5747 for merge simplicity. @hein
please abandon.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5812
To: hein, #plasma, sebas, graesslin
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff,
hein added a dependency: D5747: add pid to plasma window management protocol.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5812
To: hein, #plasma, sebas, graesslin
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai,
ali-mohamed, jensreuterberg,
hein added a dependent revision: D5812: Add missing block to make sure initial
pid is sent.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5747
To: sebas, #plasma, hein, graesslin
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff,
hein created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Without this I just get the default 0 from the client iface.
REPOSITORY
R127 KWayland
BRANCH
arcpatch-D5747
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:6207a87b71d7: Internal cache for provider data on
initialisation (authored by leinir).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5639?vs=14243=14403
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:b8d0bc8818ff: Use a single QNAM (and a disk cache) for
HTTP jobs (authored by leinir).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5638?vs=14244=14404
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.
lgtm :)
REPOSITORY
R235 Attica
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5811
To: apol, #frameworks, leinir
apol created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Forward the actuall error instead of "Network Error"
Include a slot that will print an error message as it arrives.
REPOSITORY
R235 Attica
BRANCH
master
REVISION DETAIL
hein added a comment.
Martin, did you mix things up here maybe? The patch has changes to
autotests/client/test_wayland_windowmanagement.cpp. The "newRow" bit isn't
related to QAIM. It's a row of test data.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5757
To:
davidedmundson added inline comments.
INLINE COMMENTS
> qmenu.cpp:322-327
> +if (parentItem) {
> +//create the QWindow
> +m_menu->winId();
> +m_menu->windowHandle()->setTransientParent(parentItem->window());
> +}
> }
why not just also do
davidedmundson added a comment.
I've made it compatible.
There will be some differences, especially for popup but we want that
difference exposed in some hasBlahCapability() flag, so we can redirect the
test as appropriate.
REPOSITORY
R127 KWayland
BRANCH
davidedmundson/xdgv6
mart added reviewers: Plasma on Wayland, Frameworks.
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D5806
To: mart, #plasma, #plasma_on_wayland, #frameworks
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts,
mart retitled this revision from "[WIP] when building menu hierarchies, parent
menus to their containers" to "[WIP] when building menu hyerarchies, parent
menus to their containers".
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D5806
To: mart, #plasma,
mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Wayland requires menu windows to have a "transient parent" as wl_shell
protocol refuses to either position correcty or
33 matches
Mail list logo
