D6042: Don't use the path as is if it's a data: url

apol created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY The path is the content, so it basically will set the same content as filename. This change it to default to "data" in a case where I identified it to be a problem, it could possibly be useful

D6041: Port a bunch of classes away from Plasma::Package

apol created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Ported away some classes, removes many unneeded casts that happen when starting. TEST PLAN Tests still pass, plasma starts

D5972: Set (and unset, as necessary) QT_NO_EXCEPTIONS for Clang (and ICC)

thiago added a comment. In https://phabricator.kde.org/D5972#112994, @rjvbb wrote: > Yes, here too, haven't had time to read back up on and go through the whole Qt code review process. What branch should I target, anyway? 5.9, with a possible backport to 5.6. There's still time

D5972: Set (and unset, as necessary) QT_NO_EXCEPTIONS for Clang (and ICC)

rjvbb added a comment. In https://phabricator.kde.org/D5972#112975, @thiago wrote: > Makes sense to work around older versions of Qt without the fix. > > But it needs a fix. That is still pending. Yes, here too, haven't had time to read back up on and go through the whole Qt

D5972: Set (and unset, as necessary) QT_NO_EXCEPTIONS for Clang (and ICC)

thiago added a comment. Makes sense to work around older versions of Qt without the fix. But it needs a fix. That is still pending. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5972 To: rjvbb, #build_system, #frameworks, kfunk Cc: thiago,

Re: extra-cmake-modules in kdesupport?

On Tue, May 30, 2017 at 4:10 PM, Luigi Toscano wrote: > On Tuesday, 30 May 2017 16:06:56 CEST Harald Sitter wrote: >> Is there a reason ECM's project is placed in kdesupport rather than >> frameworks? >> >>

Re: extra-cmake-modules in kdesupport?

On Tuesday, 30 May 2017 16:06:56 CEST Harald Sitter wrote: > Is there a reason ECM's project is placed in kdesupport rather than > frameworks? > > https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects/kdesupport/ext > ra-cmake-modules > > Seems a bit fishy at best and practically means

extra-cmake-modules in kdesupport?

Is there a reason ECM's project is placed in kdesupport rather than frameworks? https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects/kdesupport/extra-cmake-modules Seems a bit fishy at best and practically means that if ECM ever were to get translations it wouldn't inherit the

D5865: Add missing KDE_ENABLE_NAMED_OPERATORS function

rjvbb edited the summary of this revision. rjvbb edited the test plan for this revision. rjvbb set the repository for this revision to R240 Extra CMake Modules. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5865 To: rjvbb, #frameworks, #build_system,

D5865: Add missing KDE_ENABLE_NAMED_OPERATORS function

rjvbb updated this revision to Diff 14971. rjvbb added a comment. Updated as requested. GIven the controversy I thought it might be useful to add at least a target-specific enabler macro (which may need some polishing or simplification - using generator expressions may not be required

D5865: Add missing KDE_ENABLE_NAMED_OPERATORS function

kfunk added a comment. In https://phabricator.kde.org/D5865#112766, @rjvbb wrote: > KDE is FOSS not bound to Microsoft by any corporate buy-in or whatever, right? What non-sense is this? Please stay on topic. There's a benefit we make sure KDE software is compiling under MSVC

D5972: Set (and unset, as necessary) QT_NO_EXCEPTIONS for Clang (and ICC)

rjvbb edited the summary of this revision. rjvbb added a reviewer: kfunk. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5972 To: rjvbb, #build_system, #frameworks, kfunk Cc: #frameworks, #build_system

D5865: Add missing KDE_ENABLE_NAMED_OPERATORS function

rjvbb added a comment. KDE is FOSS not bound to Microsoft by any corporate buy-in or whatever, right? If there's a bug to report it's the lack of standard compliance in MSVC - how have MS reacted to such reports? REPOSITORY R240 Extra CMake Modules REVISION DETAIL

KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build-sandbox.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/13/ Project: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 Date of build: Tue, 30 May 2017 07:07:14 + Build duration: 3 min 17 sec and counting

D5966: Fix race-condition in KRandom-seeding.

dfaure added inline comments. INLINE COMMENTS > tfry wrote in krandomtest.cpp:178 > If the results are not unique, some of the results will already be in the > set, and so results.insert() does not increase the size of the set. Only if > each thread result is unique, the set size will

D5966: Fix race-condition in KRandom-seeding.

tfry added inline comments. INLINE COMMENTS > dfaure wrote in krandomtest.cpp:168 > variable size array, which is not in the standard. > https://stackoverflow.com/questions/1887097/why-arent-variable-length-arrays-part-of-the-c-standard > > Make size static to fix it. Sorry. Should have waited

D5966: Fix race-condition in KRandom-seeding.

dfaure added a comment. No - not with this syntax. See the stackoverflow discussion I posted, or https://stackoverflow.com/questions/31645309/can-i-use-a-c-variable-length-array-in-c03-and-c11?rq=1 REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D5966 To: tfry,

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

tcberner updated this revision to Diff 14965. tcberner added a comment. Use QStorageInfo. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5784?vs=14334=14965 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5784 AFFECTED FILES